From: michael.christie@oracle.com
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com,
stefanha@redhat.com, eperezma@redhat.com,
virtualization@lists.linux.dev, kvm@vger.kernel.org
Cc: darren.kenny@oracle.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vhost-scsi: Improve error handling in vhost_scsi_make_nexus and tpg
Date: Wed, 11 Jun 2025 21:29:03 -0500 [thread overview]
Message-ID: <60653628-3078-43dd-9a51-5fd46be6f74a@oracle.com> (raw)
In-Reply-To: <20250611143932.2443796-2-alok.a.tiwari@oracle.com>
On 6/11/25 9:39 AM, Alok Tiwari wrote:
> Use PTR_ERR to return the actual error code when vhost_scsi_make_nexus
> fails to create a session, instead of returning -ENOMEM.
> This ensures more accurate error propagation.
>
> Replace NULL with ERR_PTR(ret) in vhost_scsi_make_tpg to follow kernel
> conventions for pointer-returning functions, allowing callers to use
> IS_ERR and PTR_ERR for proper error handling.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
next prev parent reply other threads:[~2025-06-12 2:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 14:39 [PATCH 1/2] vhost-scsi: Fix typos and formatting in comments and logs Alok Tiwari
2025-06-11 14:39 ` [PATCH 2/2] vhost-scsi: Improve error handling in vhost_scsi_make_nexus and tpg Alok Tiwari
2025-06-11 18:17 ` Stefan Hajnoczi
2025-06-12 2:29 ` michael.christie [this message]
2025-06-11 18:09 ` [PATCH 1/2] vhost-scsi: Fix typos and formatting in comments and logs Stefan Hajnoczi
2025-06-12 2:30 ` michael.christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60653628-3078-43dd-9a51-5fd46be6f74a@oracle.com \
--to=michael.christie@oracle.com \
--cc=alok.a.tiwari@oracle.com \
--cc=darren.kenny@oracle.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®