From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0687525EF9F; Fri, 9 May 2025 21:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746824421; cv=pass; b=eg9aShwB9huYQY+Y/hzFiSNQN4Px6CHx+vft9UV7rspf9HoXf6t4MCzJ6TiYMqEhy81k6aTRZplf5g58Xg5XdHb/L/faY0tb2oifySiFAS7AisUriogpPN48EMq9RMxexXlauk7vfYby/NMIk7ys4OA4IrK/msys21j42qlqhYo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746824421; c=relaxed/simple; bh=lY/Tlov385q9SwMzVQDQG13QsimqVwDYyDDWxzc9GVU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=AiRELE+JdCyrIotVnJJEQBthoFhAumSCpxh3vC05vmSL3728jJkGNi5p1BAKuvIfAfSKL5q3SuyGlXvD8VLMdNANTSNslz99pZDMNggPZbI2zEe7WaqOD1epdn6lVGEp5Pu8N5YBP/nwgovudZQLOWhpCA1WHDEVkZzTsiMyP90= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=eQHiEkGZ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="eQHiEkGZ" ARC-Seal: i=1; a=rsa-sha256; t=1746824377; cv=none; d=zohomail.com; s=zohoarc; b=iS4EoERGufg4h9g1Sl1xcp5SS6+dZUsOL6e90+pg9roc9bEMF02fh9+RWXuw1iITvuXyGlbVERga2E5LSSLiysGfbjxsaxuved3wdDmhi/JsO0LljNvVNBRXlID0ymB4LUbdIfMxgGX8ToBqI4vc1doBQLXmtTee7jcr9Rhinwk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1746824377; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=FQ4domWWSYQmkqX0C80/xhZ4Ifn039lPDyM32omypxc=; b=oF/tqNJc0cERpTkZ/UuyieL9WmvqufoRELL45cgQIRogmv04WwKbARRano3m6uDa+M49/jVWD05wajeoibuuXCo7r7VYtUpZQtvMsNSye5+hGU7bCFPGaD9IeiYK1cUEWYtcceY2bkoqwDIoojskvkAn4oKNonY+xYtGudu9/N4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1746824377; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=FQ4domWWSYQmkqX0C80/xhZ4Ifn039lPDyM32omypxc=; b=eQHiEkGZzH0NUVAy8D3N9US0q6Xgz5EDYqMHJsNaDyZSW6BZC7YUGG8jenJaG+g9 Upqp/xnhpi0Ca+ptCtyz+ofY+d9citpmp8ik1iL2jZ5HVDkbGTCZioHAx5Mrd2sOfOW KuSucLXi+VVvrHevjwcK9FtBG9zQjM7BL5dBRQXo= Received: by mx.zohomail.com with SMTPS id 1746824374242956.6494512089765; Fri, 9 May 2025 13:59:34 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Subject: Re: [PATCH 1/4] rust: drm: gem: Use NonNull for Object::dev From: Daniel Almeida In-Reply-To: <20250501183717.2058109-2-lyude@redhat.com> Date: Fri, 9 May 2025 17:59:15 -0300 Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Asahi Lina , Alyssa Rosenzweig Content-Transfer-Encoding: quoted-printable Message-Id: <6066097F-3A5C-4756-8772-300B27D2DF3A@collabora.com> References: <20250501183717.2058109-1-lyude@redhat.com> <20250501183717.2058109-2-lyude@redhat.com> To: Lyude Paul X-Mailer: Apple Mail (2.3826.500.181.1.5) X-ZohoMailClient: External Hi Lyude, > On 1 May 2025, at 15:33, Lyude Paul wrote: >=20 > There is usually not much of a reason to use a raw pointer in a data > struct, so move this to NonNull instead. >=20 > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/gem/mod.rs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs > index 0cafa4a424206..df8f9fdae5c22 100644 > --- a/rust/kernel/drm/gem/mod.rs > +++ b/rust/kernel/drm/gem/mod.rs > @@ -177,7 +177,7 @@ impl BaseObject for T where Self: = crate::types::AlwaysRefCounted + IntoGEMObj > #[pin_data] > pub struct Object { > obj: Opaque, > - dev: *const drm::Device, > + dev: NonNull>, > #[pin] > data: T, > } > @@ -212,7 +212,7 @@ pub fn new(dev: &drm::Device, size: = usize) -> Result> { > data <- T::new(dev, size), > // INVARIANT: The drm subsystem guarantees that the = `struct drm_device` will live > // as long as the GEM object lives. > - dev, > + dev: dev.into(), > }), > GFP_KERNEL, > )?; > @@ -237,7 +237,7 @@ pub fn new(dev: &drm::Device, size: = usize) -> Result> { > pub fn dev(&self) -> &drm::Device { > // SAFETY: The DRM subsystem guarantees that the `struct = drm_device` will live as long as > // the GEM object lives, hence the pointer must be valid. > - unsafe { &*self.dev } > + unsafe { self.dev.as_ref() } > } >=20 > fn as_raw(&self) -> *mut bindings::drm_gem_object { > --=20 > 2.48.1 >=20 >=20 Reviewed-by: Daniel Almeida