From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jin Qian <jinqian@android.com>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] power: validate wakeup source before activating it.
Date: Mon, 18 May 2015 02:34 +0200 [thread overview]
Message-ID: <6066146.sNzXFSI8Td@vostro.rjw.lan> (raw)
In-Reply-To: <CA+yUs=zjdEShJ=qg15b_CVtWSA1_wMXoc+fzm5psUZRQdN6Mrg@mail.gmail.com>
On Friday, May 15, 2015 06:28:17 PM Jin Qian wrote:
> Hi Rafael,
>
> The latest version is in [PATCHv3 1/3] power: validate wakeup source
> before activating it. I changed WARN_ONCE back to WARN since if
> multiple drivers activating uninitialized wakeup_sources, only the
> first driver will by flagged.
Which is OK.
If you're a user, you can't fix the problem by yourself and spamming the
logs with continued warnings doesn't help here.
If you're a developer, you'll fix the first driver and then see the
warning from the second one.
> We lost alert for other drivers. The warning should really happen during
> driver development. Hope this is ok.
First, I've applied your patch already. Second, I really think that
WARN_ON_ONCE() is better here.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2015-05-18 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 22:26 Jin Qian
2015-05-15 0:22 ` Rafael J. Wysocki
2015-05-16 1:28 ` Jin Qian
2015-05-18 0:34 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6066146.sNzXFSI8Td@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=gregkh@linuxfoundation.org \
--cc=jinqian@android.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®