From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965359AbdJQQ3o (ORCPT ); Tue, 17 Oct 2017 12:29:44 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:51779 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349AbdJQQ3m (ORCPT ); Tue, 17 Oct 2017 12:29:42 -0400 X-Google-Smtp-Source: AOwi7QBQI15LOHyy7qSe/HJnXqLSbLUGnBQIgWKTmnko253rEHX8ahSzRMngs6/dXLT+P0aDubg5zA== Subject: Re: [PATCH net 3/3] bpf: do not test for PCPU_MIN_UNIT_SIZE before percpu allocations To: Daniel Borkmann , davem@davemloft.net Cc: tj@kernel.org, ast@kernel.org, mark.rutland@arm.com, richard@nod.at, sp3485@columbia.edu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: From: John Fastabend Message-ID: <6067d705-dcc4-931a-a379-22311bbf0ee5@gmail.com> Date: Tue, 17 Oct 2017 09:29:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2017 07:55 AM, Daniel Borkmann wrote: > PCPU_MIN_UNIT_SIZE is an implementation detail of the percpu > allocator. Given we support __GFP_NOWARN now, lets just let > the allocation request fail naturally instead. The two call > sites from BPF mistakenly assumed __GFP_NOWARN would work, so > no changes needed to their actual __alloc_percpu_gfp() calls > which use the flag already. > > Signed-off-by: Daniel Borkmann > --- Nice cleanup. Thanks! Acked-by: John Fastabend