From: Dmitry Osipenko <digetx@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: use consumer->supply_name in debugfs/regulator_summary
Date: Wed, 15 Apr 2020 19:28:09 +0300 [thread overview]
Message-ID: <606b7ddd-0c9b-2ba1-f873-8507377fdc4e@gmail.com> (raw)
In-Reply-To: <731a4b299c6ae0ee9d8995157600a3477f21a36c.1585959068.git.mirq-linux@rere.qmqm.pl>
04.04.2020 03:11, Michał Mirosław пишет:
> Make it easier to identify regulator consumers when consumer device
> uses more than one supply.
>
> Before:
>
> regulator ena use open bypass voltage current min max
> -----------------------------------------------------------------------------------
> regulator-dummy 1 0 2 0 0mV 0mA 0mV 0mV
> 1-0010 0mV 0mV
> 1-0010 0mV 0mV
>
> After:
>
> regulator ena use open bypass voltage current min max
> -----------------------------------------------------------------------------------
> regulator-dummy 1 0 2 0 0mV 0mA 0mV 0mV
> 1-0010-vccio 0mV 0mV
> 1-0010-vcc33 0mV 0mV
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> drivers/regulator/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c340505150b6..ad143004c32b 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -5496,6 +5496,7 @@ static void regulator_summary_show_subtree(struct seq_file *s,
> seq_printf(s, "%*s%-*s ",
> (level + 1) * 3 + 1, "",
> 30 - (level + 1) * 3,
> + consumer->supply_name ? consumer->supply_name :
> consumer->dev ? dev_name(consumer->dev) : "deviceless");
>
> switch (rdev->desc->type) {
>
Hello Michał,
This is a very nice improvement, I like it!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
prev parent reply other threads:[~2020-04-15 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 0:11 Michał Mirosław
2020-04-15 16:28 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606b7ddd-0c9b-2ba1-f873-8507377fdc4e@gmail.com \
--to=digetx@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®