From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D984A6A001 for ; Thu, 12 Mar 2026 12:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773317738; cv=none; b=p84jC3FAKWslIgE+bC8Tg70/hxVxvPWT2hQzR4zDKV/jDouipTFAzNJNjGkyWehUW+loocWQbCzIYfgAwjQPsTFEkR8vdRlZcfoBYihpKyCA0X5V18tmPc/iWv01h5uDJovai02P6yO2jU6fCPkH5jDvEMxxWSvOk/llcvQhaWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773317738; c=relaxed/simple; bh=VGUC6wUOypIV4CsAk/cYVlAk1OOCaoat8J+NcnwZaqk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UnYipJYznF7WT1L6t9uGlrCCf69dMfsbnEf0owSHQq3BH/7tNBk6RuYyCbEIEk9hWRafr2Su7HcIPE3Zo5/EaY3YFWVQUoJLSn0bvvUdb+itjURFyky5z/1FE8SQoQE2GsauO9mrRkMfNOmjMQxqdbYH6kAweSAo7yfZP0euUIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ODJTs8II; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bXJ47++w; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ODJTs8II"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bXJ47++w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773317734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=loNIpigFiuTuj5urzh0sT/xjUHse+AOsRM2zfPikL40=; b=ODJTs8IIKinuIZPSkxiPDWNy60g4f79MmwqgDIPkjiTG3axr5DFR/q4/fiu7qKyckHDbvQ 0pZvxhIGlqHctNZaSXeZfiwe6UYZjfuS3w5LNebmOhxtXqK9b8TeBeJ6Fq27yAsfwAc1R9 XZv4QDHLgdLp2B4Qh3joGpP3sbAdpnk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-1fJX5p18PB-RgzV4j3Ceqg-1; Thu, 12 Mar 2026 08:15:33 -0400 X-MC-Unique: 1fJX5p18PB-RgzV4j3Ceqg-1 X-Mimecast-MFC-AGG-ID: 1fJX5p18PB-RgzV4j3Ceqg_1773317732 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48532df52c5so8402615e9.1 for ; Thu, 12 Mar 2026 05:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773317732; x=1773922532; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=loNIpigFiuTuj5urzh0sT/xjUHse+AOsRM2zfPikL40=; b=bXJ47++w5qRWlgCajG20ztHev//ND09tPL04sIVb44XJLHHvnIQFm7lDHhCK/Wemx+ ppq2tDhkJSlKhrfDuBiyJSJ02meVB2jw7tc5C298cRtKTQbu7+lYHK2EmGlLV3a6oMEQ TkgoJ691iT5/8PdUhD0ApHfCrd39GTJHOAn3f4uPHtfj5/tuOXkq+0hhDt5R+ccF2LEX dmuWuYQmzmzf1XSxdzvuBAJDKQxY9EyWMsNeNRwYA3qJWQzaYfH8FAbVn1IWdMHjgQfU zHJH4LCBRjf2emRlNlB60XfQGmwqUzSGbyOV7K/n3BwIyiUhtTB0fPoNmUJ6IT8m+eyl IPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773317732; x=1773922532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=loNIpigFiuTuj5urzh0sT/xjUHse+AOsRM2zfPikL40=; b=aELmlC4iMOB+rXBGlmXbi0f7XznGTnTBgH5nFq1twWqs4A03j98HawDMQcFq4paJpE 0WMV8zUT5DvvHIPkwM7dSyf34+JDuNtPbY1rR8Chvwdhsfe99xkL8b4NEpnFeiaDl64s yVIOLWERAuLc73/X6njHsVRNAbD2lt4GwEqvzkNUSr3Sugk31yaMgb1yZTy0CwDQdsvO qHzPX9hRc6hW3UWKL1nH7ukJ31tCFkaeH++JJQMXt/maDtmqISN9V2u8FoyGxO5naPw9 pNZElOzlX886KBXFX8osaP5D/XIq/CN3XJF9PHqEa6BTx6r0VUqdkuBB+dyL1rAqlXNy /XNw== X-Forwarded-Encrypted: i=1; AJvYcCVVHygEK+6jQNtDdCSkX/RfCPU92qViCEcS0P3oZeDTrfMIbuDjR5sPQliEt6P8/MkJ48kx8SPbk/gXKh4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3OKE/BxIZ7WSQzjtY19eWPnCkLuawSdhzgd3vCwf3DsHhIzrY WfD4FnAayBG+hnmvoXYMxhwLEVz1+vG73jqIxBiwS44qfzlhhPbVdJSf89+fQia4P+H8n/Yr72J E0MnAZUnKqLDwbqC706vAt2qdlZWo4iv/Ey5KDIQXzPeeDTVrOPXQ2B4pGzqizJl7hw== X-Gm-Gg: ATEYQzzdQFvOKIZ2WDqbxeOH9Dp2hx1wGEdDwYOU+8JehkgRA5Xo5nva4RRaiN5nK0F Z+urbkfXghWO3feLqSIobXo/smpQMywdSOnlpabYZAZ6vjiRPL10HBH3pM0I6JD4edUIS9WNSDF SZRaAbY1FjUOGOzcczcRFlSLbKlGr79fvXaIjUScOIGGHeFbzySffMS2r/yMN/3Ja17XvYKGe8l 9xiipiG3csUai2czTFUSQVoO3i+OcPI/HXdWvUv5YI4iqhaQvIcc7BNUVtKs3hldGTpoqby4Zcr yXZ+Sjo2VpOkMbSk4YDkNqy71Fv1d65zqV0mDHZE5I6MZ/Y30Q/zpvEigEN1wamKXK5mIZDBzCq xxw/KfAEQbXIPHy1pO17d2bJ3pfbGVoclrCqbkZZhSAE/2uWYk0ZKt8M= X-Received: by 2002:a05:6000:2dc5:b0:439:be78:e1e9 with SMTP id ffacd0b85a97d-439f81c0248mr11988494f8f.14.1773317732155; Thu, 12 Mar 2026 05:15:32 -0700 (PDT) X-Received: by 2002:a05:6000:2dc5:b0:439:be78:e1e9 with SMTP id ffacd0b85a97d-439f81c0248mr11988421f8f.14.1773317731647; Thu, 12 Mar 2026 05:15:31 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1a737csm7076461f8f.10.2026.03.12.05.15.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 05:15:31 -0700 (PDT) Message-ID: <606d9633-d48e-49ff-81c8-cbed7e92f698@redhat.com> Date: Thu, 12 Mar 2026 13:15:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 net-next 11/11] net/nebula-matrix: add common dev start/stop operation To: "illusion.wang" , dimon.zhao@nebula-matrix.com, alvin.wang@nebula-matrix.com, sam.chen@nebula-matrix.com, netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, corbet@lwn.net, kuba@kernel.org, linux-doc@vger.kernel.org, lorenzo@kernel.org, horms@kernel.org, vadim.fedorenko@linux.dev, lukas.bulwahn@redhat.com, edumazet@google.com, open list References: <20260310120959.22015-1-illusion.wang@nebula-matrix.com> <20260310120959.22015-12-illusion.wang@nebula-matrix.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260310120959.22015-12-illusion.wang@nebula-matrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/10/26 1:09 PM, illusion.wang wrote: > +static int nbl_dev_configure_msix_map(struct nbl_dev_mgt *dev_mgt) > +{ > + struct nbl_dispatch_ops *disp_ops = dev_mgt->disp_ops_tbl->ops; > + struct nbl_dev_common *dev_common = dev_mgt->common_dev; > + struct nbl_msix_info *msix_info = &dev_common->msix_info; > + bool mask_en = msix_info->serv_info[NBL_MSIX_NET_TYPE].hw_self_mask_en; > + u16 msix_net_num = msix_info->serv_info[NBL_MSIX_NET_TYPE].num; > + u16 msix_not_net_num = 0; > + int err, i; > + > + for (i = NBL_MSIX_NET_TYPE; i < NBL_MSIX_TYPE_MAX; i++) > + msix_info->serv_info[i].base_vector_id = > + msix_info->serv_info[i - 1].base_vector_id + > + msix_info->serv_info[i - 1].num; > + > + for (i = NBL_MSIX_MAILBOX_TYPE; i < NBL_MSIX_TYPE_MAX; i++) { > + if (i == NBL_MSIX_NET_TYPE) > + continue; > + > + msix_not_net_num += msix_info->serv_info[i].num; > + } AI review says: Is the condition `if (i == NBL_MSIX_NET_TYPE) continue;` correct here? Looking at the enum in nbl_dev.h: enum nbl_msix_type { NBL_MSIX_VIRTIO_TYPE = 0, NBL_MSIX_NET_TYPE = 1, NBL_MSIX_MAILBOX_TYPE = 2, NBL_MSIX_TYPE_MAX = 3, }; The loop starts at NBL_MSIX_MAILBOX_TYPE (value 2) and continues to NBL_MSIX_TYPE_MAX (value 3). Since the variable i never equals 1 (NBL_MSIX_NET_TYPE), this branch can never execute. Should this dead code be removed, or should the loop start at a different value if the intent was to skip NBL_MSIX_NET_TYPE?