From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964874AbdEON0Y (ORCPT ); Mon, 15 May 2017 09:26:24 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56070 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933582AbdEON0W (ORCPT ); Mon, 15 May 2017 09:26:22 -0400 Subject: Re: [PATCH v4 3/3] hwmon: (adt7475) add high frequency support To: Chris Packham , linux-hwmon@vger.kernel.org, jdelvare@suse.com References: <20170515013029.31397-1-chris.packham@alliedtelesis.co.nz> <20170515013029.31397-4-chris.packham@alliedtelesis.co.nz> Cc: linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <606da904-b6ab-f9fd-45e5-e60632eafc72@roeck-us.net> Date: Mon, 15 May 2017 06:26:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170515013029.31397-4-chris.packham@alliedtelesis.co.nz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/14/2017 06:30 PM, Chris Packham wrote: > Systems using 4-wire fans usually require high frequency (22.5kHz) > output on the pwm. Add 22500 as a valid option in the pwmfreq_table. In > high frequency mode the low-order bit are ignored so they can safely be > set to 0. > > Signed-off-by: Chris Packham Applied to hwmon-next. Thanks, Guenter > --- > Changes in v3: > - New > Changes in v4: > - Fix pwmfreq_table array indexing > > drivers/hwmon/adt7475.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c > index 3056076fae27..1baa213a60bd 100644 > --- a/drivers/hwmon/adt7475.c > +++ b/drivers/hwmon/adt7475.c > @@ -934,7 +934,7 @@ static ssize_t set_pwmctrl(struct device *dev, struct device_attribute *attr, > > /* List of frequencies for the PWM */ > static const int pwmfreq_table[] = { > - 11, 14, 22, 29, 35, 44, 58, 88 > + 11, 14, 22, 29, 35, 44, 58, 88, 22500 > }; > > static ssize_t show_pwmfreq(struct device *dev, struct device_attribute *attr, > @@ -942,9 +942,10 @@ static ssize_t show_pwmfreq(struct device *dev, struct device_attribute *attr, > { > struct adt7475_data *data = adt7475_update_device(dev); > struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr); > + int i = clamp_val(data->range[sattr->index] & 0xf, 0, > + ARRAY_SIZE(pwmfreq_table) - 1); > > - return sprintf(buf, "%d\n", > - pwmfreq_table[data->range[sattr->index] & 7]); > + return sprintf(buf, "%d\n", pwmfreq_table[i]); > } > > static ssize_t set_pwmfreq(struct device *dev, struct device_attribute *attr, > @@ -965,7 +966,7 @@ static ssize_t set_pwmfreq(struct device *dev, struct device_attribute *attr, > > data->range[sattr->index] = > adt7475_read(TEMP_TRANGE_REG(sattr->index)); > - data->range[sattr->index] &= ~7; > + data->range[sattr->index] &= ~0xf; > data->range[sattr->index] |= out; > > i2c_smbus_write_byte_data(client, TEMP_TRANGE_REG(sattr->index), >