From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3395C2E92D1 for ; Wed, 29 Oct 2025 02:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761703369; cv=none; b=nXFbD9WufGYYM5HWuFMbkpAzez+IQMANRtMKxG8O4WUMP8A/H4OoB1OtUs7BLBfqHfJGf/LiF6iETO6pUwy+r8zJzqNMt9SFBNecc7gOhMnjVeiqFQG8ZLx0TEBce0sdUEbwuMvimgzQ8qNi6H4ef2mW70xkk8tahlSo/6bqQqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761703369; c=relaxed/simple; bh=Pz7NzoD2T5f8kPsfdEb9COLkFyV5JhRt5+fFgrda5KU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FLJlBliI96xNBnQqGqNgGoat8B10e9MeWYZimMCOcY7nrddnsv1PWNyQI4MXXWt/5Qd43VB1723LUvwxFcTtOVGLcWiiuxshVJnUQ7agk7Dep6m+DvwC94Ik4kMlDD48B+slqtboD+J4O3BD1L37LcRbziSRtRPFhANQESmQonY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=moCLACVv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WBgMfq1x; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="moCLACVv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WBgMfq1x" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59SJm3mH2554005 for ; Wed, 29 Oct 2025 02:02:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +XHD3qAsYq7bk8sAiSss2ZM7l6bFmO2byTwWLdGl1uY=; b=moCLACVvtXJYioCm xM4rt6KPH9Mqtg0ZB5RMJqSan/DxiWnPwMHrqaD7A8XhwR2HdSusHkSpJECCUGSN J/gP3Chb8gOvReqNfc8JObnuRGpw0R7jXjVV95nN2YLwQW9xIWeMXV2AT6oczXzp x9SXOWec7dmmsinlgjlkXSr1aR0SjZo8M3q2+7iokPSCYYZ/azq1UkZMf8zcncGU FtK+N95fE6dytdHwaaRGIFugzaTLxedY1w3WEBMAI+/pz/io+/g74rqQhf7/+8sE PuuAEGE6EDUCPBFkJ2dTi3e1XMEP7xucQvMQBwg7cBPNJmqThLPH5ZdKJf6+hW4A /HT0gA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a34a2gtf2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Oct 2025 02:02:45 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3304def7909so5137492a91.3 for ; Tue, 28 Oct 2025 19:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761703365; x=1762308165; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+XHD3qAsYq7bk8sAiSss2ZM7l6bFmO2byTwWLdGl1uY=; b=WBgMfq1xHdkkZ08LAuUE5Y6MJtnnHpjlLHUh4ZKKpsvrlfA0wo8qkvWZR4TVtENvBn CYHahkQjz9Jcbav2Gbewla2h6mk9+uXIv1KfE9xE/Y1VgJyMtMhMOibHeWqBRQOKpG4h WBrRKydXXcm39YVxQ5C+vbf0qFhgdpy7xXk6/RD26kYymLvG9ZmKl3VCvqFu5/pSN4vR t6i6xB6Edb4sr/DarSYWHcmmpR0YrymK8kzFxqr2d7e186JMhCTinoaRTIKVtKVaLSAN 2TXLpb1QZtoSOFnUMZBOS4hPFhwF8kxx+K45yrYZqr1S4cZKIQhCXs83DN1OwCYnvjd0 H65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761703365; x=1762308165; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+XHD3qAsYq7bk8sAiSss2ZM7l6bFmO2byTwWLdGl1uY=; b=osZc2PDi+VBmNbdRYoP73IdJnlnaeMqXlswKV/dtjF45gmXRYya9XwfKkM8VbBtz3I ULt8C68BMfp38r6JCWSLWPRvsS3ttQ+KM4K7iU/4i598Gm76yWEZkOMKY/cpM3GyxNC/ wkDv8XbkihBymdmVu4cu/6UCKMOydSHXn2aTWy+dah7TNHmKZgbDKMD2y4NKF7dpaozk yH6smB5EMflrQPh75KKo4ygDVb8Unn+hNTIOCkj3nJW2yHFCAOvRZK8XHqYmb3DtfgeC hTF32VFwbKs0Le233xUxOzXaJF4e+RM0qBp8tuDfPB8WBbHf0yJ94wed/p9nG2eLf0ws h8YQ== X-Forwarded-Encrypted: i=1; AJvYcCUSWH3NUOpQObUeyciprXkVLVrbx4gASIoPKsmmgteOmEcEsBhncFOUi1aQuVZCAHU031TWW5pk/IzhQRI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2H9MUDgc4S9yrq9moW2yVqUNcGBmyDhmmjOxz6MD0+oEABSJW qEdsBhSwwsFuPsx464lZImVraFSPldd70Q4uvtcZO6IVrHDVu2c4NS6SowgHIClPrfWfR1KkkvE WReEUFiWgb8UUbgHNDHUY2TRyaqNe0OIF4gGMzqSfUqdsFeDKijg2WclkcQcpElhkn+0= X-Gm-Gg: ASbGncuOFY0Wr9THn485c5r3GbwiJ1ki7uNWohJc76a84Xkmjj3ZUdkw/OSz0bin7cN XSq6vQpr0iQrB09alVtUrCDeA77pE8RbS5cbOoI4nGt6rL+Ms3HIXA76yycfBqkSm8VM/mTJ3Ag S7KcD69xm9YcqoZdtslqvzlGjhhc/2b/BfzSe1vRazMvkhFjwwwl8p7136FPPkM6HchtsZjJHhk IUTR1vj5v8vzT3BF0i6dQaZNLFVzYDYxzr25hpOLhi3SNSBYHGM0km8EK10175JNHcpnvFXysaS YZU07lAj7in7OjdMdXWOrX4Rpxm8PJyecst0raApz031JcVRD4Vb7YM2iAG8tZRaiRWQFnBOGkv YgEv97f00aNIf8Q2jaYWsZ1gYN6mT4Y7kvp9s1Sopsvcv4PqN0ubKbQ0qfFGp X-Received: by 2002:a17:90b:5285:b0:32d:e75a:5009 with SMTP id 98e67ed59e1d1-3403a15d171mr1330239a91.1.1761703364840; Tue, 28 Oct 2025 19:02:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGcScMXLm268C0Dm3zeV/yJI6TOPZWieAH/ad6aJnRDTo8npsq612B2XwRMppYY/qaERJ3iA== X-Received: by 2002:a17:90b:5285:b0:32d:e75a:5009 with SMTP id 98e67ed59e1d1-3403a15d171mr1330204a91.1.1761703364290; Tue, 28 Oct 2025 19:02:44 -0700 (PDT) Received: from [10.133.33.233] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a41408757csm13100312b3a.59.2025.10.28.19.02.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 19:02:44 -0700 (PDT) Message-ID: <606e4570-46ad-454d-a018-3bf2dd582dc2@oss.qualcomm.com> Date: Wed, 29 Oct 2025 10:02:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix potential memory leak in ath12k_wow_arp_ns_offload() To: Abdun Nihaal , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251028170457.134608-1-nihaal@cse.iitm.ac.in> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20251028170457.134608-1-nihaal@cse.iitm.ac.in> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 24NxUrAygeljxJlxLmyAd-7zLeUJrlmg X-Proofpoint-ORIG-GUID: 24NxUrAygeljxJlxLmyAd-7zLeUJrlmg X-Authority-Analysis: v=2.4 cv=PcvyRyhd c=1 sm=1 tr=0 ts=690175c5 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=QpG1ZDNR6MNC-5z7ugsA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI5MDAxNCBTYWx0ZWRfX4qFFkDbjs7FP 6jzHK5F2DDZ8OWfqK1wnBau+KmXLsemugimmDjSc2XXt6qt6ba4pk+UPk5z9Lagyn2QYmXd0210 UHqbyeBqp1/5N+Q5DBZZixH3MdVOw89ep5+kUQxCYNouaJz6raYQYpRinzKuRohWKvmIYzl9LAa U6Ea9afcoY/9WJf3U+4j/V3YWAvHbctQpKzZdC9FGIOrBnOq2fTrHudcx2g1u8tiI9uqvAjCagz T1eE2idnQBjlWw+XmBV1nN1uf4J99cvzLwU/hTxzmBQ7WnkO8z00BdUfRZjo06YzE66ar3GRcyF +T++hLPWj8RN+HH2W0FaGkOnvR8j9WXM38t+pgymO8AaNp1dvvqLh65Ik2bCxjeje8WhGwcCijK BK7gTcSIMLzMeWIGv+7WzaSUDXy1TQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-29_01,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510290014 On 10/29/2025 1:04 AM, Abdun Nihaal wrote: > When the call to ath12k_wmi_arp_ns_offload() fails, the temporary memory > allocation for offload is not freed before returning. Fix that by > freeing offload in the error path. > > Fixes: 1666108c74c4 ("wifi: ath12k: support ARP and NS offload") > Signed-off-by: Abdun Nihaal > --- > Compile tested only. Issue found using static analysis. > > drivers/net/wireless/ath/ath12k/wow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath12k/wow.c b/drivers/net/wireless/ath/ath12k/wow.c > index dce9bd0bcaef..e8481626f194 100644 > --- a/drivers/net/wireless/ath/ath12k/wow.c > +++ b/drivers/net/wireless/ath/ath12k/wow.c > @@ -758,6 +758,7 @@ static int ath12k_wow_arp_ns_offload(struct ath12k *ar, bool enable) > if (ret) { > ath12k_warn(ar->ab, "failed to set arp ns offload vdev %i: enable %d, ret %d\n", > arvif->vdev_id, enable, ret); > + kfree(offload); > return ret; > } > } Reviewed-by: Baochen Qiang