From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933036AbcCJXdK (ORCPT ); Thu, 10 Mar 2016 18:33:10 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:46153 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932313AbcCJXdH (ORCPT ); Thu, 10 Mar 2016 18:33:07 -0500 From: "Rafael J. Wysocki" To: Colin King Cc: "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / utils: remove redundant check if element is NULL Date: Fri, 11 Mar 2016 00:34:56 +0100 Message-ID: <6080101.Xh3F3pdZMM@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1456691509-7855-1-git-send-email-colin.king@canonical.com> References: <1456691509-7855-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, February 28, 2016 08:31:49 PM Colin King wrote: > From: Colin Ian King > > element is &package->package.elements[i] which can never be NULL > so the check to see if it is NULL is redundant and can be removed. > > Detected with static analysis by CoverityScan > > Signed-off-by: Colin Ian King Applied, thanks! Rafael