From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D75BC282DD for ; Wed, 8 Jan 2020 13:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E70420705 for ; Wed, 8 Jan 2020 13:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727532AbgAHN70 (ORCPT ); Wed, 8 Jan 2020 08:59:26 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:9135 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726699AbgAHN70 (ORCPT ); Wed, 8 Jan 2020 08:59:26 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CDE15511EA4AE1C5E960; Wed, 8 Jan 2020 21:59:23 +0800 (CST) Received: from [127.0.0.1] (10.177.131.64) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Wed, 8 Jan 2020 21:59:19 +0800 Subject: Re: [PATCH next] drm/i915/gtt: add missing include file asm/smp.h To: Jani Nikula , , References: <20200108133610.92714-1-chenzhou10@huawei.com> <877e22qczw.fsf@intel.com> CC: , , From: Chen Zhou Message-ID: <6081a507-c11a-749e-df6a-c59649ee5d65@huawei.com> Date: Wed, 8 Jan 2020 21:59:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <877e22qczw.fsf@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.131.64] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/1/8 21:44, Jani Nikula wrote: > On Wed, 08 Jan 2020, Chen Zhou wrote: >> Fix build error: >> lib/crypto/chacha.c: In function chacha_permute: >> lib/crypto/chacha.c:65:1: warning: the frame size of 3384 bytes is larger than 2048 bytes [-Wframe-larger-than=] >> } >> ^ > > IMO this needs a better explanation of why not having the include leads > to the above failure. > > BR, > Jani. > Sorry, i made a mistake. The error is as follows: drivers/gpu/drm/i915/gt/intel_ggtt.c: In function ggtt_restore_mappings: drivers/gpu/drm/i915/gt/intel_ggtt.c:1239:3: error: implicit declaration of function wbinvd_on_all_cpus; did you mean wrmsr_on_cpus? [-Werror=implicit-function-declaration] wbinvd_on_all_cpus(); ^~~~~~~~~~~~~~~~~~ wrmsr_on_cpus Thanks, Chen Zhou >> >> Reported-by: Hulk Robot >> Signed-off-by: Chen Zhou >> --- >> drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c >> index 1a2b5dc..9ef8ed8 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c >> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c >> @@ -6,6 +6,7 @@ >> #include >> >> #include >> +#include >> >> #include "intel_gt.h" >> #include "i915_drv.h" >