From: Pu Lehui <pulehui@huawei.com>
To: Chen Pei <cp0613@linux.alibaba.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>, <memxor@gmail.com>,
<bjorn@kernel.org>, <puranjay@kernel.org>
Cc: <ihor.solodrai@linux.dev>, <eddyz87@gmail.com>,
<martin.lau@linux.dev>, <song@kernel.org>,
<yonghong.song@linux.dev>, <jolsa@kernel.org>,
<emil@etsalapatis.com>, <pjw@kernel.org>, <palmer@dabbelt.com>,
<shuah@kernel.org>, <guoren@kernel.org>, <bpf@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v3 0/4] bpf, riscv: Add support for indirect jumps
Date: Mon, 28 Sep 2026 17:10:17 +0800 [thread overview]
Message-ID: <6081a548-aaed-423a-bb34-0008cedc6699@huawei.com> (raw)
In-Reply-To: <20260928071845.2432-1-cp0613@linux.alibaba.com>
On 2026/9/28 15:18, Chen Pei wrote:
> The indirect jump instruction (BPF_JMP | BPF_JA | BPF_X, "gotox") and the
> BPF_MAP_TYPE_INSN_ARRAY jump tables it consumes are core features: the
> verifier accepts them on every architecture, and the x86-64, arm64 and
> powerpc JITs implement them. On riscv64 a program using gotox passes
> verification and then fails to load, because the JIT does not know the
> opcode and CONFIG_BPF_JIT_ALWAYS_ON leaves no interpreter to fall back
> onto.
>
> This series adds the riscv64 support and turns the existing selftests on
> for that architecture.
>
> Patch 1 emits "jalr zero, rd, 0" for gotox and publishes the xlated to
> jitted offsets through bpf_prog_update_insn_ptrs(), which is what fills
> in the jump table addresses. Patches 2 to 4 widen the arch guards in
> verifier_gotox.c, compute_live_registers.c and bpf_insn_array.c to
> riscv64, the same way the other architectures were enabled.
>
> Changes since v2:
> - Pick up Pu Lehui's Reviewed-by on patch 1.
> - Enable two more gotox test files for riscv64: compute_live_registers.c
> and bpf_insn_array.c.
>
> Changes since v1:
> - Rebased onto bpf-next.
> - Patch 1: reword the code comment to say "shift ctx->offset[] by one".
> - Patch 2: collapse the multi-line #endif marker to a single line.
> - Added Reviewed-by/Acked-by from Björn Töpel.
>
> Testing
> =======
>
> Environment: QEMU virt rv64, with CONFIG_BPF_JIT=y,
> CONFIG_BPF_JIT_ALWAYS_ON=y, CONFIG_DEBUG_INFO_BTF=y; selftests
> cross-built with clang 23.
>
> - test_progs -t verifier_gotox: 33/33 subtests pass.
> - test_progs -t bpf_insn_array: 20/20 subtests pass.
> - test_progs -t compute_live_registers: 20/20 subtests pass, including
> the gotox liveness subtest.
> - test_progs-cpuv4 -t bpf_gotox: 14/14 subtests pass.
>
> Chen Pei (4):
> bpf, riscv: Add support for indirect jumps
> selftests/bpf: Enable gotox tests for riscv64
> selftests/bpf: Enable gotox liveness test for riscv64
> selftests/bpf: Enable instruction array test for riscv64
>
> arch/riscv/net/bpf_jit_comp64.c | 5 +++++
> arch/riscv/net/bpf_jit_core.c | 16 ++++++++++++++--
> .../selftests/bpf/prog_tests/bpf_insn_array.c | 3 ++-
> .../selftests/bpf/progs/compute_live_registers.c | 5 +++--
> .../testing/selftests/bpf/progs/verifier_gotox.c | 6 ++++--
> 5 files changed, 28 insertions(+), 7 deletions(-)
>
For this series:
Tested-by: Pu Lehui <pulehui@huawei.com>
prev parent reply other threads:[~2026-09-28 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 7:18 Chen Pei
2026-09-28 7:18 ` [PATCH bpf-next v3 1/4] " Chen Pei
2026-09-28 7:18 ` [PATCH bpf-next v3 2/4] selftests/bpf: Enable gotox tests for riscv64 Chen Pei
2026-09-28 7:18 ` [PATCH bpf-next v3 3/4] selftests/bpf: Enable gotox liveness test " Chen Pei
2026-09-28 7:18 ` [PATCH bpf-next v3 4/4] selftests/bpf: Enable instruction array " Chen Pei
2026-09-28 9:10 ` Pu Lehui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6081a548-aaed-423a-bb34-0008cedc6699@huawei.com \
--to=pulehui@huawei.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cp0613@linux.alibaba.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=guoren@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=puranjay@kernel.org \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®