From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: matthew.gerlach@linux.intel.com, dinguyen@kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Date: Wed, 4 May 2022 17:02:50 +0200 [thread overview]
Message-ID: <608ba746-9116-3f36-d640-07eb8b5d793e@linaro.org> (raw)
In-Reply-To: <20220503194546.1287679-4-matthew.gerlach@linux.intel.com>
On 03/05/2022 21:45, matthew.gerlach@linux.intel.com wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Add a device tree for the n6000 instantiation of Agilex
> Hard Processor System (HPS).
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> +
> + soc {
> + agilex_hps_bridges: bus@80000000 {
> + compatible = "simple-bus";
> + reg = <0x80000000 0x60000000>,
> + <0xf9000000 0x00100000>;
> + reg-names = "axi_h2f", "axi_h2f_lw";
> + #address-cells = <0x2>;
> + #size-cells = <0x1>;
> + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;
> +
> + hps_cp_eng@0 {
No underscores in node names. dtc W=1 should complain about it.
The node name should be generic, matching class of a device. What is
this exactly?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-04 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 19:45 [PATCH v2 0/3] Add device tree for Intel n6000 matthew.gerlach
2022-05-03 19:45 ` [PATCH v2 1/3] dt-bindings: misc: add bindings for Intel HPS Copy Engine matthew.gerlach
2022-05-04 15:04 ` Krzysztof Kozlowski
2022-05-04 22:41 ` matthew.gerlach
2022-05-05 8:18 ` Krzysztof Kozlowski
2022-05-05 17:18 ` matthew.gerlach
2022-05-03 19:45 ` [PATCH v2 2/3] dt-bindings: intel: add binding for Intel n6000 matthew.gerlach
2022-05-04 14:54 ` Krzysztof Kozlowski
2022-05-04 21:09 ` matthew.gerlach
2022-05-03 19:45 ` [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000 matthew.gerlach
2022-05-04 14:56 ` Krzysztof Kozlowski
2022-05-04 21:14 ` matthew.gerlach
2022-05-04 15:02 ` Krzysztof Kozlowski [this message]
2022-05-04 21:22 ` matthew.gerlach
2022-05-05 6:42 ` Krzysztof Kozlowski
2022-05-05 17:16 ` matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608ba746-9116-3f36-d640-07eb8b5d793e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®