From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936981AbdLSBVe (ORCPT ); Mon, 18 Dec 2017 20:21:34 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43233 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935396AbdLSBVb (ORCPT ); Mon, 18 Dec 2017 20:21:31 -0500 X-Google-Smtp-Source: ACJfBovjX6Ahl7TW72U73j47UTg1XniLLXO89bew9E9ONjFXJfK64PJFgP6SO9+jjsGf4/BBmxzILA== Subject: Re: [PATCH] [v2] ARM: B15: fix unused label warnings To: Arnd Bergmann , Brian Norris , Gregory Fong , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20171218165307.1472231-1-arnd@arndb.de> From: Florian Fainelli Message-ID: <608efeca-c913-5f38-565f-9f792b51fae3@gmail.com> Date: Mon, 18 Dec 2017 17:21:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171218165307.1472231-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/2017 08:52 AM, Arnd Bergmann wrote: > The new conditionally compiled code leaves some labels and one > variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP > are disabled: > > arch/arm/mm/cache-b15-rac.c: In function 'b15_rac_init': > arch/arm/mm/cache-b15-rac.c:353:1: error: label 'out_unmap' defined but not used [-Werror=unused-label] > out_unmap: > ^~~~~~~~~ > arch/arm/mm/cache-b15-rac.c:351:1: error: label 'out_cpu_dead' defined but not used [-Werror=unused-label] > out_cpu_dead: > ^~~~~~~~~~~~ > At top level: > arch/arm/mm/cache-b15-rac.c:53:12: error: 'rac_config0_reg' defined but not used [-Werror=unused-variable] > > This replaces the existing #ifdef conditionals with IS_ENABLED() > checks that let the compiler figure out for itself which code to > drop. > > Fixes: 55de88778f4b ("ARM: 8726/1: B15: Add CPU hotplug awareness") > Signed-off-by: Arnd Bergmann Acked-by: Florian Fainelli Thanks Arnd! -- Florian