From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans@jjverkuil.nl>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com,
linux-media@vger.kernel.org,
Sebastian Fricke <sebastian.fricke@collabora.com>
Subject: Re: [PATCH v3 1/5] media: mc: add manual request completion
Date: Thu, 05 Jun 2025 08:41:45 -0400 [thread overview]
Message-ID: <608f95249ff3a39efb063ab9c6a543259a7b0ac9.camel@collabora.com> (raw)
In-Reply-To: <aEFoCvPe4zE48UG7@kekkonen.localdomain>
Hi Hans, Sakari,
Le jeudi 05 juin 2025 à 09:48 +0000, Sakari Ailus a écrit :
> > It's not user-triggerable, if this happens, then it is a driver bug.
>
> If there is a driver bug, it could well be user-triggerable, wouldn't it?
> Testing may not uncover all such cases.
You are both right, if the driver is not used, the warning will never
trigger. I was worried of the hit of a thread safe ONCE implementation,
but WARN_ONCE is simply not, it can warn few time before it stops if
called from multiple CPUs at the same time. In that specific function,
I can move all the checks inside the lock to make it truly once.
Now its up to you, I don't have strong preference. These are driver errors,
and usually quite critical. They are not bug_on simply because we have a
crash free resolution, but its probably not functional anymore.
Nicolas
next prev parent reply other threads:[~2025-06-05 12:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 20:09 [PATCH v3 0/5] Add manual request completion to the MediaTek VCodec driver Nicolas Dufresne
2025-06-04 20:09 ` [PATCH v3 1/5] media: mc: add manual request completion Nicolas Dufresne
2025-06-04 21:04 ` Sakari Ailus
2025-06-04 23:19 ` Nicolas Dufresne
2025-06-05 6:51 ` Sakari Ailus
2025-06-05 9:37 ` Hans Verkuil
2025-06-05 9:48 ` Sakari Ailus
2025-06-05 12:41 ` Nicolas Dufresne [this message]
2025-06-09 9:42 ` Sakari Ailus
2025-06-09 9:49 ` Hans Verkuil
2025-06-04 20:09 ` [PATCH v3 2/5] media: vicodec: add support for manual completion Nicolas Dufresne
2025-06-04 20:09 ` [PATCH v3 3/5] media: mc: add debugfs node to keep track of requests Nicolas Dufresne
2025-06-04 21:33 ` Sakari Ailus
2025-06-04 23:08 ` Nicolas Dufresne
2025-06-09 10:28 ` Sakari Ailus
2025-06-09 10:46 ` Hans Verkuil
2025-06-04 20:09 ` [PATCH v3 4/5] media: vcodec: Implement manual request completion Nicolas Dufresne
2025-06-11 8:33 ` AngeloGioacchino Del Regno
2025-11-21 21:07 ` Nicolas Dufresne
2025-06-04 20:09 ` [PATCH v3 5/5] media: mtk-vcodec: Don't try to decode 422/444 VP9 Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608f95249ff3a39efb063ab9c6a543259a7b0ac9.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=hans@jjverkuil.nl \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sebastian.fricke@collabora.com \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®