From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44E4C433EF for ; Tue, 19 Apr 2022 09:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241458AbiDSJPq (ORCPT ); Tue, 19 Apr 2022 05:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231799AbiDSJPp (ORCPT ); Tue, 19 Apr 2022 05:15:45 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A1620BD9 for ; Tue, 19 Apr 2022 02:13:01 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 21so20465277edv.1 for ; Tue, 19 Apr 2022 02:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=rgi3jG3IzfFk/97rZZxdzXA8E6nwdIahpnGwkXRZ4y4=; b=R1TcrZ2RTC5pmzPgZI7aB8wTgTWhEWpZOOjfnnq7xYjPdQaybMCKhSvV5dDA8DI5h3 rr0PlQR8qMWMMK1DRZ95cbEnBdxJjgkZUv0msmH2BKLYGc6w2r0NeM3jBKfdp52S9nCl A4rU1+4LhycdRF8KHn2KiqaczAUjM1Ptz3X9YqcG0lq5EHIs3NQDJqgaCRAHkHuzcV6U Tt43ayianfVHmEa5yFDIHrPCbHO20Ol3lC8XNBFWRQRQrpqUgJduL1mTS63tkg01Hqhf BiA3wPAJ3Bs6kVfPFDhz41/97+K9gufsiAAPXsxvsVSzQWK21dO3wtQ1aK/X3S1d9Etu LA1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rgi3jG3IzfFk/97rZZxdzXA8E6nwdIahpnGwkXRZ4y4=; b=NXhPt6PUnNP7PA8Jx74s47CP9nvP5RGepk/DNJNrwLbRMWXVJxGHLD2IOwouwkf7/Q CGS+TvIqE8m+mjLL7xlmrFLu73RCSB9wPvCTSFvTOwFvE9QPbokXuGQTl9pPXFeKg85Q N9zyHrUul+xXP4fjgHTRQyngEwDINBMN+UbdMenDOW1IP9+cSaJKaIxwxS61r8tTxZFy 7Ag6cJon00cKs0/WVkwte6XW3ETWrlfz7U7su8Fttzyy5kyWg78ZBPbjoMq+XShi+4ZW SmfGZnbhrwQ/HeQ9YlfSovMvDO/katRra1ROncM12YwwSuiujZxDbVy9eQpl8ZRwdfrl GaWQ== X-Gm-Message-State: AOAM530A93TVMSZik9f8fsRwk1w4xVnoSjbMrIHuPSHRjDtXjX7L1j0d Im0H6v5tgsIxw6ccpn8QBntJmA== X-Google-Smtp-Source: ABdhPJyuIVtA+uctlp9lLBFQpEOpgNfJfDW1L9ykM3qXhzLTfUxYzGOiHkJ2xPJAhqiqol9vRmoCgQ== X-Received: by 2002:aa7:dc49:0:b0:41d:72e2:d34e with SMTP id g9-20020aa7dc49000000b0041d72e2d34emr16100008edu.385.1650359580300; Tue, 19 Apr 2022 02:13:00 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id bm6-20020a170906c04600b006e89a5f5b8fsm5498890ejb.153.2022.04.19.02.12.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 02:12:59 -0700 (PDT) Message-ID: <60955707-aabc-5313-aeb9-d65453538de0@linaro.org> Date: Tue, 19 Apr 2022 11:12:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] extcon: ptn5150: add usb role class support Content-Language: en-US To: Jun Li Cc: "myungjoo.ham@samsung.com" , "cw00.choi@samsung.com" , "linux-kernel@vger.kernel.org" , Frank Li , Xu Yang References: <1649238142-27564-1-git-send-email-jun.li@nxp.com> <4ad9e733-7d8b-a73b-c59e-d9b6d5e58498@linaro.org> <3dafc432-849b-0a78-f3dd-954d88c74a61@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2022 10:51, Jun Li wrote: > My test config is making USB_ROLE_SWITCH=m, but PTN5150=y > > So with below header file: > > #if IS_ENABLED(CONFIG_USB_ROLE_SWITCH) > void usb_role_switch_put(struct usb_role_switch *sw); > #else > static inline void usb_role_switch_put(struct usb_role_switch *sw) { } > #endif > > Will have link error. Yep, true. I cannot remember the solution for that... With the select you cannot disable USB_ROLE_SWITCH. With "depends on X || depends on !X", one still cannot disable USB_ROLE_SWITCH. However this is a common problem and I am pretty sure people were working on this. :) Best regards, Krzysztof