From: "Bjorn Helgaas" <bjorn.helgaas@hp.com>
To: "Kristen Accardi" <kristen.c.accardi@intel.com>
Cc: "Greg KH" <greg@kroah.com>,
"Bjorn Helgaas" <bjorn.helgaas@hp.com>,
acpi-devel@lists.sourceforge.net,
pcihpd-discuss@lists.sourceforge.net,
linux-kernel@vger.kernel.org, "Shah,
Rajesh" <rajesh.shah@intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: Re: [ACPI] Re: [Pcihpd-discuss] RE: [patch 2/2] acpi: add ability to derive irq when doing a surpriseremoval of an adapter
Date: Fri, 21 Oct 2005 21:14:12 -0600 (MDT) [thread overview]
Message-ID: <60987.24.9.204.52.1129950852.squirrel@mail.atl.hp.com> (raw)
In-Reply-To: <1129930114.5932.6.camel@whizzy>
> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
> +
> + /*
> + * If a device has been "surprise" removed via
> + * hotplug, the pin value will be invalid
> + * In this case, we should use the stored
> + * pin value from the pci_dev structure
> + */
> + if (pin == 0xff)
> + pin = dev->pin;
I think you should just always use dev->pin, and don't even
bother trying the pci_read_config_byte(). Fewer code paths
to worry about that way.
Bjorn
next prev parent reply other threads:[~2005-10-22 3:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-08 0:56 Li, Shaohua
2005-10-10 17:48 ` Kristen Accardi
2005-10-11 17:54 ` Kristen Accardi
2005-10-18 23:57 ` [Pcihpd-discuss] " Kristen Accardi
2005-10-19 15:29 ` [ACPI] " Bjorn Helgaas
2005-10-19 16:51 ` Kristen Accardi
2005-10-19 16:59 ` Greg KH
2005-10-21 21:28 ` Kristen Accardi
2005-10-22 3:14 ` Bjorn Helgaas [this message]
2005-10-19 17:06 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60987.24.9.204.52.1129950852.squirrel@mail.atl.hp.com \
--to=bjorn.helgaas@hp.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=rajesh.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®