From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759680AbcINDBw (ORCPT ); Tue, 13 Sep 2016 23:01:52 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36395 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757610AbcINDA0 (ORCPT ); Tue, 13 Sep 2016 23:00:26 -0400 From: Peng Sun To: liodot@gmail.com, charrer@alacritech.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Peng Sun Subject: [PATCH 06/10] staging: slicoss: slicoss.c: fix different address space sparse warning Date: Tue, 13 Sep 2016 19:59:55 -0700 Message-Id: <60988e18e9bd12fb0aae73ef885495c95b5f9eb8.1473821899.git.sironhide0null@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: <73f5aeb587e505b0b81da8a8b86cd130670310e2.1473821899.git.sironhide0null@gmail.com> References: <2fdea4da0036cd13aa0879ffcf86e3303013d52a.1473821899.git.sironhide0null@gmail.com> <2fcefc8b7d4b917dc6dfa32238e47c266428ade0.1473821899.git.sironhide0null@gmail.com> <974f8bea8404695a9440f19b3812300f0ded32b5.1473821899.git.sironhide0null@gmail.com> <62de4cf8ac3f837d2828cbee3b075b9cbe102bcd.1473821899.git.sironhide0null@gmail.com> <73f5aeb587e505b0b81da8a8b86cd130670310e2.1473821899.git.sironhide0null@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Peng Sun --- drivers/staging/slicoss/slicoss.c | 49 +++++++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 929a0d5..03b01c5 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -1004,8 +1004,9 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr) switch (upr->upr_request) { case SLIC_UPR_STATS: { struct slic_shmemory *sm = &adapter->shmem; - struct slic_shmem_data *sm_data = sm->shmem_data; - struct slic_stats *stats = &sm_data->stats; + struct slic_shmem_data __iomem *sm_data = sm->shmem_data; + struct slic_stats __iomem *stats = + IOMEM_GET_FIELDADDR(sm_data, stats); struct slic_stats *old = &adapter->inicstats_prev; struct slicnet_stats *stst = &adapter->slic_stats; @@ -1015,48 +1016,62 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr) break; } - UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs, stats->xmit_tcp_segs, + UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs, + IOMEM_GET_FIELD64(stats, xmit_tcp_segs), old->xmit_tcp_segs); - UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes, stats->xmit_tcp_bytes, + UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes, + IOMEM_GET_FIELD64(stats, xmit_tcp_bytes), old->xmit_tcp_bytes); - UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs, stats->rcv_tcp_segs, + UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs, + IOMEM_GET_FIELD64(stats, rcv_tcp_segs), old->rcv_tcp_segs); - UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes, stats->rcv_tcp_bytes, + UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes, + IOMEM_GET_FIELD64(stats, rcv_tcp_bytes), old->rcv_tcp_bytes); - UPDATE_STATS_GB(stst->iface.xmt_bytes, stats->xmit_bytes, + UPDATE_STATS_GB(stst->iface.xmt_bytes, + IOMEM_GET_FIELD64(stats, xmit_bytes), old->xmit_bytes); - UPDATE_STATS_GB(stst->iface.xmt_ucast, stats->xmit_unicasts, + UPDATE_STATS_GB(stst->iface.xmt_ucast, + IOMEM_GET_FIELD64(stats, xmit_unicasts), old->xmit_unicasts); - UPDATE_STATS_GB(stst->iface.rcv_bytes, stats->rcv_bytes, + UPDATE_STATS_GB(stst->iface.rcv_bytes, + IOMEM_GET_FIELD64(stats, rcv_bytes), old->rcv_bytes); - UPDATE_STATS_GB(stst->iface.rcv_ucast, stats->rcv_unicasts, + UPDATE_STATS_GB(stst->iface.rcv_ucast, + IOMEM_GET_FIELD64(stats, rcv_unicasts), old->rcv_unicasts); - UPDATE_STATS_GB(stst->iface.xmt_errors, stats->xmit_collisions, + UPDATE_STATS_GB(stst->iface.xmt_errors, + IOMEM_GET_FIELD64(stats, xmit_collisions), old->xmit_collisions); UPDATE_STATS_GB(stst->iface.xmt_errors, - stats->xmit_excess_collisions, + IOMEM_GET_FIELD64(stats, + xmit_excess_collisions), old->xmit_excess_collisions); - UPDATE_STATS_GB(stst->iface.xmt_errors, stats->xmit_other_error, + UPDATE_STATS_GB(stst->iface.xmt_errors, + IOMEM_GET_FIELD64(stats, xmit_other_error), old->xmit_other_error); - UPDATE_STATS_GB(stst->iface.rcv_errors, stats->rcv_other_error, + UPDATE_STATS_GB(stst->iface.rcv_errors, + IOMEM_GET_FIELD64(stats, rcv_other_error), old->rcv_other_error); - UPDATE_STATS_GB(stst->iface.rcv_discards, stats->rcv_drops, + UPDATE_STATS_GB(stst->iface.rcv_discards, + IOMEM_GET_FIELD64(stats, rcv_drops), old->rcv_drops); - if (stats->rcv_drops > old->rcv_drops) - adapter->rcv_drops += (stats->rcv_drops - + if (IOMEM_GET_FIELD64(stats, rcv_drops) > old->rcv_drops) + adapter->rcv_drops += + (IOMEM_GET_FIELD64(stats, rcv_drops) - old->rcv_drops); memcpy_fromio(old, stats, sizeof(*stats)); break; -- 2.7.4