From: "Kalra, Ashish" <Ashish.Kalra@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"hch@lst.de" <hch@lst.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"luto@kernel.org" <luto@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"dave.hansen@linux-intel.com" <dave.hansen@linux-intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Singh, Brijesh" <brijesh.singh@amd.com>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"Grimm, Jon" <Jon.Grimm@amd.com>,
"rientjes@google.com" <rientjes@google.com>
Subject: Re: [PATCH v7] swiotlb: Adjust SWIOTBL bounce buffer size for SEV guests.
Date: Mon, 7 Dec 2020 22:20:20 +0000 [thread overview]
Message-ID: <60FF61F4-9A7D-4467-A148-2956903C74AA@amd.com> (raw)
In-Reply-To: <20201207221433.GI20489@zn.tnic>
> On Dec 7, 2020, at 4:14 PM, Borislav Petkov <bp@alien8.de> wrote:
>
> On Mon, Dec 07, 2020 at 10:06:24PM +0000, Ashish Kalra wrote:
>> This is related to the earlier static adjustment of the SWIOTLB buffers
>> as per guest memory size and Konrad's feedback on the same, as copied
>> below :
>>
>>>> That is eating 128MB for 1GB, aka 12% of the guest memory allocated statically for this.
>>>>
>>>> And for guests that are 2GB, that is 12% until it gets to 3GB when
>>>> it is 8% and then 6% at 4GB.
>>>>
>>>> I would prefer this to be based on your memory count, that is 6% of
>>>> total memory.
>
> So no rule of thumb and no measurements? Just a magic number 6.
It is more of an approximation of the earlier static adjustment which was 128M for <1G guests, 256M for 1G-4G guests and 512M for >4G guests.
Thanks,
Ashish
next prev parent reply other threads:[~2020-12-07 22:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:25 Ashish Kalra
2020-12-07 12:10 ` Borislav Petkov
2020-12-07 22:06 ` Ashish Kalra
2020-12-07 22:14 ` Borislav Petkov
2020-12-07 22:20 ` Kalra, Ashish [this message]
2020-12-07 22:33 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60FF61F4-9A7D-4467-A148-2956903C74AA@amd.com \
--to=ashish.kalra@amd.com \
--cc=Jon.Grimm@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux-intel.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®