From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Yang Li <yang.lee@linux.alibaba.com>, broonie@kernel.org
Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] spi: sprd-adi: Use devm_platform_get_and_ioremap_resource()
Date: Mon, 27 Mar 2023 14:46:12 +0800 [thread overview]
Message-ID: <60a08a27-f611-c64c-eec7-27703a08cfa0@linux.alibaba.com> (raw)
In-Reply-To: <20230327060516.93509-1-yang.lee@linux.alibaba.com>
On 3/27/2023 2:05 PM, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/spi/spi-sprd-adi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c
> index 3b158124d79f..22e39c4c12c4 100644
> --- a/drivers/spi/spi-sprd-adi.c
> +++ b/drivers/spi/spi-sprd-adi.c
> @@ -541,8 +541,7 @@ static int sprd_adi_probe(struct platform_device *pdev)
> dev_set_drvdata(&pdev->dev, ctlr);
> sadi = spi_controller_get_devdata(ctlr);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - sadi->base = devm_ioremap_resource(&pdev->dev, res);
> + sadi->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(sadi->base)) {
> ret = PTR_ERR(sadi->base);
> goto put_ctlr;
next prev parent reply other threads:[~2023-03-27 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 6:05 Yang Li
2023-03-27 6:05 ` [PATCH -next 2/2] spi: sprd: " Yang Li
2023-03-27 6:46 ` Baolin Wang
2023-03-27 6:46 ` Baolin Wang [this message]
2023-03-27 17:12 ` [PATCH -next 1/2] spi: sprd-adi: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a08a27-f611-c64c-eec7-27703a08cfa0@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=yang.lee@linux.alibaba.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®