From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031715AbbKFCjd (ORCPT ); Thu, 5 Nov 2015 21:39:33 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:45141 "EHLO ironport2-out.teksavvy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031154AbbKFCjc convert rfc822-to-8bit (ORCPT ); Thu, 5 Nov 2015 21:39:32 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CuBAA731xV/9mBCkxch2DAR4Njg24CgXcSAQEBAQEBAYEKhCMBAQMBI1YQBQYJEQIYDgICPRoGGwmIBA8IqwykFwEBAQcBAQEBAR2BIYoZhFIzB4JogUUBBIwwh16WUxqKCSNhgzWDGAEBAQ X-IPAS-Result: A0CuBAA731xV/9mBCkxch2DAR4Njg24CgXcSAQEBAQEBAYEKhCMBAQMBI1YQBQYJEQIYDgICPRoGGwmIBA8IqwykFwEBAQcBAQEBAR2BIYoZhFIzB4JogUUBBIwwh16WUxqKCSNhgzWDGAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="175618262" Date: Thu, 05 Nov 2015 21:39:26 -0500 To: "Len Brown" Cc: "Len Brown" , "X86 ML" , dparsons@brightdsl.net, "Linux PM list" , linux-kernel@vger.kernel.org From: shrybman Subject: Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000 Message-ID: <60ad3f7df9604e39d9af180f6b56bb69@teksavvy.com> X-Mailer: IceWarp Mailer 11.2.1.1 x64-Desktop In-Reply-To: References: <1444968869-21435-1-git-send-email-lenb@kernel.org> <0bc26e9524533c38fdbdc95eed2b1448@teksavvy.com> X-Priority: 3 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Is this really what you intended? The else is commented out so if init_udelay is quirked > > to be 0 it will always be reset to UDELAY_10MS_DEFAULT. Also init_udelay is unsigned, so > > would UINT_MAX be a better choice? > > Hi Shane, > Thanks for pointing out this flaw. > Seems it will make 4.3 10ms slower than 4.2 on these boxes, by default. > We'll send an incremental patch for 4.4. Sounds good. Thanks Len.