From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52DCC2F872 for ; Mon, 16 Mar 2026 14:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671797; cv=none; b=P9+8Er3X31tzFbuj/DaVUI2hTlfNsrkx/269VgcrwP815doqw/I6LgldwVI/mE8jSrqb47glpppMR/oyumLQf7HpXM86xoP6HIkpVhsmaW5/i61Hxu8clxhC8LIfja2m9KiI0u6+Oh4A15MKcTGlgWCOX3Ulw+Q9y+AlbfU6OEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671797; c=relaxed/simple; bh=iSL82u/rj+K8vkgdtjJJbJQVglewWtRM5osVFtum5DA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lDDsKPBh2dzCp3/HedOc+dqUZ56oUoCbvAH4Vb36opSZTPq4bE8qeBNTheQ5Lm1CVHOHZmAWy3NTOOTSUjlI62twgJz19oQ5/PZ1GT0YfhhZlKUxTSi5sQ/tALMxw3cxl6B/lruwt8FDr1mKMIWy7Dfv7A572li9YqxrgJ+CZqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=mcqcugOw; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="mcqcugOw" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-4042fe53946so1750476fac.3 for ; Mon, 16 Mar 2026 07:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773671794; x=1774276594; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kkfU/ntQc9vQPrm0zeiXFf9WQePuMgZsPXAkNngYEuE=; b=mcqcugOwKDBlR/VIIg85pjq3PsBmlg0TWy96y46KRcQ0lUE69TL9HDZrYozszY24l/ SZJ/cXn4ZqXA55plNYXJEF4kXuBf4qBxXbA/sc4iQLyZnNdLGL/CMOstwu4wCJlaVG20 RMjIEwTdVWh3eFbIRLk18p15LuqMAwH+Mz5cVpSDNlGy1S1EYKEoGUv7B/DyPQEcSdXU /j0tVFh8g9LnkNRuV2b0z1tRyFiS+Zq2a9x9uGYn4vJhca+eBl2NH48RLId3Yq7yk8XZ aWbZ//MoVuq75G5eOqmw8obIOn+YMALuu48n0nO0AbO5fqFOjGaUfp9RonF01k1OsomW odSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773671794; x=1774276594; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kkfU/ntQc9vQPrm0zeiXFf9WQePuMgZsPXAkNngYEuE=; b=Ye0Iz7AoNLgM1zN7UcOz4t5iBE1wCrQx2GIT1KEDfMJSWv11RHU/3077na7kWwQppM joOTdj4koUceyWvG5Cmm/eXMyO02tEU+KcgPPyoHozByYd12PBzpOTo+EksCP/95iKyq G0+9LwoDbNJMlXzRTcunddFsYMGWBB7a84o4rHvkgAKWJXOZslaTtNFIqL/f+kUTQAuv 2SatdfHVXhur+H+Qp9zHtJ2PjRTjJNwEFLuzfnLh9vy3qH9HnwL19+OxsH3UD5r76Kcg syOxB6VP34fd4vC6NaERrVX3QJlwTvFdYw1DzT7qXj+36XempKUceKR7Wd1S3TWjcQ4x eajw== X-Forwarded-Encrypted: i=1; AJvYcCUOPkZsx0q+SeijgXqZ0pIOwwKUjC7h1baFKDKhPoMbItZHl+n3JhnAEOxt3dk2vUDEzDHJ3mzU1ZKufUM=@vger.kernel.org X-Gm-Message-State: AOJu0YyJj15HSqCjUO+Yklp/rydQx12CP1nygJ2BP/F6ksWoc596zmaQ CZAXDZuYTIbHHk12NRiF7BSO4QnprQHI/Nu6rcbCBMoXM3e9l24kb7e9PWPmXckD+5E= X-Gm-Gg: ATEYQzyqqbIBZTHPKYknr7u9AF/+Mk35YCSZ1ABFs0ECd92DWIfkGDH7mD5pimcJgFg UgtACxJHnsOA8wUifx9jQqqCxbjyJnruMcwWBoaLFIcDgHhXP9fen1mrOOjAz9ho8mntTKlayT0 P4JOkO9oE8p/1/IvXU85HSyuCRrFjF9UAap7YAhUNKZAajneT2U0iLih/zm1ex3jPikxfdj15on ms7g62+YJkSMUAmtEZANwh2vSLA8Q1v4MydEkbBCvNZ0S98W9HosBZfZ7WbVCzkOyEXzhrWpySE RkaBdWC+oFZy5pPpZxZ9u8WnmQjs74gDHGNbzDc3LaaEVp9xlzKgi14+BKJmfNX966D6JUHt8Z4 PWQSL51DLQRhA7KELy1JuVGfSl4CkGk2U77QRbF0KMxFtonuJwBlsz6mzZlyw6XjSW/0mivPjuQ hP1DmVYOWyEqrV/skO+wp4RszeVDdjpNTXvn0aNGRQvGDiIoGrCK/JHoXUqgS1Cto6Ktz4m+Cva Q== X-Received: by 2002:a05:6870:a782:b0:417:ab68:fbb1 with SMTP id 586e51a60fabf-417b9059ac3mr7018417fac.10.1773671794159; Mon, 16 Mar 2026 07:36:34 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e504:a034:1152:a664? ([2600:8803:e7e4:500:e504:a034:1152:a664]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e26e2c6sm17149665fac.7.2026.03.16.07.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 07:36:33 -0700 (PDT) Message-ID: <60aea3c6-52db-42a5-b1b5-b0af50e3342b@baylibre.com> Date: Mon, 16 Mar 2026 09:36:33 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: proximity: aw96103: fix firmware read on big-endian To: Andy Shevchenko Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , shuaijie wang , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260314-iio-proximity-aw96103-fix-firmware-read-v1-1-c74fe9ccd82b@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/16/26 5:22 AM, Andy Shevchenko wrote: > On Sat, Mar 14, 2026 at 06:20:12PM -0500, David Lechner wrote: >> Use get_unaligned_le32() instead of casting to int * to make sure that >> reading a 32-bit int value from the firmware binary works correctly on >> big-endian architectures. > > ... > >> bin->valid_data_addr = AW96103_BIN_VALID_DATA_OFFSET; >> bin->valid_data_len = >> - *(unsigned int *)(bin->data + AW96103_BIN_DATA_LEN_OFFSET) - >> + get_unaligned_le32(bin->data + AW96103_BIN_DATA_LEN_OFFSET) - >> AW96103_BIN_DATA_REG_NUM_SIZE; >> memcpy(bin->chip_type, bin->data + AW96103_BIN_CHIP_TYPE_OFFSET, >> AW96103_BIN_CHIP_TYPE_SIZE); > > I gave you a tag, but I have a question here: > Hmm... memcpy() happens to work probably due to keeping LE as LE and chip_type > being a byte stream itself, if AW96103_BIN_CHIP_TYPE_SIZE is bigger than a > byte. Otherwise it may suffer from the same issue, no? > I checked how bin->chip_type is used and it is a string, so not affected.