From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760045AbdEOI2X (ORCPT ); Mon, 15 May 2017 04:28:23 -0400 Received: from mail-db5eur01on0137.outbound.protection.outlook.com ([104.47.2.137]:44352 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759967AbdEOI2U (ORCPT ); Mon, 15 May 2017 04:28:20 -0400 Authentication-Results: lge.com; dkim=none (message not signed) header.d=none;lge.com; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH] mm/kasan: use kasan_zero_pud for p4d table To: , Andrew Morton References: <1494829255-23946-1-git-send-email-iamjoonsoo.kim@lge.com> CC: "Kirill A . Shutemov" , Alexander Potapenko , Dmitry Vyukov , , , , , Joonsoo Kim From: Andrey Ryabinin Message-ID: <60aff3a2-35d5-53f4-65eb-f28d577dab55@virtuozzo.com> Date: Mon, 15 May 2017 11:29:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494829255-23946-1-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0601CA0037.eurprd06.prod.outlook.com (10.166.117.47) To DB5PR0801MB2725.eurprd08.prod.outlook.com (10.166.176.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80708851-deef-452d-606e-08d49b6c52a8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DB5PR0801MB2725; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2725;3:lH+aF9gnsxjTllEKp5LeZnvYEX8mp2oYQpvUlkJS9kOWx5ytteQsGMvZlwuR4EcLxHR4FyoMupSz1jlQ7TWZcweSKt9MlFgXMiOcWxrmcn3UzA16yV5RUdgU3W0LocOnOFKS1m0dAwW5DfulBgqWBLEOmWBpefktKUBqCKndQiN4guh1YowyHATpIuCvrE4x6AtclzSqTGPMtxbb3X5jytIIqNepxG3+mwiftuGNMZsEl+Zl7POU9QEB8REKjEHz7RugU36VjiDReExdUaLuz90pjCTUCGveqPXo+eCVoZeadg1mx1NBDY7wtcfCPVGIILQQihh5LPrypNCC0MPl0A==;25:TLLsdoYJnvZzU6tSfAbul6I3BEISsCpid0lROkHlnBsvHLYj4OqWVX3Nbkcue8xpWjLhHQhGq1XAgNstAQ7UJsTODK/AOuGNhxRQmEVUNSlKOLT6bNYB6eCquAzvgEVbPw99R+2iDLM+A4JmTu5glPglpJb6YSQqqNgirAlM1GBkA3R6XE/dfnTGGjC6kyZ3q4r2l4fhQS/NJ+KOei3CuhD4RX/O0B2Oq0Qc8SyqpUfmvk2l3awAm0xUVrQKErnyxzCsu2PC82droFCfId86Gd6zr0rsOPVnKw4xQw6gsDOKswXeUthOcZ2cfV6uNAisV7qSkbdGTTjbduVLqEIPmkx3SibD5SmG6IzTSbsAxInNqiPtPP9T5ypS7dzlc/E/Hf9jPgB4ot9Ra6AWxV44HXqn1RXdUfNlBSI/BO122Anva4dkoxMzctqn1xya6kT1ouGHYjMPoZOigED2dpI0hQhIdyNOQCT+b9qnZA7chPQ= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2725;31:rs+sAXt7xM/JUf4CR5x/aOiGpehJAaSRUvcyIPKhR6+uuHsjqI90AdvaV9AmT1MwGf+R9HczBE2HSspPn6b6KgfAi1/9pwq+OWPNvDMu3iX6WGlggkVUdRb6S9V9CaSbytMNSIT1tTudNHmZ/iIqd3/L0GsLzNzm41z2OoaMaAC37YLusTo8th4CcWvuwc3rYS57pdHhkJLo54eS/E1BZFNttZmcfjXlcrvw2SeUCJa4vC6PxbMb3eFmSXi2Jqw4+qMDf3MDAqswKdENyMEXmA==;20:6MgpTbn60PXTZhNRUTSxMnQp8XN6yFHDI2fgzUTky90M/tIYjTK3OkGtYjRsufR+3MZ79Pm6NczVr0VP+Uj35NYcBW872xBKy2sl7H1P/eCGSw0K63daPncYQkbV4I9+vIYXnWr7oxnO/KEDJzZORWfKg2Q1em18IUwr/tlnAq/fGIjNqGUajd4BaAP7Lok/V4qOFHBQbmmYyWeS/lsm2lSheAT0zVv54QB0qEYpRTvo3xi2T6IXp4/MAwZfy79JWDSGGZN5PFBtbFGb5jjxwzgNNDPwvkTGvMyNB1V9auu6fMl1GneKEE/g5irKrRHuRO05s0wxWiZBt94Hi3+Yuy8MW9crmHTPbU8NfPBliGppC8MqHOho7pBmfEt89zBbOfXFl+/x1cyPb+kJaspXo6aj3k8yJ1PfMLDXtcr0kmo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148);SRVR:DB5PR0801MB2725;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0801MB2725; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2725;4:T1H38MZe2YgvZxLdCGSEGBnIRvRLughRAvAXD6MvhEA9bsjpv83azh3mIOgWVN2nOVFgQEwfY3yrZ6GIdcGxseXLIEDNUipbQnY4asSblBEe/DW7dewTJQiNHy8/2WpsPrk8B0+3/BoFrOPlNPIVfgkMIZuarXrEiOKSSDb8FSYWHaoZcv7zNMa8PtMnjgs+hgVUWDUW12uUYu80iNg3+9AICzoiasKVCb7HWBz6Ajo0FwgZ3rALtUV2yDxMbFeW3X70I19Abf4BNvnnUwrd0CFidoccOi1SjbUbKTD+/GrE3eZhrFVV6wNRaS+ddo6g5Km/cdYnNKBe/Pc2EzDVtGEq9+TQIal86VnShTt4UUOXuvKa4Z0Oo6yxhlDvzl1NFVgrPszr5oxb61CmqXu6vRelQ/LBGM89dsVBbwQJjk/Cdlu4/NQVyfcrNNT3wd6SmURUFn/GRSh3397E1iRcbTiOLWk/vhy/9ETt7EAyW9E4nnemQLfbNvNmQ3/VgA4t/5J4STUq8H8RdD5TFyRjETO5b0wufryxrZ7dRf1wdOhyVk49AuiBP6weoe3uT3GRWaOpWXdXsOF1oT2w4qNtzEeiQjZ1b43Ph97ZI818zb3JdtCAfhfZRgPKTeABlsyUU2jDCRepZ63nY3ZBPI/WIro/Amp7bsGi7OGmb5HQW6bP2DT5rZVbAPMjyntQwOw1xOf4IJREybt9VCDRRwBFUS7vsDfxjbiSiszyIGYZ+YJLQ8ZW3VdTXSBaqq6bKkby0ZX3uzMp4i6zDoZmIr4ZKCcEPWA/mHTZXEWRFfMvdHA= X-Forefront-PRVS: 0308EE423E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39400400002)(39410400002)(39830400002)(39450400003)(377454003)(24454002)(42186005)(189998001)(229853002)(86362001)(4326008)(50466002)(50986999)(38730400002)(53546009)(25786009)(31696002)(31686004)(54356999)(76176999)(64126003)(36756003)(478600001)(6486002)(90366009)(7416002)(77096006)(23746002)(33646002)(8676002)(81166006)(2906002)(53936002)(5660300001)(305945005)(47776003)(230700001)(6246003)(54906002)(6666003)(2950100002)(66066001)(65806001)(3846002)(6116002)(65956001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR0801MB2725;H:[172.16.25.12];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR0801MB2725;23:S+WDaXDjPX0HMDqelWbRgLFtut6rqY2P9w7?= =?Windows-1252?Q?OmIOb+XAuaT6B279QtBoYzUFBrzuLX8zFtDio+Oh8BQm43p7yKbZuTZl?= =?Windows-1252?Q?7zwMaMEtMLFOnoqoUqTCHrHXMJPbiXEW9Bvc6dyHc/W6PMSy1ox9SUuY?= =?Windows-1252?Q?uk0Zq3QMYnQ4JGr80rE4DelQi3H/t7KXtE+pugbHgjf9x6jNG1hltXbw?= =?Windows-1252?Q?+V37lXz1Qp+q7UT8/Eztn1YNTK/SmKOUHiMTrMR5fQwjG1N492ksnZ9M?= =?Windows-1252?Q?K2jrRq+vqmYIjded+QZp1G0O4QBMUFb8U4FHUHDPHe8mt8OPFO5zrFqh?= =?Windows-1252?Q?iRpV5vDE0uL2vuSBZ4e5xKiy6DSqTLT+7quNjaW0EfCt6ph6QbRAcHNj?= =?Windows-1252?Q?dF4xEFVe6lS6/ukK1W8lLSpJ46qiIzI9ZR+y9tcdBb/QOaI22yiOoIS5?= =?Windows-1252?Q?KMSOYhoUF6MNcq8AeEy6rLvTmLj9e4ZcIeuc/tC26GOOLWWJhbop0dS/?= =?Windows-1252?Q?9yOx2PurISE3kMhHjLC1JNaCHHYnCh379Jw9AOO+73Dss+I4g1IAdv8c?= =?Windows-1252?Q?bqlfJNjHXeQ4aDAVhXaq1o7lTjtsQc6UjXm/ntZnG2FvVMSpBQQpip2d?= =?Windows-1252?Q?TOlXVmSXokM/OvigKEQeo7JqFE5D4+aknyxr0MQoXoJ1PQNCku4Ct+qo?= =?Windows-1252?Q?IrjKLd3eMUD10EcAaGKMQ8v/FO62sPkFKBoroiPOb/AhCReWhbf7apiB?= =?Windows-1252?Q?i5oeTVhw7Sb8MRIMN/oP/4G+yggeQNDeRJc3zlTmFk+FQxAgYqfvImdc?= =?Windows-1252?Q?nIItHsL8syWhYm05mCCTmUZfj39Ou1B/MoHDpqZIqaDMYxFOLxREoOv1?= =?Windows-1252?Q?9JkqwwcPO8z1Oh9q8Su1Bz5YWRnME7Mn9pdQVjdJN3J190yAESCj0oXG?= =?Windows-1252?Q?qPO6nW1LVBvxT3x5vTbgAAt+Dbz5jEFPSF3go4cYDioum6V1hIrpkSD/?= =?Windows-1252?Q?3iNnfnb3h/y9RZhj9lkUaCed2T2kVmm+UYjnqV2IKByZLCKI4+RLT/nI?= =?Windows-1252?Q?4JdziM6Ko0VZ68DH2h7WuxjZttRCOmF27gmYL450ZLgKOangea3QEXJh?= =?Windows-1252?Q?Z62VbpD/dMDjHunHJt1C3BFWZzBNQrJ/+dsXr8pSdlx1UUG4UIkndipF?= =?Windows-1252?Q?sA57K0snR/Cj4y3yorWlAo+BHADMMp2GDnD0LxuVGd04erjdH43RLb10?= =?Windows-1252?Q?66nY36i0rYdOtqkJ19J3AUqJDHr8yBLVnJDIHYPAYEkh8KYJxz6cMHV6?= =?Windows-1252?Q?Cv+mo?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2725;6:767TqVRAUDg0vNmo2Ww0G9RewbV/lK8Ltnd5fHJZ0tca41IyPGkfhwpPbIom9Oxy/IYR+HnOq4HgK3uUEycoY9h8qWuCOCKMp4ytoqWns7gA81/zrEjLCAWYbI6UkOY9rcjEYx+we9CGuS7NUDXCQxVXINEr4wB1epvwB35jBsd++khYGTLnkJlShDmUtRSxdh6Nf7VLjNdnvZYSY/LB0NLSSqB07akw3MsYc/F14RlFO140pGKXGxHf6H2fXeMJrJ+IJe7VpaClCORcv90/ggPXjb1YX4G0SzLRgtn7hMdt2/oLCNxerez55TBxDU0gF3mojyCWYnCUiAGgbSAjSDa2wuKocp2SEtMiA8iGRfXPTAxZekgoUrRvK9649eoN/lWAK1rTSN2wnK0Q+vPYzYYB1FRfs0ugBAk7KC73xaZKh7D81PohDC4MCFYvt3Ju8rlPMu0IXgOqPmykfofdEtQcznZVouZOWRDEX5AZxTOlLTSrMd22mJx6Ulp2bielMfYhJa0Q4i2iTqSQQd/hbA==;5:0SayfzBHoX33ERvGNEPCDQTIczy896MVCFT7lINEle2CvN/tSBE6owkTggsjnuqqgyFMy3p8m/w5DIviZBSbeyaGjvGDYo21mm27CbGqWFk+SfjPtJW8Id33pMEI1GOlpB6K7otjxQ+PCRri5OFTlg==;24:8NrBSfm7QOmLGxjnftfIrfXiLTs8ATRBQavJCYFH4HMBMVk/thalfldwDWWIA2Qau0OVUuW49zUVGh/9NsOve9TlIqcqwMNfRkVWGC5FwYU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR0801MB2725;7:NDkP91tPKmA2zffqs3n+lieyAE2H8hmrmE38wJl0xY0OxraR2N9XSqXRTgL/iMv6KonBLo+2N0ZWiklUjfa3LRoBLoIPFj8erZSHOQKgcA7lCgdZU/vMbbzjHm3hR+5D8Xh9iIc+AIhDbinaM4xmCdVSmU28wdH57Ja52qb4GbnR4m0g2CS+RD2sxaEnokPfLN3mElGSy18+FAC9nBNqhFmuicutAyWTwJm3PfUDSw4fXVh9ttfidao5j69R9E+e/BeOuStDEN43GuMOz6dxAm2l2Bj0nU4GKu7B6xbhsZj7+CWBDf1Q9I3hC0VrrUahN4OsbJX36MxbFVCcalagvg==;20:CP6fKnFZbQKYptbzpkubHfqp564LJcoS7YTdeEwGlr/iTvaGMTBmwxVnj4OxZFA90lQVSjT2hDqX6C9Ry6wiZhaSDZrjbmgk9RolBfxu8LlR90W4CR0DVw7Y2yNBXKaC1eBTMUYgeWEgpEnA9FU34evAnmbiJFKAoiiVYv/eXN4= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2017 08:28:09.8965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0801MB2725 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/2017 09:20 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > There is missing optimization in zero_p4d_populate() that can save > some memory when mapping zero shadow. Implement it like as others. > > Signed-off-by: Joonsoo Kim Acked-by: Andrey Ryabinin > --- > mm/kasan/kasan_init.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/mm/kasan/kasan_init.c b/mm/kasan/kasan_init.c > index b96a5f7..554e4c0 100644 > --- a/mm/kasan/kasan_init.c > +++ b/mm/kasan/kasan_init.c > @@ -118,6 +118,18 @@ static void __init zero_p4d_populate(pgd_t *pgd, unsigned long addr, > > do { > next = p4d_addr_end(addr, end); > + if (IS_ALIGNED(addr, P4D_SIZE) && end - addr >= P4D_SIZE) { > + pud_t *pud; > + pmd_t *pmd; > + > + p4d_populate(&init_mm, p4d, lm_alias(kasan_zero_pud)); > + pud = pud_offset(p4d, addr); > + pud_populate(&init_mm, pud, lm_alias(kasan_zero_pmd)); > + pmd = pmd_offset(pud, addr); > + pmd_populate_kernel(&init_mm, pmd, > + lm_alias(kasan_zero_pte)); > + continue; > + } > > if (p4d_none(*p4d)) { > p4d_populate(&init_mm, p4d, >