From: Andrew Lunn <andrew@lunn.ch>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: dsa: motorcomm: Prevent rx_bytes/tx_bytes underflow
Date: Tue, 10 Nov 2026 14:15:18 +0100 [thread overview]
Message-ID: <60bec8d3-7a0f-45d4-bc6c-a43ce92d1884@lunn.ch> (raw)
In-Reply-To: <CAAXyoMOwtQB01SFo+o2UPZZtw3Dhkpq94h8N55ZEas81z6VWUA@mail.gmail.com>
On Sun, Nov 08, 2026 at 02:07:34PM +0800, David Yang wrote:
> On Sun, Nov 8, 2026 at 1:26 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > + if (res) {
> > > + dev_err(dev, "Failed to %s port %d: %i\n", "read stats for",
> > > + port, res);
> >
> > Please don't break strings like that. The reason we allow lines with
> > strings to be longer than 80 is because somebody is likely to grep the
> > error message in the code to find out why it is being printed.
> >
> > grep -r "Failed to read stats for" is not going to match.
> >
> > Andrew
> >
> > ---
> > pw-bot: cr
>
> Hmm that would be more than a pure code movement...
True. So add a patch which glues this string, and any other broken
string, back together again.
Andrew
prev parent reply other threads:[~2026-11-10 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 1:54 David Yang
2026-11-07 2:00 ` netdev-bot+sinfo
2026-11-07 2:02 ` David Yang
2026-11-07 17:26 ` Andrew Lunn
2026-11-08 6:07 ` David Yang
2026-11-10 13:15 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60bec8d3-7a0f-45d4-bc6c-a43ce92d1884@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®