From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87EA43168E6 for ; Thu, 4 Jun 2026 08:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561458; cv=none; b=j7DZuUWpWiX9T6KJI5oq2JhUv1TTVoSyNurm7msjiOtru1sX1XIQKI8f5RaRhsOOqGvQxhbw9x+GI9XXLnbYIcANh7as+m6IFJ3Qxr3yophIRD8kuYiy3maE9SlqlRS5gOzpqjTn1JGS8jipk0FQAZTVlJx8k0c1oVKd+6KtG64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561458; c=relaxed/simple; bh=P0ptasRrHsOq1GbyRRWE4UK1KFj1lLae8zDQDtaOHxU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c2HVkmFuuFfPN/2DKlPBHC5jr0FyA8ioc/CyA2Q9cH1feqXdmY3qCfc8SM9qWMsHf1BV5Cav2YtG/t9zgql6U339hgVbhs2Yn+p1R40BZMYFmhH/tERzgn+x+ufQ2WM8ybi5p2MqNrYjVdtmz4gk1nnp8xvvXD7piFCeUybYGjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZGZOOc+M; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aV+QRnNi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZGZOOc+M"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aV+QRnNi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780561456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k6ANPjdusuIst0nSmuvnn+083ZoJCUj2jh5LtAj6Enc=; b=ZGZOOc+Mwi1jalgAdLhsS+KBIhXBqzKfXhWZ+wA9NWaRX2kVxxPoJGzsKubCO06LyNOohn YGQzIe6I+OEfRVdJ2IIOaLAbRVJYf8ve9zrUpqKhw5y2SI5fxfFwFVl9CP+eqeiPm344sT DjgulanRXrD1Bnd1XiMa5NOgzQ6nyek= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-dzPV6AWlOdeXN_l0rnTJzw-1; Thu, 04 Jun 2026 04:24:15 -0400 X-MC-Unique: dzPV6AWlOdeXN_l0rnTJzw-1 X-Mimecast-MFC-AGG-ID: dzPV6AWlOdeXN_l0rnTJzw_1780561454 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490abeb7298so4216525e9.2 for ; Thu, 04 Jun 2026 01:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780561454; x=1781166254; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k6ANPjdusuIst0nSmuvnn+083ZoJCUj2jh5LtAj6Enc=; b=aV+QRnNiiC7v+cOBVMhxKUhHRfkJR3JwrJ3vpOVfKLwnB9Qp0NfHjjsettc4/UCPTr AiBL2yFYthAFO9h99YznCkYEYmKWaP+ue0ztYR1Ayv9IqELSY60JF3Zh866WFf0QLQyO GOTMxBany8Yi6PBvKQoMUekdJNpaX5cCMvWH6G3o2Tcl0s9McsWZ5DHQXsCYtrNP/Fh/ kb0ne4yL6r/0VNjCbuO5m6I6OL64rG8QmxXXHRjJYJ4FI2dkCmr+mDeq+VWDlrLXLdz4 kLkOrA9IczoUvbWVE7A/dZsxfqbjbuWVOtlICO5OKCYues+pxAXBGe0A1uvu0kB37Wb8 TLEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780561454; x=1781166254; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k6ANPjdusuIst0nSmuvnn+083ZoJCUj2jh5LtAj6Enc=; b=S3HOUzKRzNb1uzHasdeRlrs4Ahl+/UQqu0Tf0+mD2cUYGnTrMT21dF8ap85wrnC9T4 ApEicfcbwZ5cjTajWfXBLzg2Jl2lehCEfviLowuFUfoG7yUKFz66taj8qI9o7qLvii6+ oJRjrwbhyTs6p4zuIxhij+0qrkmmzOhVKihAgMWOReCsymBjajeCMQkto9yqtPYXuNAi mWOPiwdoDSrHD18A/JwR9TMxb+DkevzuBooPKCau4jzasqc19R8zQjg2r0+Y6AvMR1xC CgO1TZroQsL6823HzH2AkVAYagUaUlxeio8xoO4y9YfUzzxgjzyu2nWUyPYvmPWUTlJ4 DmoQ== X-Forwarded-Encrypted: i=1; AFNElJ9sfFwNvYbilXDNLD0WQBFe69JXreRb7VnU4MkU4eSsYSh7z751WRI3lZ5HyhYNmoIOSDoiXxap0puuEDw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3Vr86kR8AfEGyTp8PmSU2oBFRJmsEAGBiUUDHluAwlbPObrya Sa372RuUOZ3KqovENXMFGZWIJMclidS7an/1QEwqrn8Cn207NpwQaKqjtGycyc6gZJSZseJdSia Dxe4iYic8ivFaJnn0KYox6vyHHwh9BcYv8Zp6cnxM0niCaBhqsPdWkYV69UMgi+dWtw== X-Gm-Gg: Acq92OFbOxCv2mFElQhVQIllGI9XOTu71JNEELTtPDfLLIum3RFhWWIiLjwf7/ct7bw eyDrb4+Nga1mmgSG9mYrBMvXBxGXYTyDWWN6BvkyMtB8OhJ4qwiS8K3i1ZjOpnhgURJS3/KIVjX 3v4vAeIXV9eR5uw9hXRgBWx4j7adJpZB1uuWqrzj7WwhIffbRAyuLohMKVShMGygqoLMvhvvP+J WT/0PmZWGOJXo4NPXXxSkdew6xYXQrgpvMxnWPHRHN7JzNugeBB07VfRk5EIHA71Du6bpXvjGyM BHGeNFu1o227JrhNztxCxGyi0OsBbRw+R66zrIEu9t1kWBN8MC0gwEsOsxz5z0pEeGW0spuFDsa 4Wwb1ziJcKsrpx/ssw5rCeZ1k/3Ea9nZNiatxbe86lpolWytHfj2TsM+ydp+HCNNp9t4= X-Received: by 2002:a05:600c:3552:b0:48a:563c:c8e2 with SMTP id 5b1f17b1804b1-490b5e73ef3mr99664535e9.3.1780561453976; Thu, 04 Jun 2026 01:24:13 -0700 (PDT) X-Received: by 2002:a05:600c:3552:b0:48a:563c:c8e2 with SMTP id 5b1f17b1804b1-490b5e73ef3mr99663985e9.3.1780561453504; Thu, 04 Jun 2026 01:24:13 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3fd663sm59428225e9.10.2026.06.04.01.24.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 01:24:13 -0700 (PDT) Message-ID: <60c82009-790e-4be9-8651-309b14a6f55d@redhat.com> Date: Thu, 4 Jun 2026 10:24:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 3/5] veth: add tx_timeout watchdog as BQL safety net To: hawk@kernel.org, netdev@vger.kernel.org Cc: =?UTF-8?Q?Jonas_K=C3=B6ppeler?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org References: <20260527135418.1166665-1-hawk@kernel.org> <20260527135418.1166665-4-hawk@kernel.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260527135418.1166665-4-hawk@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/27/26 3:54 PM, hawk@kernel.org wrote: > @@ -1819,6 +1836,7 @@ static void veth_setup(struct net_device *dev) > dev->priv_destructor = veth_dev_free; > dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS; > dev->max_mtu = ETH_MAX_MTU; > + dev->watchdog_timeo = msecs_to_jiffies(16000); Since a repost is neede it could be possibly usedfull using a macro for the above constant and expanding the math leading to the actual value. Also possibly an additional + 1 to avoid a very unlikely false positive on exactly the maximum possible interval timer? /P