From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265BB3B2FF7 for ; Fri, 24 Jul 2026 08:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784880614; cv=none; b=XCWBONYoai9xWiHKXVtixsrL/X+IrVZZmASrLZziyC5Y6N+OaWedN2Kocx6iH2agTbTGpE//4mSxYcpxBmrl/SuRnb5q84IhBUoAfa2+ojLRk3dOzMiIGu8P9T8LJoHT+BV46RRKSK2YR73+kKFYIsFsA8/M20mgqrr7PMFT4gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784880614; c=relaxed/simple; bh=wIp6UNfAPvc8awGiJl3J018KQv0AJvDsgmvgbV5zm3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DelM55/KAilIf92KTQTUb+/Su+lc6I1wf04ZW3l3v0LssxYX7pi4REK3WF1EHWtZQ8pqNrN720U/66qQru/F/+3eJI0UYK2SCsEKBd2JrkQz0n6OWWH4KhZek62I0frcsGQ11crp69ZTwwEQCyiDuPKkWeW72+Bx7T7UuSbQydw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QbX9l5Se; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HCE180C5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QbX9l5Se"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HCE180C5" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O5xb0S1892559 for ; Fri, 24 Jul 2026 08:10:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xFxJkKBL4/9hsERb3NkdYlMvO0tuMhKUefI16OhxPwg=; b=QbX9l5SeBma1nyre 5UdcnVVWepQzkPB7lTwixyX6QccoYo/AvjE2KQ5lSW36ToS385aj6k8hM8pIUj6n 1hwksIWwN9hJus4KHL5LDevUl37JYIYv95Pz2CHaE8ouIepMSbKcdqxPadV0CHkH 2v2kOy7n2WoYcBuiZ6NE+HxBglE/4B78mg7xnBBXariuE8p9PdHXz21f68Z067nu Hv6ou/pWNsTa/AzGrMI6nozqUdPxW4to0RzHCRGabhke0Jl6Xl5/WQjHetJPLuDG KGktX7+/48wO6i3DFBxDITVe6+8kBblPyRge+lF9hlJ3FuKuUF3w+K308IBrhCuh Txc8GA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm2cx8ftm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 08:10:12 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e2237bc43so294916a91.1 for ; Fri, 24 Jul 2026 01:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784880611; x=1785485411; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xFxJkKBL4/9hsERb3NkdYlMvO0tuMhKUefI16OhxPwg=; b=HCE180C55xaBLGOAFEw+rU16XUrMXu/q69t8CkPv+NQIXk87fzy+KOyL7f19zcJll8 Azg3ErG2dai81ncmWg+S0G/j6GZJoXMdvcvq4UJSROQvTGN8blY6WCFOSVBJDDlepDdG RvL3LZUdhiVJmCbVXeM7tW/8WjXASsXhpCX++J7l81yq/NawaKy52k3/vSomBUp3zPm2 dQyzVY9HU/F0YTlIIoykKdJNy06J4RXdFUfxqwEUoLU4vVbLtfkLC2UUGw/jllK+vOVa IHM2HuUZi2O6h8GYhgDeUJ8Y3JPcj47afdAKovvkGgWok3bAJMTY0ctLdGD+XDMbmGSJ 0QlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784880611; x=1785485411; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xFxJkKBL4/9hsERb3NkdYlMvO0tuMhKUefI16OhxPwg=; b=X1ZC4oP7CQ6D2l1P0/FAWPTJt2mQZv5gEiGIvSqDyrSsTJWDLrkbGVE4CkEN+Z9im3 8VX6HSxYAoUZUTL49vd23dxyQ8yRNJcvEzNpdHan4wr0S4XKUvFIQZxPFoD7oiDsMQq3 TIzADdRzMPAY/Sl+oHTYiDyMw4I2X15ZQh0aToWQhMaN60nQDZ9ML7chgkHkLl+xGbYC tsZvIbQeYLQ/l/EaAZ+oMBgsVCmmn6Gt7DAR37UdW41S6n5/9NqoJlQyUMEi5I5ACybd vNXZuayLvZzioRJJhO3Z7oBkATGItN+euYoWq1vFnlvvF2znUgkzR3b9qrvfdBvlocoa Phsw== X-Forwarded-Encrypted: i=1; AHgh+RpKPeq+iIkvL3TnyaTJ8ybKRSqqUDwY9ux3eTnGbYzoLuA50LRamCGU/hnvlT3Ij+psI0GJ2HzSeYpN3CE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxumbq7x31uXxKFP9fP74KgVFCMNdqY0QmlChl4/1IwarI0Hgd+ zchkbe/zHztTJ6BLezgWOq37Q2zrklJ5UhAZT/uYo7q49dg1+MF5OgBPLYcwgkxWtpW5NGQ8gWO 0ceJDF2Oq6vY9QIibe3eQLgPctTzB5wY515WB3cwDCTvaOkfkz2aqSaMDRJOOf/ZqPvc= X-Gm-Gg: AR+sD13zaKOsP3GiiNRxRjHBh7TgmyP/D9cE7OwmvVq5jBJcErLYeLSNAMepGCLaGWL y8wikUjri97EjNc14QlIE3v17ZNKLlcL86zpmH9iF54MLRzB+uXr6LbGRXh/F5w8gUK5VmIyYb4 PSyb56kMEKH62+566beaNh34MN9DtEEOeheZj5yFhTDtmYGZIOThDonhyEt1KqLzPRNRo3dsXp1 UGIW6Sp2NMKZCNpL9C4ZU/ksYsSczo9K4mSiydfFoaFAz5XnuQJsYpET/I0J41pVxi8L6C/AwgC n0clFdjyaguVTRUuM+c55jqEs35MwoHZkpBVxepJGZyBvXk6Y3un1oNbe2slL6SwRqWUxtSL/pw TtWtVHkKfFfrXDenaCOEaUMAwdXNoOHQ= X-Received: by 2002:a17:90b:5146:b0:38e:6f72:9be4 with SMTP id 98e67ed59e1d1-38ec6495a15mr6867730a91.3.1784880611536; Fri, 24 Jul 2026 01:10:11 -0700 (PDT) X-Received: by 2002:a17:90b:5146:b0:38e:6f72:9be4 with SMTP id 98e67ed59e1d1-38ec6495a15mr6867692a91.3.1784880610969; Fri, 24 Jul 2026 01:10:10 -0700 (PDT) Received: from [10.217.252.136] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03c20c06sm1096810a91.12.2026.07.24.01.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 01:10:10 -0700 (PDT) Message-ID: <60caa38e-9294-493a-8749-98687e4bd55d@oss.qualcomm.com> Date: Fri, 24 Jul 2026 13:40:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: rb3gen2: add Industrial BT UART overlay To: Dmitry Baryshkov Cc: Luiz Augusto von Dentz , Krzysztof Kozlowski , Marcel Holtmann , Bartosz Golaszewski , Conor Dooley , Rob Herring , Bjorn Andersson , Konrad Dybcio , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, quic_hbandi@quicinc.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_anubhavg@quicinc.com, quic_mohamull@quicinc.com References: <20260723-rb3-industrial-bt-uart-v1-0-3c8e580c09d1@oss.qualcomm.com> <20260723-rb3-industrial-bt-uart-v1-3-3c8e580c09d1@oss.qualcomm.com> Content-Language: en-US From: Rahul Samana In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: CTzUP37lZbqOdsls-AFvPpWfphvAk2dD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA3MyBTYWx0ZWRfX6RkH22UZczIS xeLduEzVlPrDr0oJL14Ln9SN9WwIqgWHtpCfBP31L/pHqwSy5GY6hz5enb5xZMvnOWMBC5+Zr+M TiGbY15/XJednEt6IB7SoU9sXu9twVIzzfCXdpgPSDv11lXFB9t1dan9pT9p1QvV5OoMCUT3L92 hshfngvDMNcHCzPFxpem5IgzB9PntGXaXL8ZQRJn42Mr/sUvKMUiDLv6zFoXY7ngLbEyGDwCQtP qMoCVG4Xg9TXcv7PCCEYNNPDPArNHQJ7jLS555pGTsKYcqinndS0YPMoB0UNRhySMw6yotnJ6yS 7NWUBzPWHHJ0AKahvkFaZspiDQ8hinsZ64lr2L/5AGUp1aSGlJCbm5jJRFkGr6wIPugC5yhf+u3 vIx2B1/cI1ZOKrIgJ98iqlYfNKkPHae8jWu5b+VzPDMY6RitkPVp6TuI2C326XIDmTrOReuPbxr On+Jl5TgOv5qsQYZMiA== X-Authority-Analysis: v=2.4 cv=X51i7mTe c=1 sm=1 tr=0 ts=6a631de4 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=gUoYVz9MZeqw9imU7sIA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: CTzUP37lZbqOdsls-AFvPpWfphvAk2dD X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA3MyBTYWx0ZWRfX21c+1GTYw44f 20sYNiVRxTH3eR6EqnNKELFDRfc/XfkH6efU+slMtqshTchZ1chCWJJ12KWZ97x070Oxa9mxCX+ Tka+ZS9tO5sBrCAejslNSw5MrLZsF68= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240073 On 24-07-2026 00:40, Dmitry Baryshkov wrote: > On Thu, Jul 23, 2026 at 06:01:09PM +0530, Rahul Samana wrote: >> Add an overlay for the RB3 Gen 2 Industrial mezzanine variant that routes >> QCC2072 Bluetooth over UART4 and models the M.2 E-key connector graph >> endpoints for PCIe and UART. >> >> The default Industrial mezzanine overlay describes the common mezzanine >> hardware. Build this variant by applying the common Industrial mezzanine >> overlay first, followed by the BT UART overlay, because the reworked board >> keeps the common mezzanine description and only changes the Bluetooth >> transport routing. >> >> The overlay also disables the on-board WCN6750 PMU and UART7 path so the >> M.2 QCC2072 Bluetooth controller can be used instead. >> >> Signed-off-by: Rahul Samana >> --- >> arch/arm64/boot/dts/qcom/Makefile | 2 + >> ...s6490-rb3gen2-industrial-mezzanine-bt-uart.dtso | 133 +++++++++++++++++++++ >> 2 files changed, 135 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 6f33c4e2f09c..45786d3db14a 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -179,8 +179,10 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb >> >> qcs6490-rb3gen2-vision-mezzanine-dtbs := qcs6490-rb3gen2.dtb qcs6490-rb3gen2-vision-mezzanine.dtbo >> qcs6490-rb3gen2-industrial-mezzanine-dtbs := qcs6490-rb3gen2.dtb qcs6490-rb3gen2-industrial-mezzanine.dtbo >> +qcs6490-rb3gen2-industrial-mezzanine-bt-uart-dtbs := qcs6490-rb3gen2.dtb qcs6490-rb3gen2-industrial-mezzanine.dtbo qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtbo >> >> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-industrial-mezzanine.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-vision-mezzanine.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-thundercomm-minipc-g1iot.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-thundercomm-rubikpi3.dtb >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso >> new file mode 100644 >> index 000000000000..06560df0a719 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso >> @@ -0,0 +1,133 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +/dts-v1/; >> +/plugin/; >> + >> +#include >> +#include >> + >> +&{/} { >> + vreg_wcn_3p3: regulator-wcn-3p3 { >> + compatible = "regulator-fixed"; >> + regulator-name = "VREG_WCN_3P3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + regulator-boot-on; >> + }; >> + >> + m2_e_connector: m2-e-connector { > > Kill unused labels. Everywhere. > >> + compatible = "pcie-m2-e-connector"; >> + vpcie3v3-supply = <&vreg_wcn_3p3>; >> + >> + m2_e_ports: ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + m2_e_pcie_ep: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&pcie0_m2_e_ep>; >> + }; >> + }; >> + >> + port@3 { >> + reg = <3>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + m2_e_uart_ep: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&uart4_m2_e_ep>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&qup_uart4_cts { >> + bias-bus-hold; >> +}; >> + >> +&qup_uart4_rts { >> + drive-strength = <2>; >> + bias-disable; >> +}; >> + >> +&qup_uart4_rx { >> + bias-pull-up; >> +}; >> + >> +&qup_uart4_tx { >> + drive-strength = <2>; >> + bias-disable; >> +}; >> + >> +&tlmm { >> + qup_uart4_sleep_cts: qup-uart4-sleep-cts-state { >> + pins = "gpio16"; >> + function = "gpio"; >> + bias-bus-hold; >> + }; >> + >> + qup_uart4_sleep_rts: qup-uart4-sleep-rts-state { >> + pins = "gpio17"; >> + function = "gpio"; >> + bias-pull-down; >> + }; >> + >> + qup_uart4_sleep_tx: qup-uart4-sleep-tx-state { >> + pins = "gpio18"; >> + function = "gpio"; >> + bias-pull-up; >> + }; >> + >> + qup_uart4_sleep_rx: qup-uart4-sleep-rx-state { >> + pins = "gpio19"; >> + function = "gpio"; >> + bias-pull-up; >> + }; >> +}; >> + >> +&pcie0_port { >> + pcie@0,0 { >> + pcie@2,0 { >> + port { > > The house that Jack built. Don't use multiple nested nodes to patch it. > The node might go away and nobody will notice it. Add a label to the > exact location and patch only it. > >> + pcie0_m2_e_ep: endpoint { >> + remote-endpoint = <&m2_e_pcie_ep>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&uart4 { >> + status = "okay"; >> + /delete-property/ interrupts; >> + interrupts-extended = <&intc GIC_SPI 605 IRQ_TYPE_LEVEL_HIGH>, >> + <&tlmm 19 IRQ_TYPE_EDGE_FALLING>; >> + pinctrl-names = "default", "sleep"; >> + pinctrl-1 = <&qup_uart4_sleep_cts>, <&qup_uart4_sleep_rts>, >> + <&qup_uart4_sleep_tx>, <&qup_uart4_sleep_rx>; >> + >> + port { >> + uart4_m2_e_ep: endpoint { >> + remote-endpoint = <&m2_e_uart_ep>; >> + }; >> + }; >> +}; >> + >> +&uart7 { >> + status = "disabled"; >> +}; >> + >> +&{/wcn6750-pmu} { > > label > >> + status = "disabled"; >> +}; >> >> -- >> 2.34.1 >> > Hi Dmitry, Ack, I will clean this up in v2. I will remove the unused connector/ports labels and add labels to the existing nodes that the overlay needs to patch, including the WCN6750 PMU node and the relevant PCI child node below pcie0_port. I will then update the BT UART overlay to reference those labels directly instead of reconstructing the full nested path or using the /wcn6750-pmu path reference. Thanks, Rahul