From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sumit Garg" <sumit.garg@linaro.org>,
"Jens Wiklander" <jens.wiklander@linaro.org>
Cc: op-tee@lists.trustedfirmware.org,
"Jerome Forissier" <jerome.forissier@linaro.org>,
dannenberg@ti.com, javier@javigon.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] tee: optee: Fix supplicant wait loop
Date: Tue, 04 Feb 2025 08:45:03 +0100 [thread overview]
Message-ID: <60cd3fcc-5d21-4b98-9a81-f5fbec2099fc@app.fastmail.com> (raw)
In-Reply-To: <20250204073418.491016-1-sumit.garg@linaro.org>
On Tue, Feb 4, 2025, at 08:34, Sumit Garg wrote:
> OP-TEE supplicant is a user-space daemon and it's possible for it
> be hung or crashed or killed in the middle of processing an OP-TEE
> RPC call. It becomes more complicated when there is incorrect shutdown
> ordering of the supplicant process vs the OP-TEE client application which
> can eventually lead to system hang-up waiting for the closure of the
> client application.
>
> Allow the client process waiting in kernel for supplicant response to
> be killed rather than indefinitely waiting in an unkillable state. Also,
> a normal uninterruptible wait should not have resulted in the hung-task
> watchdog getting triggered, but the endless loop would.
>
> This fixes issues observed during system reboot/shutdown when supplicant
> got hung for some reason or gets crashed/killed which lead to client
> getting hung in an unkillable state. It in turn lead to system being in
> hung up state requiring hard power off/on to recover.
>
> Fixes: 4fb0a5eb364d ("tee: add OP-TEE driver")
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Jens, I assume you'll pick it up and send me a pull request, but
I can also pick it up directly if you have nothing else.
Arnd
next prev parent reply other threads:[~2025-02-04 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 7:34 Sumit Garg
2025-02-04 7:45 ` Arnd Bergmann [this message]
2025-02-04 9:12 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60cd3fcc-5d21-4b98-9a81-f5fbec2099fc@app.fastmail.com \
--to=arnd@arndb.de \
--cc=dannenberg@ti.com \
--cc=javier@javigon.com \
--cc=jens.wiklander@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®