mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: German Gomez <german.gomez@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	peterz@infradead.org, alexander.shishkin@linux.intel.com,
	jolsa@redhat.com, acme@kernel.org
Cc: Robin Murphy <robin.murphy@arm.com>,
	Suzuki Poulose <suzuki.poulose@arm.com>,
	James Clark <james.clark@arm.com>, Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V6 6/8] perf/tools: Extend branch type classification
Date: Wed, 15 Jun 2022 14:39:01 +0100	[thread overview]
Message-ID: <60d21662-aa8f-b50a-b0a3-462f1b3dec43@arm.com> (raw)
In-Reply-To: <8bfce917-84a6-23a2-d926-a1efa901f4f1@arm.com>


On 15/06/2022 04:21, Anshuman Khandual wrote:
> [...]
>  
> +const char *get_branch_type(struct branch_entry *e)
> +{
> +	if (e->flags.type == PERF_BR_UNKNOWN)
> +		return "";
>> There is a small change of behavior in "perf script --field brstack".
>> Unknown branches were printed as "-" before but now it's an empty
>> string.
> get_branch_type() replaces print output in two different functions.
> branch_stack__printf() used to print a space " " for PERF_BR_UNKNOWN,
> and print_bstack_flags() used to print a "-" for PERF_BR_UNKNOWN.
> When they are factorized via get_branch_type(), one of those print
> formats need to be choosen.

Thanks for clarifying, Anshuman. I only bring it up in case somebody is
parsing this line for their use case. While running on x86 I came across
some UNKNOWN branches during my runs.

I have updated and sent a generic branch stack sampling perf test that
supports both ("-" and empty string) just in case. Hope it's useful.

https://lore.kernel.org/all/20220615130901.1151397-1-german.gomez@arm.com/

Thanks,
German

  reply	other threads:[~2022-06-15 13:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  3:50 [PATCH V6 0/8] perf: Expand perf_branch_entry Anshuman Khandual
2022-06-10  3:50 ` [PATCH V6 1/8] perf: Add system error and not in transaction branch types Anshuman Khandual
2022-06-10  3:50 ` [PATCH V6 2/8] perf: Extend branch type classification Anshuman Khandual
2022-06-10  3:50 ` [PATCH V6 3/8] perf: Capture branch privilege information Anshuman Khandual
2022-06-10  3:50 ` [PATCH V6 4/8] perf: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
2022-06-10  3:50 ` [PATCH V6 5/8] perf/tools: Add system error and not in transaction branch types Anshuman Khandual
2022-06-10  3:50 ` [PATCH V6 6/8] perf/tools: Extend branch type classification Anshuman Khandual
2022-06-14 16:53   ` German Gomez
2022-06-15  3:21     ` Anshuman Khandual
2022-06-15 13:39       ` German Gomez [this message]
2022-06-10  3:51 ` [PATCH V6 7/8] perf/tools: Add branch privilege information request flag Anshuman Khandual
2022-06-10  3:51 ` [PATCH V6 8/8] perf/tools: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
2022-06-13  9:06 ` [PATCH V6 0/8] perf: Expand perf_branch_entry Anshuman Khandual
2022-06-29  4:44 ` Anshuman Khandual
2022-07-13  5:40 ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60d21662-aa8f-b50a-b0a3-462f1b3dec43@arm.com \
    --to=german.gomez@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anshuman.khandual@arm.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®