mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: max77705: add interrupt-controller node
Date: Thu, 25 Sep 2025 15:11:34 +0200	[thread overview]
Message-ID: <60d2cfed-5018-4afb-9db2-6bf423defc7d@oss.qualcomm.com> (raw)
In-Reply-To: <CABTCjFAO=iLauq37M7LOXOmrgAnPxh210bcoujUsL4zEC3634A@mail.gmail.com>

On 9/15/25 5:46 PM, Dzmitry Sankouski wrote:
> пн, 15 сент. 2025 г. в 10:49, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>:
>>
>>> +      The driver implements an interrupt controller for the sub devices.
>>> +      The interrupt number mapping is as follows
>>> +      0 - charger
>>> +      1 - topsys
>>> +      2 - fuelgauge
>>> +      3 - usb type-c management block.
>>
>> The MFD driver registers one more interrupt, and these don't seem
>> to be what you say here:
>>
>> static const struct regmap_irq max77705_topsys_irqs[] = {
>>         { .mask = MAX77705_SYSTEM_IRQ_BSTEN_INT, },
>>         { .mask = MAX77705_SYSTEM_IRQ_SYSUVLO_INT, },
>>         { .mask = MAX77705_SYSTEM_IRQ_SYSOVLO_INT, },
>>         { .mask = MAX77705_SYSTEM_IRQ_TSHDN_INT, },
>>         { .mask = MAX77705_SYSTEM_IRQ_TM_INT, },
>> };
> 
> MAX77705_SYSTEM_IRQ_TM_INT(and others you mentioned) is a part of 'topsys' irqs,
> which is kinda MFD own irqs. They are unused at the moment.
> 
> See also [max77705 rework interrupt patches](https://lkml.org/lkml/2025/8/31/27)

This would be useful to mention as a dependency..

Perhaps >this< patch should be part of that series you referenced, too
(or they could come together with this DT change even)

Konrad


  reply	other threads:[~2025-09-25 13:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 16:47 [PATCH v3 0/3] starqltechn: fix max77705 device irqs Dzmitry Sankouski
2025-09-12 16:47 ` [PATCH v3 1/3] dt-bindings: max77705: add interrupt-controller node Dzmitry Sankouski
2025-09-15  7:49   ` Konrad Dybcio
2025-09-15 15:46     ` Dzmitry Sankouski
2025-09-25 13:11       ` Konrad Dybcio [this message]
2025-09-25 19:27         ` Dzmitry Sankouski
2025-09-22 15:30   ` Rob Herring
2025-09-12 16:47 ` [PATCH v3 2/3] arm64: dts: qcom: sdm845-starqltechn: remove (address|size)-cells Dzmitry Sankouski
2025-09-15  7:50   ` Konrad Dybcio
2025-09-12 16:47 ` [PATCH v3 3/3] arch: arm64: dts: qcom: sdm845-starqltechn: fix max77705 interrupts Dzmitry Sankouski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60d2cfed-5018-4afb-9db2-6bf423defc7d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dsankouski@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®