From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbdGaK10 (ORCPT ); Mon, 31 Jul 2017 06:27:26 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36771 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdGaK1Z (ORCPT ); Mon, 31 Jul 2017 06:27:25 -0400 Subject: Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 To: Mark Brown Cc: Banajit Goswami , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Patrick Lai , linux-kernel@vger.kernel.org References: <20170726003512.18965-1-srinivas.kandagatla@linaro.org> <20170726003512.18965-5-srinivas.kandagatla@linaro.org> <20170728134038.y5wnrurmwn4bxxsh@sirena.org.uk> <94765031-d840-bcae-11e3-16e1e55a7aa7@linaro.org> <20170728140108.ds5x4irfep4ss3lv@sirena.org.uk> <0f96d65a-f7d9-0139-e0c4-49069e717f34@linaro.org> <20170731100705.lbnodjfgnwxwhqyt@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <60dca225-d9d2-8570-2779-cf55bf605b87@linaro.org> Date: Mon, 31 Jul 2017 11:27:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170731100705.lbnodjfgnwxwhqyt@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/17 11:07, Mark Brown wrote: > On Fri, Jul 28, 2017 at 03:45:08PM +0100, Srinivas Kandagatla wrote: >> On 28/07/17 15:01, Mark Brown wrote: >>> On Fri, Jul 28, 2017 at 02:54:59PM +0100, Srinivas Kandagatla wrote: > >>>> This was set to 2.7v previously for special headsets which have high >>>> impedance. > >>> So obviously this will break existing users. That's not OK. > >> This would not break any exiting users, as this part is applicable for only >> headset detect usecase. I will try to address this in ("PATCH 5/6 ASoC: >> codecs: msm8916-wcd-analog: add MBHC support") patch. > >> The default voltage for most common usecase should be set to 1.8v anyway. > > Just leave it at the hardware default like we do for everything else in > ASoC. Yep, makes sense, the hw default is at 1.8v. thanks, srini >