From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7ABD38AC6E for ; Tue, 23 Jun 2026 17:25:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782235543; cv=none; b=B72BZ1FJjB49DM3/Nc3QtKqPDBvEZsATeHBzSBcTpJzB9tqLPgB9kNn1Mzwm22LpG3KENJaIORTaPmu6GWlcLnnK9RnOmoTik7njEdJlXvQMTwrcgUi6wkq/IvW2bVf98kCFreTne+YsFow1xDE8iGOXMFsR2eOB8h24S914n1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782235543; c=relaxed/simple; bh=7xpdqqOexDyXfuvNP0R2WagBlv+abOm0IoUpXnzn7ww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XE523uBruhgM5xroJ36Fq/Qx31NJ4poN46GpxqT9viKt2hft0oe+wRR01eovTwoM/niI/KILYwjlFAeHNSY5fb9YuvBHIF82WnI53P6aRpc5xdgBpAVm1kMbfHzA7jT4n7a/9C+qHONnnf2iAMBnLd/9FhSOCvZUmeqT9W4xFR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pD6KkBja; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bedIy7VY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pD6KkBja"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bedIy7VY" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXgtw3753493 for ; Tue, 23 Jun 2026 17:25:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S0o/pMRQe4CmKGPoVmXwqmR7zJeLr6n31bsjYwjX2uI=; b=pD6KkBjagTsGq9kS 0GX4kdFHTz15FI9CkLoymNADsdWZyOEjOsuEogHwVg4NZ4umdT5vDwvvNk5Ge1j3 N4SMnzri7XTBI/30MUJ/jvCh3l7s7ebWjOe70qPM/8aPsRtSPSKglntkoORMargw fAGrgsaPijY6qz/nDELM75DbrssJcODEhYgD3LHwPsaFFxYny2KX9aj6/aM8oj9l tiIfKnMJPH6LkVyfuEBQ0IydKGkHSU/poQJ7/w9IdT/Nw5S8PayEUJ+AjBxd/JoV 8CdWqlAAZgxQmrSckFFEKZuXD0pnOVBP/wRfwzxiyzVWtdMze4XJ2xKsF3gaFyt9 4NqvJw== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyp29jg4n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 17:25:41 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-6c554284973so103069137.2 for ; Tue, 23 Jun 2026 10:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782235541; x=1782840341; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S0o/pMRQe4CmKGPoVmXwqmR7zJeLr6n31bsjYwjX2uI=; b=bedIy7VYqjANkeiU+KyBdk2nxqf9f5qoSeGhgD5RBIW24xIhXBbP6msurpQoO/Ffdo ZmmTMGqsJX40Yu1OxwYYZhLDXYSUzNgk1txHM5t1iRzGCsweFItyjRaShaZxxpXViuux X9feWWDIYuC6QhNdZhz7nltOmtfRx4R+1BO49vZj2QO3yNhBJ+OJI1O22zTUdNDxogpR /pl1Z707Q8QoVSCyRYP19Atxq7+WfOugnGImDgxTK8rxslrdjd6JsQ1XLCdxxYdvH33n U8KqaAwP2Lm1J55SuG7TaZUL3+aJvPzbM3U77LgAvT6V9eCpi19AkgI+S9fFlqFURRAJ VjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782235541; x=1782840341; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S0o/pMRQe4CmKGPoVmXwqmR7zJeLr6n31bsjYwjX2uI=; b=gAgn0egz5vdbx2rAQ53/CSvCRUw0ex57VkxYynWyDAK9vHpg+2xtvwpMxmKCOniAyN TIOFAtGCd4K64Ma5HR4AYcjKVW8v/w1YGIdgW2NLqSr32zOZCsBx0g8EDkUl7XkrbbiO R9sJlmaFJRRhWskb2vuRSW25NHtwJm0ATdFCzDsxgJZ7HuYR4cYx+KdeNr0i8ybgtrql WZojP4L7vErLMOOYj9JcP65VuUB5AlOOw1zsZGJFPGCX0ofvsibyyytKnaOAV/qUxDud WdevSoqmSyi7ffL5Hf6J+5bz+Ub0Cn+I1NwFZRGprms3Sbx7k+HCKJieyE5lJO+y2jPt WbuQ== X-Forwarded-Encrypted: i=1; AFNElJ+i8++q6mNUYAfg0XQDpIkyJNUB2VIgjoackeWxraI0GhcKcqnHGRMOPcE5RAMWSeFkd2k7q8l8JM3W/gw=@vger.kernel.org X-Gm-Message-State: AOJu0YwXohDTqUK7JWGlV7XrA6O2EiU3cEo2m33/GV312PHbD9Tqb1tS FZDRzl8ozImr+gHjsFHyRepQaP30Fsgs3byMEwt7PCapCK+HF2fRFo3dfJxIENwLFQaVTbegBoh vc1eHSQ+IRE61FZJX6FoFxTTpZzxM5TgBALbMJhTH2RE/30jc3HCUbZF7wEaUJpakUR4= X-Gm-Gg: AfdE7ckor7BxFZ2xviQDCRXdEVuiJRFW5iEJ0E8HJBKVU/3XZLRf940t86IWvJuSAwW CduJk1rFtXjA0trxVtrxaETH7O2aO5mzhoqj4kd48r2/Et1KQnwDJ1DJh6m82qz0sGuoCNjeLeD HgwdJ21pqAB0vh1fVNxUhpTevl1VGBxKXawk7P5aj1U8RxJ1jy0AYz36bhhKOkdTBmpdvDaxl7V TQHpnPatxr/OtftPP1bRErBfHKZQOEloJ+3tlcFHJX8pcQYFi+QO3xKaR6UWLiASWBsh1yQltXG Ejg9a2rSn729KdRERqWKQ8XZi2XyKyrd9tZ5hWtRQRukjijGo5CVzMqBgkbVcsigA5O7311QAX3 7kczAyLCcwKX5kLqttHEP6UzNhCUX1UdLJreajAtQd2h3XIgkduetyPyBMJYRoXTuBkqdm43rRQ == X-Received: by 2002:a05:6102:2928:b0:726:717a:696f with SMTP id ada2fe7eead31-72a1fdfca49mr13026663137.25.1782235541049; Tue, 23 Jun 2026 10:25:41 -0700 (PDT) X-Received: by 2002:a05:6102:2928:b0:726:717a:696f with SMTP id ada2fe7eead31-72a1fdfca49mr13026454137.25.1782235535858; Tue, 23 Jun 2026 10:25:35 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:f215:464f:8820:b8e7? ([2a05:6e02:1041:c10:f215:464f:8820:b8e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c579d4sm38533258f8f.28.2026.06.23.10.25.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 10:25:34 -0700 (PDT) Message-ID: <60e45b3b-7c47-44bb-ae3f-7b3579633434@oss.qualcomm.com> Date: Tue, 23 Jun 2026 19:25:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] platform-drivers-x86 for v7.2-1 To: "Rafael J. Wysocki" , Linus Torvalds Cc: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Lukasz Luba , Daniel Lezcano , LKML , PDx86 , Hans de Goede , Andy Shevchenko References: Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=LdAMLDfi c=1 sm=1 tr=0 ts=6a3ac196 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=qNABUOcEAAAA:8 a=Z4Rwk6OoAAAA:8 a=QyXUC8HyAAAA:8 a=K5_vvi-VMt-VjxNi3mwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 a=Ytm653ucTKQjCvbzLygB:22 a=HkZW87K1Qel5hWWM3VKY:22 X-Proofpoint-GUID: zIinFiSFhqOXdt5v5HDhpoDTEXxJy4vD X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDE0MyBTYWx0ZWRfXwuSGb4DJ+PiQ 8NWbJQQ5vYimDPWv3mvAKwEZj8Rkfw94phQwG94ZHjCQtZlUWApJsjdkjDVr9t2q5W4Vlzmc3qi nY+ZqUSzOiDZelunyuE4AK2ayBdn8ww= X-Proofpoint-ORIG-GUID: zIinFiSFhqOXdt5v5HDhpoDTEXxJy4vD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDE0MyBTYWx0ZWRfXw+GbuNoZxjPW gyNDkOix/FNooNJy7JL73S0/fZF7HR1leZK8cDdDOAcfMryBlXcqs0i4k/AedHoLdWRKQEKiHJx v6QxJa+o6ZXpcVNtaMu4CtXwZpr7+gLN9Qvu4pqTZs4JOOlbo7y0qV1t6M0x8BDg9rH9mjrSDuZ Mzl+O8y9y0W4wmR+PhyZfS7DoxmH1opn7LE2GPD5j2p8gzACYKHXLOmkB5hvYBBZzajECnwldfM ZFjuceMohm9ED2ScBhIFgwdCnrZtHnMHEQWZw3fdB0bABNNjnn/kUbt6ujZXxrQPAjxpsXPHthc AnE3UC7Fl+IoP2LqZgynLyeYzX7NFccwt8N4k5Ktu5n1XMCckmWKxN6g2qB/Khtj7m6vBrvPYEx X3YPlKU9VydFHARohs7L/VUoDT08gBLWSGT/w3gBOrJEy4q1RiwUIaF4Zi7o3hcnskq0wc17kx4 Wk3vuhYlU77gqBdC+Gg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230143 On 6/23/26 18:53, Rafael J. Wysocki wrote: > On Tue, Jun 23, 2026 at 5:37 PM Linus Torvalds > wrote: >> >> On Mon, 22 Jun 2026 at 11:42, Ilpo Järvinen >> wrote: >>> >>> There is going to be a conflict with the commit 3570cb58e317 ("thermal/of: >>> Pass cdev_id and introduce devm registration helper") and a few other >>> commits that came from thermal tree effectively resulting in a change in >>> devm_thermal_of_cooling_device_register() signature. It needs to be >>> addressed in the merge commit or the build will fail. >>> >>> Mark's linux-next discovery about the build failure: >>> >>> https://lore.kernel.org/all/aibZy5rrdX3ltGpr@sirena.org.uk/ >> >> That resolution makes absolutely no sense. >> >> Now that qcom_ec_probe() goes through all the work to create a name for the fan: >> >> char name[EC_FAN_NAME_SIZE]; >> >> scnprintf(name, sizeof(name), "qcom_ec_fan_%u", i); >> >> but then the name is actually never *used* after the change. >> >> The *logical* resolution would be to make it use >> >> devm_thermal_of_child_cooling_device_register() >> >> instead, which that function was renamed to in commit 8e1529e79385 >> ("thermal/of: Rename the devm_thermal_of_cooling_device_register() >> function") >> >> I have done that resolution that at least makes sense. >> >> But honestly, this is all a complete mess. >> >> Why the hell was that function renamed, and then a new function >> created with the old name - when that new function then has exactly >> ZERO users? >> >> Renaming a function, and then re-using the old name immediately for >> something else is a BAD IDEA. It causes exactly this kind of horrible >> confusion. It's an even worse idea when there are exactly zero new >> users that make that confusion worthwhile. >> >> Thermal people - you effed up. Stop doing this kind of crap. This is insanity. > > Right, the new function should have been given a different name. > > Sorry for letting this slip in. Yes, sorry for that. I'll take care of not reusing the same function name in the future