From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Bard Liao <yung-chuan.liao@linux.intel.com>,
linux-sound@vger.kernel.org, vkoul@kernel.org
Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
peter.ujfalusi@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH v2 0/3] soundwire: bus: re-enable CLOCK_STOP_MODE1 support
Date: Fri, 4 Sep 2026 09:25:29 +0200 [thread overview]
Message-ID: <60e6f5b1-eaee-4eff-9330-b87eb77abfd7@linux.dev> (raw)
In-Reply-To: <20260901030311.232823-1-yung-chuan.liao@linux.intel.com>
On 9/1/26 05:03, Bard Liao wrote:
> Add CLOCK_STOP_MODE1 back to allow the peripheral to utilize it when
> the clock is stopped.
> This mode is designed for power-sensitive devices as it enables a deeper
> power-saving state, although it does not retain the peripheral's state
> during the clock stop.
>
> v2:
> - check slave->probed before looking at the driver to avoid NULL pointer
> dereference.
> - add wake_enable parameter to stop_bus ops to stop the clock but keep the
> bus unwakeable during system suspend.
>
> Bard Liao (3):
> soundwire: bus: add CLOCK_STOP_MODE1 support back
> soundwire: Intel: add wake_enable parameter to stop_bus ops
> soundwire: Intel: stop sdw clock in system suspend
>
> drivers/soundwire/bus.c | 54 +++++++++++++++++-----------
> drivers/soundwire/intel.h | 6 ++--
> drivers/soundwire/intel_auxdevice.c | 7 ++--
> drivers/soundwire/intel_bus_common.c | 8 ++---
> include/linux/soundwire/sdw.h | 4 +++
> include/linux/soundwire/sdw_intel.h | 2 +-
> 6 files changed, 50 insertions(+), 31 deletions(-)
>
Thanks Bard, LGTM - this addresses my previous feedback.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
prev parent reply other threads:[~2026-09-04 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 3:03 Bard Liao
2026-09-01 3:03 ` [PATCH v2 1/3] soundwire: bus: add CLOCK_STOP_MODE1 support back Bard Liao
2026-09-01 3:03 ` [PATCH v2 2/3] soundwire: Intel: add wake_enable parameter to stop_bus ops Bard Liao
2026-09-01 3:03 ` [PATCH v2 3/3] soundwire: Intel: stop sdw clock in system suspend Bard Liao
2026-09-04 7:25 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e6f5b1-eaee-4eff-9330-b87eb77abfd7@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®