From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Nick Li <nick.li@foursemi.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: fs210x: Make cache write through again during resume
Date: Thu, 16 Jul 2026 10:41:02 +0200 [thread overview]
Message-ID: <60eb194f-9568-4111-b224-c9a03a774a63@intel.com> (raw)
In-Reply-To: <20260715-asoc-fs210x-fix-resume-v1-1-dd81d9c62c05@kernel.org>
On 7/15/2026 10:16 PM, Mark Brown wrote:
> The fs210x driver currently puts the regmap cache into cache only mode
> during suspend but at no point does it make it writable again, meaning
> that device can't work after suspend other than basic powerup which
> bypasses the cache.
>
> Mark the cache as writable again when we resync the registers, it's not
> clear to me that the cache only mode is needed at all but this is a
> fairly minimal change. Since this is setting a flag it's safe to do
> even if the cache was not previously in cache only mode.
The first paragraph seems to mark this patch as a good Fixes: candidate.
That's just a nitpick though.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2026-07-16 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 20:16 Mark Brown
2026-07-16 8:41 ` Cezary Rojewski [this message]
2026-07-16 12:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60eb194f-9568-4111-b224-c9a03a774a63@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nick.li@foursemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®