From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lothar Rubusch <l.rubusch@gmail.com>, Rob Herring <robh@kernel.org>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, eraretuya@gmail.com
Subject: Re: [PATCH v2 3/3] dt-bindings: iio: accel: adxl345: Add spi-3wire
Date: Sat, 23 Mar 2024 15:27:05 +0100 [thread overview]
Message-ID: <60ed3d61-1ece-498f-97a2-7b1c618ceacb@linaro.org> (raw)
In-Reply-To: <CAFXKEHYrRn+vKZB9eX_RFDLanhqLsRwT1b-wxUdeZTrBrshSzA@mail.gmail.com>
On 23/03/2024 13:04, Lothar Rubusch wrote:
> On Fri, Mar 22, 2024 at 3:17 AM Rob Herring <robh@kernel.org> wrote:
>>
>> On Fri, Mar 22, 2024 at 12:37:13AM +0000, Lothar Rubusch wrote:
>>> Provide the optional spi-3wire in the example.
>>
>> That doesn't match the diff as you don't touch the example. But really,
>> this should say why you need spi-3wire.
>
> I understand. The change does not add anything to the example. which
> is definitely wrong.
> Anyway I'm unsure about this change in particular. I know the spi-3wire
> binding exists and can be implemented. Not all spi devices offer it. Not all
> drivers implement it. My patch set tries to implement spi-3wire for the
> particular accelerometer.
> Do I need to add something here to dt-bindings documentation of the
> adxl345? Or, as an optional spi feature, is it covered anyway by
> documentation of optional spi bindings? So, should I refrase this particular
> patch or may I drop it entirely? Could you please clarify.
Whether you need to change bindings or not, dtbs_check will tell you.
Just run dtbs_check on your DTS.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
AFAIR, spi-3wire requires being explicitly mentioned in the device bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-23 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 0:37 [PATCH v2 0/3] iio: adxl345: add spi-3wire Lothar Rubusch
2024-03-22 0:37 ` [PATCH v2 1/3] iio: accel: adxl345: Update adxl345 Lothar Rubusch
2024-03-22 5:51 ` Krzysztof Kozlowski
2024-03-22 5:53 ` Krzysztof Kozlowski
2024-03-22 7:18 ` Nuno Sá
2024-03-23 12:16 ` Lothar Rubusch
2024-03-24 13:48 ` Jonathan Cameron
2024-03-22 7:16 ` Nuno Sá
2024-03-22 0:37 ` [PATCH v2 2/3] iio: accel: adxl345: Add spi-3wire feature Lothar Rubusch
2024-03-22 0:37 ` [PATCH v2 3/3] dt-bindings: iio: accel: adxl345: Add spi-3wire Lothar Rubusch
2024-03-22 2:17 ` Rob Herring
2024-03-23 12:04 ` Lothar Rubusch
2024-03-23 14:27 ` Krzysztof Kozlowski [this message]
2024-03-23 17:44 ` Lothar Rubusch
2024-03-25 7:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ed3d61-1ece-498f-97a2-7b1c618ceacb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eraretuya@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®