From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31709EB64DD for ; Wed, 12 Jul 2023 19:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232415AbjGLTLm (ORCPT ); Wed, 12 Jul 2023 15:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjGLTLh (ORCPT ); Wed, 12 Jul 2023 15:11:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A44181FC3 for ; Wed, 12 Jul 2023 12:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689189051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q45SoRMuLgunlP8L7mZ4yYklFc9J8ZjnlV0HAlFrluA=; b=FvtSAKP/W0rluk3vy56TimDf2Qni7XOh5q48UldEydX5Cf/BmsggFGMCY94SDKEUgy7A9+ CGZPlRXNPT2KZhG5Euz9vPA7VWt9c2uq/A+V+nvmyfw2pZGUEPok7CsHfAvPFm7ZXhgsFQ It1bsnMe8emNIf1fKPi3N26ENukUBPg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-oI-dg_M4P4CXYKtj2ZY4Bg-1; Wed, 12 Jul 2023 15:10:50 -0400 X-MC-Unique: oI-dg_M4P4CXYKtj2ZY4Bg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fbefe1b402so45723335e9.1 for ; Wed, 12 Jul 2023 12:10:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689189049; x=1691781049; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q45SoRMuLgunlP8L7mZ4yYklFc9J8ZjnlV0HAlFrluA=; b=bT3OxuIE9o8LlxqPt+PtBEEX0soqTySb6ZYnNpgZgB5wfT5Kg9LpH3SGhXVdPsr/iU lfbSEPDP9LqblNLTBmHnZOEyFMVBS68z3K6iBKY8mKEYSgowezO7ahJH5YB+y06B4Uf2 C2i3NLL0Dqt2TGNkj7jsigJpxXjM7gXow6oIJESksDrEPdjgKyOxpqry5ajfUd4v5XWW 5BRqd2iJVqXwBOK+A0YeCLxVy6dTjSoFnAfzfBQZPZUavfvxMjWIXl7wPk/sqB2SL2GS o5MKNUDsfXLoSAfbiOzhuyQo4R3lab65dLYktbopNDAOqiF421VXq3lW12QwcPpBdz6F 0VBg== X-Gm-Message-State: ABy/qLaCWe6WUDNnsn3S/0o/kWfU5vFQqeTkPxYOVHN++9JQX26wzRfQ TL4AHTnDYbWz9P4x/HIZSaM5WUCNSOCw5OcDRl8E6pYSqxWdrKq2NmNNRn2sZ0uBQEbtS8qEji5 ExBCkomMxKvkIE4/FW/7WrnnT X-Received: by 2002:a7b:c019:0:b0:3fb:a62d:1992 with SMTP id c25-20020a7bc019000000b003fba62d1992mr16262195wmb.0.1689189049322; Wed, 12 Jul 2023 12:10:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlG7+RfJW8rL+kAwaM2CugjDDuPQVV8Tbi86e3qb2YFzqDwqbvHOu/X6/+h7PYfnyGjOw9KBjA== X-Received: by 2002:a7b:c019:0:b0:3fb:a62d:1992 with SMTP id c25-20020a7bc019000000b003fba62d1992mr16262181wmb.0.1689189048992; Wed, 12 Jul 2023 12:10:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3700:3eea:ace6:5bde:4478? (p200300cbc70737003eeaace65bde4478.dip0.t-ipconnect.de. [2003:cb:c707:3700:3eea:ace6:5bde:4478]) by smtp.gmail.com with ESMTPSA id o29-20020a05600c511d00b003fa9a00d74csm409177wms.3.2023.07.12.12.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 12:10:48 -0700 (PDT) Message-ID: <60f2ef09-53b2-6bf8-9cd0-3b639ac7b765@redhat.com> Date: Wed, 12 Jul 2023 21:10:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH][next] selftests/mm: mkdirty: Fix incorrect position of #endif Content-Language: en-US To: Colin Ian King , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230712134648.456349-1-colin.i.king@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230712134648.456349-1-colin.i.king@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.07.23 15:46, Colin Ian King wrote: > The #endif is the wrong side of a } causing a build failure when > __NR_userfaultfd is not defined. Fix this by moving the #end to > enclose the } > > Fixes: 9eac40fc0cc7 ("selftests/mm: mkdirty: test behavior of (pte|pmd)_mkdirty on VMAs without write permissions") > Signed-off-by: Colin Ian King > --- > tools/testing/selftests/mm/mkdirty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c > index 6d71d972997b..301abb99e027 100644 > --- a/tools/testing/selftests/mm/mkdirty.c > +++ b/tools/testing/selftests/mm/mkdirty.c > @@ -321,8 +321,8 @@ static void test_uffdio_copy(void) > munmap: > munmap(dst, pagesize); > free(src); > -#endif /* __NR_userfaultfd */ > } > +#endif /* __NR_userfaultfd */ > > int main(void) > { Ouch, thanks! Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb