From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAB832C181 for ; Tue, 28 Apr 2026 13:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777381463; cv=none; b=Eq61QaIy+8DmIpggLTWhxYPXSY8ANOjxiAyaGBoutro6H2Ou8JNoPQ4SD8WfCbGpSMlA+d7gcSoQC04uJkam6GWAF7OM6ehJPyau77yYN/DzY1KGBqfyjaGjdgcCsMHIuKJrk+oISCGVm1NnMaHX0AtFpTDVV0SKtOlDfO7/4h0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777381463; c=relaxed/simple; bh=yvfWbNsf7kvzImbLhP8AA1uE2RBdkUT+264nPwInwps=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DGXm4iqYeOVzS2ekmwD44DJSmzo5Stx6oYfBNAnS+pNc6KpSBKHwwNFljlOoesTvpRzkkn3dtoI6TlyaoTQMOxq4fTIn8YFc8gKr7i276SCBbouFL44pZHo07yFtZLJDZHZGqNV3LGv6gID/zDn3DJ0V0eMbyz62bEzfx7v2LQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KliFUdeM; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KliFUdeM" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-bad54961385so858052466b.2 for ; Tue, 28 Apr 2026 06:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777381460; x=1777986260; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yvfWbNsf7kvzImbLhP8AA1uE2RBdkUT+264nPwInwps=; b=KliFUdeMkJ+CQ6Odbn4kNAS1DOmHwGlILKqT/xzQs6Tk3jXJZ3ssU44SCXNTVWOoQn 2SYcdyU5OFNg9mHMgbWDVNPPl7fK9Qa7JfddxUZ4qq9TB3CPwMs3+G7YOiwqNQeq7xFE u6tHppJdtye+WKwnGTfeicjG+vHXWQtZcwcV3QGxiAQ8y6kJEZKuxd7+EAXR3hWpwhgj 0A+0m9g8VTzJtI06q4gQ3xxFT7iLDOWRd7FqKYNN3vyLNh9NmF7UXGktIyPnintfhWRE KcgCd2U42DW/PvHSagJB+MpzJsXqW9Dg5nfJ+R3EP5mlIs04xeizaNkS/NHlVmWw9T38 kuFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777381460; x=1777986260; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yvfWbNsf7kvzImbLhP8AA1uE2RBdkUT+264nPwInwps=; b=rIz0zAFucgqn5wXSMQEBowDpa4/9Id8lJA5rta9s+ZVJf+Sdkpi2R9TLjaKQZWqpp9 AlGd6iGc/Jq+z7Iqmu1mkFGHxCOwoR+IeCMJFf88UGpZyQyoKLe+IqPOPIAS66Vqrw9E EEzWudbVpKi+OaMjj79Pn2KDAXTDR8GuP7CItcmqQNPLG7X43eoa/9IeCBQD0bcBN0mh 6YMCjRhwpYPHvOeDBW74H0uFtRYLNNdTfHTUempGGA8bDSwdHKTqOOHamKyqP0vQONTA xcyTqLiasZev6/E/KWv+HAo3P5C5ONCv/CG7zT69jWeh6rekt4pHjhAUOOEmEnbz0P+S b/xw== X-Gm-Message-State: AOJu0YxLrSyzQxdN+dsAX7MaUv8uaY8EPQikzud6+SsfBIr3SHGT1PPS DvdYLmkLUANPCFHOpadeqxjRzk0Izti1tSF2kmoxYnehGRAkJhABJEoqLhOc78t0ozU= X-Gm-Gg: AeBDiesbQL3zHOb27VrCnxWBT10Dx0QHMb7SdOkXeJf2p/Kmo8RyoFmjPCHGNt/nPmc QcIZsrXge53L+z+tyV8B+Pw8PudxP5IgDtRAZx6C1ql8F+YI5jLukLWvxQ8EtvKhVowxNS2/hfW EKZLMbt1csFmgsPB4+aQ8Sn7FlESbLxc6DTbcnFJk+f118GGlNwIZKg3t+HJhR7vByBNKFKwvWn KU7GEo1MAOf/Zf4wMtOkmUJiWjaZZ/HH0+bPoLwmACotzbCsT05HIkxrjDrYfVXmOtUm5d0lhxn VnRdELg4KTt5nZa6K7Jn5PrYm3Z+mLixeV21Dn0dF6GlXaGDmIf2AinsoTcxf6M7b2+Pasjdg/Z Cc/Wn5ZRSwiOQqq0T5AtpAPRym+fwT+EX+ppY06tYdD8mtZWK/4BARfPk8NQrF9gfn7DzQiTmGl WIKsm6CHyM6+9BSRjXfEdVUfW+VTbohFvLKNUZ1Ur/gDLs+B7wwynoUg== X-Received: by 2002:a17:907:9454:b0:ba7:e3ee:47a1 with SMTP id a640c23a62f3a-bb8018dccb7mr182160466b.4.1777381459520; Tue, 28 Apr 2026 06:04:19 -0700 (PDT) Received: from [10.11.12.108] ([79.115.63.228]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-679b685290dsm754196a12.24.2026.04.28.06.04.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 06:04:18 -0700 (PDT) Message-ID: <60f71fd7-1079-4936-b4b0-9d45a2c112ce@linaro.org> Date: Tue, 28 Apr 2026 16:04:16 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] firmware: samsung: acpm: Fix out-of-bounds read and infinite loop in RX path To: Krzysztof Kozlowski , Alim Akhtar Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, peter.griffin@linaro.org, andre.draszik@linaro.org, jyescas@google.com, kernel-team@android.com, stable@vger.kernel.org References: <20260427-acpm-fixes-sashiko-reports-v2-0-1ff8de94a997@linaro.org> <20260427-acpm-fixes-sashiko-reports-v2-5-1ff8de94a997@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20260427-acpm-fixes-sashiko-reports-v2-5-1ff8de94a997@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit FYI, I checked sashiko's review on the set, and I shall act on this patch and extend the checks for tx_front >= achan->qlen and add zero length checks for qlen and mlen that were read from SRAM. I'll do that in v3. The rest of the review feedback doesn't apply, so together with the changes proposed in patch 4/6 that will be all. Cheers, ta