From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932171AbbBRTtM (ORCPT ); Wed, 18 Feb 2015 14:49:12 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:56269 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbbBRTtK (ORCPT ); Wed, 18 Feb 2015 14:49:10 -0500 From: Arnd Bergmann To: netdev@vger.kernel.org Cc: davem@davemloft.net, Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] net/appletalk: LTPC needs virt_to_bus Date: Wed, 18 Feb 2015 20:48:54 +0100 Message-ID: <6100590.gsNqMCFyRS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Qkns89vI6eItaCobaZv8o25H2v6N33P0XVvLZHiy8EhfZD785r5 +wKSv+PQjqXSQq7g7HPqsigVGvKi8fwCtSgdkHZXUFIAnJXKxDcYGkeawOo7rab82eBKE0G q1x+/Ow+HPdsCBQ1lbxhEueJEsfyIAuIwhferrKBQ5mDPgofmy/ZXh3BPJyfrbmjum67fPo e2RydG3Pb1Swe56sF+7Dg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ltpc driver is rather outdated and does not get built on most platforms because it requires the ISA_DMA_API symbol. However there are some ARM platforms that have ISA_DMA_API but no virt_to_bus, and they get this build error when enabling the ltpc driver. drivers/net/appletalk/ltpc.c: In function 'handlefc': drivers/net/appletalk/ltpc.c:380:2: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration] set_dma_addr(dma,virt_to_bus(ltdmacbuf)); ^ This adds another dependency in Kconfig to avoid that configuration. Signed-off-by: Arnd Bergmann diff --git a/drivers/net/appletalk/Kconfig b/drivers/net/appletalk/Kconfig index 4ce6ca5f3d36..dc6b78e5342f 100644 --- a/drivers/net/appletalk/Kconfig +++ b/drivers/net/appletalk/Kconfig @@ -40,7 +40,7 @@ config DEV_APPLETALK config LTPC tristate "Apple/Farallon LocalTalk PC support" - depends on DEV_APPLETALK && (ISA || EISA) && ISA_DMA_API + depends on DEV_APPLETALK && (ISA || EISA) && ISA_DMA_API && VIRT_TO_BUS help This allows you to use the AppleTalk PC card to connect to LocalTalk networks. The card is also known as the Farallon PhoneNet PC card.