From: "Oliver Pinter" <oliver.pntr@gmail.com>
To: "Jens Axboe" <jens.axboe@oracle.com>
Cc: "Hugh Dickins" <hugh@veritas.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splice: use mapping_gfp_mask
Date: Fri, 4 Apr 2008 22:54:32 +0200 [thread overview]
Message-ID: <6101e8c40804041354g2b065078i997e63cf03e576f0@mail.gmail.com> (raw)
In-Reply-To: <20080404114609.GG29686@kernel.dk>
hi all!
this patch for 2.6.22.y ?
if i good see, the __generic_file_splice_read bring out to 2.6.22 ..
http://repo.or.cz/w/linux-2.6.22.y-op-patches.git
http://repo.or.cz/w/linux-2.6.22.y-op.git
On 4/4/08, Jens Axboe <jens.axboe@oracle.com> wrote:
> On Thu, Apr 03 2008, Hugh Dickins wrote:
> > The loop block driver is careful to mask __GFP_IO|__GFP_FS out of its
> > mapping_gfp_mask, to avoid hangs under memory pressure. But nowadays
> > it uses splice, usually going through __generic_file_splice_read. That
> > must use mapping_gfp_mask instead of GFP_KERNEL to avoid those hangs.
> >
> > Signed-off-by: Hugh Dickins <hugh@veritas.com>
> > ---
> > Ought to go into 2.6.25. For 2.6.23 and 2.6.24 stable? Well, I've
> > not actually seen this hang on any of these, though presumably it's
> > lurking there. Where I did see it, and test the fix, was 2.6.25-rc5-mm1:
> > whose SLUB had a disturbing predilection (since corrected) for order-4
> > allocations, even when allocating radix tree nodes.
>
> Thanks Hugh, definitely correct! I see it's already merged, so all is
> well.
>
> --
> Jens Axboe
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Thanks,
Oliver
next prev parent reply other threads:[~2008-04-04 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 22:35 Hugh Dickins
2008-04-04 11:46 ` Jens Axboe
2008-04-04 20:54 ` Oliver Pinter [this message]
2008-04-05 7:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6101e8c40804041354g2b065078i997e63cf03e576f0@mail.gmail.com \
--to=oliver.pntr@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®