From: "Oliver Pinter" <oliver.pntr@gmail.com>
To: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [2.6.24] [Q] x86: clear DF before calling signal handler II.
Date: Sat, 10 May 2008 22:33:09 +0200 [thread overview]
Message-ID: <6101e8c40805101333l582aecebr3dd49d5d30f9efc@mail.gmail.com> (raw)
Hi LKML!
Im mainline e40cd10ccff3d9fbffd57b93780bee4b7b9bff51 commit
( x86: clear DF before calling signal handler ) changed the ~TF_MASK and
~X86_EFLAGS_TF to ~(~X86_EFLAGS_TF | ~X86_EFLAGS_DF).
include/asm-x86/signal.h:
-------------------------->
248 #define ptrace_signal_deliver(regs, cookie) \
249 do { \
250 if (current->ptrace & PT_DTRACE) { \
251 current->ptrace &= ~PT_DTRACE; \
252 (regs)->eflags &= ~TF_MASK; \ <-----------
253 } \
254 } while (0)
<-------------------------
Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
the question:
in this file the change is unnecessary or forgotted?
NO COMPILE TESTED!
---
diff --git a/include/asm-x86/signal.h b/include/asm-x86/signal.h
index 987a422..71effa1 100644
--- a/include/asm-x86/signal.h
+++ b/include/asm-x86/signal.h
@@ -249,7 +249,7 @@ struct pt_regs;
do { \
if (current->ptrace & PT_DTRACE) { \
current->ptrace &= ~PT_DTRACE; \
- (regs)->eflags &= ~TF_MASK; \
+ (regs)->eflags &= ~(TF_MASK | X86_EFLAGS_DF); \
} \
} while (0)
--
Thanks,
Oliver
reply other threads:[~2008-05-10 20:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6101e8c40805101333l582aecebr3dd49d5d30f9efc@mail.gmail.com \
--to=oliver.pntr@gmail.com \
--cc=aurelien@aurel32.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®