From: "Oliver Pinter" <oliver.pntr@gmail.com>
To: "Willy Tarreau" <w@1wt.eu>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Abdel Benamrouche" <draconux@gmail.com>,
stable@kernel.org, jens.axboe@oracle.com,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC, 2.6.26.2-rc1] fs/partition/check.c: fix return value warning
Date: Sat, 2 Aug 2008 22:09:29 +0200 [thread overview]
Message-ID: <6101e8c40808021309r7de3cd31r11eb707b14c92fc4@mail.gmail.com> (raw)
In-Reply-To: <20080802200448.GH615@1wt.eu>
Willy, this good to know ...
and I think, this patch fixed a small leak:
+
+out2:
+ device_del(&p->dev);
+out1:
+ put_device(&p->dev);
+ free_part_stats(p);
+out0:
+ kfree(p);
+ return err;
On 8/2/08, Willy Tarreau <w@1wt.eu> wrote:
> On Sat, Aug 02, 2008 at 12:56:10PM -0700, Linus Torvalds wrote:
>> Please don't just send patches to the stable team because they "look
>> fine". They should be real bugs, with real consequences. And no, a
>> compiler warning is not a real consequence.
>
> BTW, before Oliver does the mistake, I'd suggest never forwarding
> network patches to stable either as Davem already maintains his
> own -stable queue ;-)
>
> Willy
>
>
--
Thanks,
Oliver
next prev parent reply other threads:[~2008-08-02 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 20:02 Oliver Pinter
2008-08-02 19:56 ` Linus Torvalds
2008-08-02 20:04 ` Willy Tarreau
2008-08-02 20:09 ` Oliver Pinter [this message]
2008-08-03 11:12 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6101e8c40808021309r7de3cd31r11eb707b14c92fc4@mail.gmail.com \
--to=oliver.pntr@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=draconux@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®