From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77FFA3ED3CF; Tue, 9 Jun 2026 08:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780993053; cv=none; b=QmmOpmLuRilU+QWvQpjtWtt5fESB5fNvWwuk/t0S/em4aENfJfBfOIMbYN8AL4f4ltNksj0+vRMxsvb5O/r1EnTHqM+fEZOfYxGCJWcw+1c3ngtOSOeLVJPHjI3i3bBXjHz/YJ3rra9tqi271vMHHQ/GBlp1OqFeKQvtV6xkDXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780993053; c=relaxed/simple; bh=Hey1LQAXuZmCG19jslP+c9ud5xanXTUfnmWwHzTFagY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GPUypD5+aiqi131pplzTrDzKFvEmoGH93EV8b1erjmxuYQKEVS949DIGzZtJ6AH/JKH3uVHkQa7UDmjUhY3XJnqU+qED/zLOyBf16jFy/Ybi7hb0SgIek4jrdMlKEaA4CapT5oeVHEJNTY1aT2EzDqIKBQIAIM/tmSXmOebKdzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UngoCtbc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UngoCtbc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 924541F00893; Tue, 9 Jun 2026 08:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780993050; bh=+o8NcVD44f+MtaBW4vVd+tz2TjDGupXfe3eEvJ2F4As=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=UngoCtbclOO4mbIiAWj93LITYtulX55/t8J1v3B/50f9sawhcJYKSJC42tEwlpwX1 nRwxf/TKCYvF42E9xLBygw7NdRACc6GeNvRg4rFybVuhc33/B2lTuK6FrqkGbqueQx bVNy4B9WrylEZFTlzRVYEB06Lafx40f6NAlbz4v3h9HLE8QxKMtXqakjzSKCiYFUMV 9UzXvFAlowTWx2YNGOu0g2+av/7OeFPbMMzntGRjbW02iCeojdngKMkA3qBjESWj1L 08NKESpleYfq4JQGz0+ZLoQVfm4mdsP781MdffFiG6g9HLB5ZDp2m3kFKb51aEjFe+ PuBSuJ7SDQrEg== Message-ID: <6103e3fc-4b27-47b5-aee9-8b481759eb65@kernel.org> Date: Tue, 9 Jun 2026 10:17:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/11] ASoC: dt-bindings: renesas,fsi: add support multiple clocks To: Bui Duc Phuc Cc: Kuninori Morimoto , Mark Brown , Geert Uytterhoeven , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260609013107.5995-1-phucduc.bui@gmail.com> <20260609013107.5995-2-phucduc.bui@gmail.com> <20260609-nimble-guillemot-of-karma-bef5f1@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/06/2026 10:11, Bui Duc Phuc wrote: > Hi Krzysztof, > > Thank you for your reviews. > >>> + properties: >>> + clock-names: >>> + minItems: 2 >>> + uniqueItems: true >> >> You don't need this, it's by default. >> > > Could you clarify which part you are referring to? > Are you referring to the "uniqueItems: true" property or another > constraint in this block? The uniqueItems should not be needed. > > >>> + items: >>> + - const: fck >>> + - const: spu >>> + - enum: [icka, ickb, diva, divb, xcka, xckb] >>> + - enum: [icka, ickb, diva, divb, xcka, xckb] >>> + - enum: [icka, ickb, diva, divb, xcka, xckb] >>> + - enum: [icka, ickb, diva, divb, xcka, xckb] >>> + - enum: [icka, ickb, diva, divb, xcka, xckb] >>> + - enum: [icka, ickb, diva, divb, xcka, xckb] >> >> Are all optional in the board design? I cannot find answers to that in >> commit msg, but it is important - you need to explain WHY you are doing >> this and WHY such different way. >> > > For r8a7740, "fck" and "spu" are required. The SPU clock must be enabled > to access the FSI registers because the FSI block is located behind the > SPU bus. > The remaining clocks (icka/b, diva/b and xcka/b) are not always required. > Their presence depends on the clock topology used by each FSI port. > In the previous discussion I described the supported clock configurations: > https://lore.kernel.org/all/CAABR9nEhOTz1-0NmCMTbz=-+782Pto0yovSQhBXrXqhLwMg80Q@mail.gmail.com/ This commit must stand on its own, thus here you must explain that. > The hardware supports several valid configurations, for example: > - FSIA/FSIB slave: only fck and spu are needed. > - FSI master using an internal clock: ickx and divx are used. > - FSI master using an external clock: ickx and xckx are used. > > Therefore, while fck and spu are mandatory on r8a7740, the other clocks > depend on the selected master/slave configuration and clock source, so > not all of them are expected to be present in every DT. Explain that in the commit msg and be explicit that all these further clocks are optional. Best regards, Krzysztof