From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EFD01C3C05 for ; Wed, 22 Jan 2025 07:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737530305; cv=none; b=jCzP351zQFKjj15KyOrVsuX8we4VyfhEo+icX5rDOUR6NlIH3N8hjBkgbVy3VqhvCe8Zx0y5GExZmvKvoy/ZMtfrH0ZDCaPxBnehRif5zdiZyr6avkeVczLIeaIydQBOXKDfYBY3DUVI4t0KLAw34QH4sb7eLTQ3NreP/701vWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737530305; c=relaxed/simple; bh=C7yLn9wmLYa6MNBHLQElQWwf14nTWYSZ3JDo51FkLqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VqAgKEjFTAA41PK2lWYy3gmK5vtBhLI/pgNqH280c9BcQBIJNuTClm6en9MvZ+jDc9jFiiMBFvisVUCSefGm4tJnbaWgiR6lsfQ+/AmhKbE1XkY7rXvW9F3CBgZ6QTz5OtsPqv9lH9uVCfvTzvROp/v7I03B4g87TCMjKoNGhuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hg+yR3bN; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hg+yR3bN" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-436281c8a38so47283645e9.3 for ; Tue, 21 Jan 2025 23:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737530302; x=1738135102; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZZHWWlJ7YF1iaeXHOnx4VlnIczYN3QFj1IHnYuWVAp0=; b=hg+yR3bNxw1oSZPN9A5fQApTxXWBxogL7FygmDlFo8TDjSzsUjs0yYinKDN+EV2oyd C+fCh5sgrAc+PsTSrtRFoC+7d8gC0RbKtMT19evcFfAwtmSYYSJxGd5DHwaOAiIhpsr2 WVKirw5HQhNe6bXJ4pXCCinduAifg9fGUUal+qBSKVKF2wKfkHoG2+41UA9f2sKRm1RV dOHRKL9GZOeuooEbm+C09ij7WnV/8H6WA76EgOV10Pbevv3j1USIfapU3DLcRegbrQkM WigybvVsPJxOJ+qs1ZAwu22Sa925ACqLrbtm2dJZ9XU071dAGdBL4cqbaTYxZ5At3nzU DKhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737530302; x=1738135102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZZHWWlJ7YF1iaeXHOnx4VlnIczYN3QFj1IHnYuWVAp0=; b=dtw+aK2b1F/vJb3bnKsR2fzi7Z3EUco/r5jwye062AugTBo4cN3t/5/1FsnQ5Swr9p GeJu8psV0/ThiPm0hSgKBM4q5KmIAwLv3NGl5cgzDkYmIMzbmAFTgqdmDUqnPRec2E+w BfSZLQ/16IrBwujWotgKn8U2XYcJc0orONi025/SN1K/RGjWC9EiicYcDYvbO6+E2OFo pWgYu6eaBENRCafoR3ror02zxQdBiE338AbOXUpBluXWNYkP2/+ZJq4765IQUhpQ6EtW Lu0AAn82Lp3Y2iJm+sz/mcrPn0VPP75pXJifPgiuU/FCZMvXPXdj+WMw9ziR2lczIITB XcAw== X-Forwarded-Encrypted: i=1; AJvYcCVn2SvLA4HxRQccNoqLoOLODGyctMyWGT7InaZQfFP1flWfvOeb06taLK69BRBbjF9IDKl7zQ3Cjd2/DFI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp0uf6lmK8c9kbEoPc0EPSfHRJ5WhUBDsMftvHIBeJrb3GmXSe i0ZnxnfQwtdYaUSQp40E5oW87mlIAbBGMCChbdkMjAYKm4lTg0r2BRvFmR68L2Y= X-Gm-Gg: ASbGncuRDIMlUQLMemIxdLQP/iDwaHLyWfmUs9OiMpkA2wbxtQ/Vnq2P5KNivI5REQ8 Gyif3f0rC77dY2HGcBx9IhZWA9SSTkiYZ/E1JfTP4sFzIOKghST7dj2sAai3ywuYcsZYduJDFkR 27tAl/ASMNpvR9S3DZhdUg74AK84GQ+oKblOS82vH22FySb3ODsDQPiHBmCEoAEWK3NhX4bbcBX Vs6fqZqgJ6p5GPs0rBBnwQh3RvcoIn+4qFL/CdHjW8jGRyqOmsyacrBPmVNxytfBni81q44qns= X-Google-Smtp-Source: AGHT+IHV0Im413NnK9j4Rv1bPwrEAwzM4I+VpQhnifh4EDggNcrGtQejJ3/93F7/BEivIbWCx93eHA== X-Received: by 2002:a05:6000:1a85:b0:38b:ef22:d8c3 with SMTP id ffacd0b85a97d-38bf57a69b4mr19738929f8f.35.1737530301991; Tue, 21 Jan 2025 23:18:21 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf322b4ecsm15620249f8f.58.2025.01.21.23.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 23:18:21 -0800 (PST) Date: Wed, 22 Jan 2025 10:18:13 +0300 From: Dan Carpenter To: Baojun Xu Cc: Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi() Message-ID: <6103e81a-13bf-4eab-89af-f6830c14e14c@stanley.mountain> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Propagate the error code from devm_gpiod_get_index_optional(). The current code returns success. Fixes: bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver") Signed-off-by: Dan Carpenter --- sound/pci/hda/tas2781_hda_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/tas2781_hda_spi.c b/sound/pci/hda/tas2781_hda_spi.c index 02794fd6003d..eba9c3a3b944 100644 --- a/sound/pci/hda/tas2781_hda_spi.c +++ b/sound/pci/hda/tas2781_hda_spi.c @@ -447,6 +447,7 @@ static int tas2781_read_acpi(struct tas2781_hda *tas_hda, p->reset = devm_gpiod_get_index_optional(physdev, "reset", p->index, GPIOD_OUT_LOW); if (IS_ERR(p->reset)) { + ret = PTR_ERR(p->reset); dev_err_probe(p->dev, ret, "Failed on reset GPIO\n"); goto err; } -- 2.45.2