From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD2854774 for ; Mon, 2 Mar 2026 07:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772437588; cv=none; b=TFT+KgJDN8z/VLZUPCJQ1lXzZ91xxHrxd19jok08MM+poiYuCUPZmSXZTjlJfQUqdea2Hh+rFhjgAxrasJwfIfxFi5HsUVezq4mvh7p/J/YTFrjSAUVipbhlACgid/k8bQJiyWWE4ROEhYj5NqtVi2MKQzGtwplhvuddcPRZdRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772437588; c=relaxed/simple; bh=KJkbwrixlbBS64cwF/laTOXS0DGlk2zP/50Uxq4G70w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k+WP8KRVwOY2rQEumie5sXCB64LOiLJpyIf9lAYGxfaVOvZ7lOM+zp2D7xjsYemIooQ60wY9+HFVzEPIKcyvENBX5yK4hqec64KWMKJ7K3pSTtafZf6z7dhS2mXYf8H4irr2WXHboy0xr++qPp+aCCHdfdbrxn7xsDPwCF2B6to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qHgOtMRM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=tJeUGZTh; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qHgOtMRM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=tJeUGZTh; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qHgOtMRM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="tJeUGZTh"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qHgOtMRM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="tJeUGZTh" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0B9465BD20; Mon, 2 Mar 2026 07:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772437585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ScpnSREjJ9Jo+dNweg43Qwh9vC7oxmah5RXubrqr9eY=; b=qHgOtMRMRA2Kfjwya5OHwQmKgXd/MsxPsoP/XJC+/JmZOg2YPLTEV0N/lGEdtcbq1zVIsZ 2nXxZ6poNFcM9qAtzAK2Pd0U10oSzaVQx3auAjSQsKeWIPlF1/zUrQN5h8RBgRBu14sUEj SH+XO8ctg5VRL4+KGQw8aagTr0SWWdE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772437585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ScpnSREjJ9Jo+dNweg43Qwh9vC7oxmah5RXubrqr9eY=; b=tJeUGZThh141dbjj5ZQXRBhCRQ0QOBk5cVKvR86vUnOBsTMjJh0QLf2xydsDOEKdbm/6fa DiNG+lVhC8M4VwBw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qHgOtMRM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tJeUGZTh DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772437585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ScpnSREjJ9Jo+dNweg43Qwh9vC7oxmah5RXubrqr9eY=; b=qHgOtMRMRA2Kfjwya5OHwQmKgXd/MsxPsoP/XJC+/JmZOg2YPLTEV0N/lGEdtcbq1zVIsZ 2nXxZ6poNFcM9qAtzAK2Pd0U10oSzaVQx3auAjSQsKeWIPlF1/zUrQN5h8RBgRBu14sUEj SH+XO8ctg5VRL4+KGQw8aagTr0SWWdE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772437585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ScpnSREjJ9Jo+dNweg43Qwh9vC7oxmah5RXubrqr9eY=; b=tJeUGZThh141dbjj5ZQXRBhCRQ0QOBk5cVKvR86vUnOBsTMjJh0QLf2xydsDOEKdbm/6fa DiNG+lVhC8M4VwBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9943E3EA69; Mon, 2 Mar 2026 07:46:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id l9uCI1BApWnhBgAAD6G6ig (envelope-from ); Mon, 02 Mar 2026 07:46:24 +0000 Message-ID: <6106c6c4-c674-41e9-8dfa-cef630b55a4e@suse.de> Date: Mon, 2 Mar 2026 08:46:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/sitronix/st7586: fix bad pixel data due to byte swap To: David Lechner , David Lechner , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Dmitry Baryshkov , Javier Martinez Canillas Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[baylibre.com,lechnology.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,tronnes.org,redhat.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 0B9465BD20 cc Javier Am 01.03.26 um 05:30 schrieb David Lechner: > Correctly set dbi->write_memory_bpw for the ST7586 driver. This driver > is for a monochrome display that has an unusual data format, so the > default value set in mipi_dbi_spi_init() is not correct simply because > this controller is non-standard. > > Previously, we were using dbi->swap_bytes to make the same sort of > workaround, but it was removed in the same commit that added > dbi->write_memory_bpw, so we need to use the latter now to have the > correct behavior. > > This fixes every 3 columns of pixels being swapped on the display. There > are 3 pixels per byte, so the byte swap caused this effect. > > Fixes: df3fb27a74a4 ("drm/mipi-dbi: Make bits per word configurable for pixel transfers") > Signed-off-by: David Lechner > --- > drivers/gpu/drm/sitronix/st7586.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/sitronix/st7586.c b/drivers/gpu/drm/sitronix/st7586.c > index b57ebf37a664..16b6b4e368af 100644 > --- a/drivers/gpu/drm/sitronix/st7586.c > +++ b/drivers/gpu/drm/sitronix/st7586.c > @@ -347,6 +347,12 @@ static int st7586_probe(struct spi_device *spi) > if (ret) > return ret; > > + /* > + * Override value set by mipi_dbi_spi_init(). This driver is a bit > + * non-standard, so best to set it explicitly here. > + */ > + dbi->write_memory_bpw = 8; > + > /* Cannot read from this controller via SPI */ > dbi->read_commands = NULL; > > @@ -356,15 +362,6 @@ static int st7586_probe(struct spi_device *spi) > if (ret) > return ret; > > - /* > - * we are using 8-bit data, so we are not actually swapping anything, > - * but setting mipi->swap_bytes makes mipi_dbi_typec3_command() do the > - * right thing and not use 16-bit transfers (which results in swapped > - * bytes on little-endian systems and causes out of order data to be > - * sent to the display). > - */ > - dbi->swap_bytes = true; > - > drm_mode_config_reset(drm); > > ret = drm_dev_register(drm, 0); > > --- > base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 > change-id: 20260228-drm-mipi-dbi-fix-st7586-byte-swap-f0d03c5f800c > > Best regards, -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)