From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA65C433ED for ; Mon, 12 Apr 2021 12:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9657561263 for ; Mon, 12 Apr 2021 12:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241265AbhDLMsw (ORCPT ); Mon, 12 Apr 2021 08:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240790AbhDLMst (ORCPT ); Mon, 12 Apr 2021 08:48:49 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FF05C061574 for ; Mon, 12 Apr 2021 05:48:28 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id f12so12846285wro.0 for ; Mon, 12 Apr 2021 05:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Zzn8PLES8svA7U4ivqAg78EhvER0rJvp6i6dRwiQrRU=; b=0vF+qUbUyHuLYS0tOOZ2JC0sSS5+/Pg6RfJqDnCalNLMowGquE9SnNrWV3F9oMZPnx 22l7O36faYtp0YsQI9AWg1Flud4AeAPR3J0guqRfUWqNCd6ReTkvp+qOUM+AuA+E2Lde +cWmxL+4hXGMApCJwp4EXBuNMaApciVcycVoG6qoBVB/NgWg6ln0klUfqTUaOHRpub3u Bg2JFXQYQYJ9NQJDce+Pq0OZgzgZoHnPjZLxf22VxnOnipYc99owUVbti+UkDOdEGxbX BdxGAPd2LKgh4T3n9BRQkKdM6/N2vV9F2lKWG4GIbN+D9wTdveLptyHcIv2kLceV3XKO HJZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Zzn8PLES8svA7U4ivqAg78EhvER0rJvp6i6dRwiQrRU=; b=Upu7KyG4BVJT7HTKextzvPY3+aq1zUvVd0AH0sUlPeY6YtCnEBSMAsyjq3/d04yGom REYjJ56PDXqA3KlM0iK+/Jxy1Ne0dAqcS2q8VtzhU7Rt6Cb5FfHqQCQ0TxWTdTOa+Gv0 nB/lCoXnE/4rNclWbbLejf29mojJtVIfjpPmTB3QO3T+tnIwZJnBDiu2nb4jazT1DcJA /9AATzDVem3brwpg0tE6FU6iMJLMXyCkvNydwC7VEyK9YsWdI3mH0WQDaYR3FlFlFQ6r 421dnKyEIgknGcYL008n4eW736iaOQZ+ivHGLckBfXqqeKuYIysRfVTAdB9FiadetdG8 RwMg== X-Gm-Message-State: AOAM530HxN5Xzw4AqQffqvfQzO43pidLs8RCN+qMSx72n17IeaX2QDsq 5zG5YI1jFdzqsFzAMfc/xADGeg== X-Google-Smtp-Source: ABdhPJyXby6kkuJjgYWXL1ZMazbjd2Zw/pmMGFu02jqpqnXMu6wbepEENYIPpUq6GqhgcJPIrhsVSw== X-Received: by 2002:adf:f504:: with SMTP id q4mr15535673wro.304.1618231707158; Mon, 12 Apr 2021 05:48:27 -0700 (PDT) Received: from ?IPv6:2a01:e0a:90c:e290:4c21:b00e:ff79:bf20? ([2a01:e0a:90c:e290:4c21:b00e:ff79:bf20]) by smtp.gmail.com with ESMTPSA id j30sm17868537wrj.62.2021.04.12.05.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 05:48:26 -0700 (PDT) Subject: Re: [PATCH v2] staging: media: meson: vdec: declare u32 as const and static const To: Mitali Borkar , Hans Verkuil , mchehab@kernel.org, gregkh@linuxfoundation.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in, linux-amlogic@lists.infradead.org References: <88d04746-717d-5a7a-7ea7-67cf6c95aba9@xs4all.nl> From: Neil Armstrong Organization: Baylibre Message-ID: <6107204d-f1a3-0888-ef3b-88520d786fa1@baylibre.com> Date: Mon, 12 Apr 2021 14:48:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2021 14:45, Mitali Borkar wrote: > On Mon, Apr 12, 2021 at 11:17:22AM +0200, Hans Verkuil wrote: >> On 10/04/2021 21:59, Mitali Borkar wrote: >>> Declared 32 bit unsigned int as static constant inside a function and >>> replaced u32[] {x,y} as canvas1, canvas2 in codec_mpeg12.c >>> This indicates the value of canvas indexes will remain constant throughout execution. >>> Replaced u32 reg_base and u32 reg_name with const u32 reg_base and const >>> u32 reg_name as it will contain data/registry bases to write static >>> const indexes declared above and will keep track of of contiguos >>> registers after each reg_base. >>> This makes code look better, neater. It improves readability. >>> >>> Signed-off-by: Mitali Borkar >>> --- >>> drivers/staging/media/meson/vdec/codec_mpeg12.c | 5 +++-- >> >> Also change drivers/staging/media/meson/vdec/codec_h264.c. >> >> It's a nice improvement, so let's do this for both callers of amvdec_set_canvases(). >> > I have done chnages in codec_h264.c Now, should I send that as new > patch? Yes please, Neil > >> Regards, >> >> Hans >> >>> drivers/staging/media/meson/vdec/vdec_helpers.c | 2 +- >>> drivers/staging/media/meson/vdec/vdec_helpers.h | 2 +- >>> 3 files changed, 5 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c b/drivers/staging/media/meson/vdec/codec_mpeg12.c >>> index 21e93a13356c..861d8584f22f 100644 >>> --- a/drivers/staging/media/meson/vdec/codec_mpeg12.c >>> +++ b/drivers/staging/media/meson/vdec/codec_mpeg12.c >>> @@ -65,6 +65,8 @@ static int codec_mpeg12_start(struct amvdec_session *sess) >>> struct amvdec_core *core = sess->core; >>> struct codec_mpeg12 *mpeg12; >>> int ret; >>> + static const u32 canvas1[] = { AV_SCRATCH_0, 0 }; >>> + static const u32 canvas2[] = { 8, 0 } >>> >>> mpeg12 = kzalloc(sizeof(*mpeg12), GFP_KERNEL); >>> if (!mpeg12) >>> @@ -80,8 +82,7 @@ static int codec_mpeg12_start(struct amvdec_session *sess) >>> goto free_mpeg12; >>> } >>> >>> - ret = amvdec_set_canvases(sess, (u32[]){ AV_SCRATCH_0, 0 }, >>> - (u32[]){ 8, 0 }); >>> + ret = amvdec_set_canvases(sess, canvas1, canvas2); >>> if (ret) >>> goto free_workspace; >>> >>> diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.c b/drivers/staging/media/meson/vdec/vdec_helpers.c >>> index 7f07a9175815..df5c27266c44 100644 >>> --- a/drivers/staging/media/meson/vdec/vdec_helpers.c >>> +++ b/drivers/staging/media/meson/vdec/vdec_helpers.c >>> @@ -177,7 +177,7 @@ static int set_canvas_nv12m(struct amvdec_session *sess, >>> } >>> >>> int amvdec_set_canvases(struct amvdec_session *sess, >>> - u32 reg_base[], u32 reg_num[]) >>> + const u32 reg_base[], const u32 reg_num[]) >>> { >>> struct v4l2_m2m_buffer *buf; >>> u32 pixfmt = sess->pixfmt_cap; >>> diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.h b/drivers/staging/media/meson/vdec/vdec_helpers.h >>> index cfaed52ab526..ace8897c34fe 100644 >>> --- a/drivers/staging/media/meson/vdec/vdec_helpers.h >>> +++ b/drivers/staging/media/meson/vdec/vdec_helpers.h >>> @@ -17,7 +17,7 @@ >>> * @reg_num: number of contiguous registers after each reg_base (including it) >>> */ >>> int amvdec_set_canvases(struct amvdec_session *sess, >>> - u32 reg_base[], u32 reg_num[]); >>> + const u32 reg_base[], const u32 reg_num[]); >>> >>> /* Helpers to read/write to the various IPs (DOS, PARSER) */ >>> u32 amvdec_read_dos(struct amvdec_core *core, u32 reg); >>> >>