From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753392AbbKWT0m (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Nov 2015 14:26:42 -0500
Received: from mout.kundenserver.de ([212.227.17.10]:65003 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753070AbbKWT0k (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Nov 2015 14:26:40 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Andreas Dannenberg <dannenberg@ti.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module
Date: Mon, 23 Nov 2015 20:26:04 +0100
Message-ID: <6108951.tAkyXlqtjc@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <5653485E.70005@ti.com>
References: <1448297631-8916-1-git-send-email-afd@ti.com> <3809374.hKy9fQ2ldj@wuerfel> <5653485E.70005@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:aFHRmoh4jDG2rVIUng1oGOustUfDmwrGAqGXFtMIa8FJ2C30ket
 mF9ivm7mTbcBCWWVKsMmaxhsqiEQIz08Zrsl1tcijxUFLZWI42j1RYEW1R4u/3hoN+SpaQA
 HJNRhRcBX+BjOzb9SwyGZY667EkwoMHInzQWom4vkv+jJhTxpjYKxJSxqlqUzZ4y8bZ5XfP
 5+q2BinlYhAEoFggdbuiQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:mSVzb/xP4YI=:9NfENWOnbeMcmDYR8rQlGW
 PMRq8gPyMlhVwJH4ZPmMoH874bABFfuu20K+XB46IY5OunnQPKxYMC+MSVGDlyReA9kWHx6PO
 bKaw4iObZYl4kX3p/natLrQ9HpeykUhJf9x1G05WR1XMI3NzRTq9kPFQYniiokMxKOeBn3d8+
 FGnbpGDV0cfoSd7Cvw/tVuZehyaQ37HVt6RNNLdQ28vb/TdbtwqIf4WRPHKLBxjjsjX2PUeFk
 kXK3TOaBU9PA6DbLnqRxQphFKc6fB+KXjteY647tL9DBXZXoxaofVy2eTzONXGJ8qYlCDD0Yn
 RXCA5izZKMwKBHJmnH5LfGfJMxMlEoeOPXzDJhnMvU3IjU1tTrB++Fse4KB1gav+zup8GBAzB
 jdIpkHQGHolVEEZfKXa1e9WzHNluhbtYt4U6c4LZ4rwlGHC0vJjgA1MNNkCg9Jm4sU2Rm/1f2
 kf9mDEnBGC+R0NtIL8Es8MyeWIW5lpBz6Y19pZ6wv37mYR9PPr3JJmuB2y50q+8pAs9363aYt
 V7oPrD9G3boGgbZ7XkAL7AkEtNrBOsXKaIDv51md3Nd17B6UgxklwRYafAtNIqQJU/5AjxvOA
 3uQPWe8bjoVUSruz092dXx491qzkA/T6BEVlS+17iAu08V60Fjjnj2gTso0tbQRxHQbZsHDrm
 3t1AGeXRkqRHgkfPBIWSzru/XTEUDUhSldNgqxDo7r8BtzbO0sRdHsZ8r/AzmyJeb67bKuBWy
 mo/SWksUKUUU3LLG
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 23 November 2015 11:09:50 Andrew F. Davis wrote:
> On 11/23/2015 10:57 AM, Arnd Bergmann wrote:
> > On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote:
> >> Separate out I2C functionality into a module. This fixes several small
> >> issues and simplifies the driver initialization.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >
> > That looks good to me overall, it should help with the randconfig
> > warnings I've been seeing and makes the driver structured more logically.
> >
> > The one part I wonder about is whether the platform_driver portion
> > should also be split out into a separate module in the same way.
> >
> I think it should, I'm just waiting until I can find some time to
> bring up regmap for 1wire, then I can really clean things up and
> move the platform stuff (which is really the 1wire interface) out
> more cleanly, all I'll need to do then is just pass a regmap handle
> to the core from the interface modules.
> 
> But that's all a project for another day 

Ok, sounds good.

	Arnd