From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86856C64EC4 for ; Sat, 18 Feb 2023 10:16:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbjBRKQc (ORCPT ); Sat, 18 Feb 2023 05:16:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjBRKQa (ORCPT ); Sat, 18 Feb 2023 05:16:30 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A3039295 for ; Sat, 18 Feb 2023 02:16:28 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id ec30so1724924edb.10 for ; Sat, 18 Feb 2023 02:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=isL683qk+zwUEc0fdI1TRbW50SVZApf+Izx8IU5t3v0=; b=XfNmEX3U5b2bz9p/4Acby5zZSdHmyuZiC9ZflVTG9zuCSZ6t2++DOdQdm2MJ19SZ9S 9MdULBlDxnVCX090immUY2DhglxwvP0BUPLQAoKUaiKmNLMir3tokZESbEiBeXnLck06 p5ftKiBxux9QC/LeMUGeAU1DhFqQrd7Z1ShrKDj5/ZIb+7Dhs16wNyhPuGAJM1EnhFHK FFMa0CiUhqtFQdmDmHQBDhGAuL1vMhPqXxN3+TVKuiwrrhhbqgO1A2JQwQS4sTEC8Prk FRimIeOx4H0fvKXGwGLBX8qAUBNp2XJfDkBUnV3Qw7C5dvduT11DONqx5FmvfhsrULvm /tDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=isL683qk+zwUEc0fdI1TRbW50SVZApf+Izx8IU5t3v0=; b=DXSlHG3kOvM+Uoc2wcOJ9FB03NDaHHzZlnCbHSSvaK1RfI7ej9pLeQ+Lp2/3OJr+e6 9sRw3CItwuW/dNrmFC0WLXGD4y45WM8/N2FILKcKykvMyvXzW0vIxZORiRRdpdy0N5WX LIXlo7Pl1T4VQF5kO9D9U+JEoDP4b+NR30lfNiw0xyY+Hd+7AG08RNIyFI5VKCjCPwU6 7nfPSbsLFeJ/ybqc9oO9SQiBQIjkMsEA7nTJbndeUoEKc3IhsziW/kLfPx5oRHBZUEik CHO1Uy3b9ugiWrEAGTQXrMlpwE0zNmsqUetmVolVcTQBw+CuIz44KWLvUuW7Q4i7xI7B gBLQ== X-Gm-Message-State: AO0yUKXW9Euosewo6Y0AK1mMUAtctITmq0HQIsSvQ0PH919zAc6gpeR4 1NkK5pATP3EdyIlmqDWtJQIqrcLvAYhiq0HH X-Google-Smtp-Source: AK7set8F5+d4ybBx7pl4yewkqkHJpbFAsLcHzIGt4byA3KBeymPai/DkcZidLH13N/hJczuU5rqiqA== X-Received: by 2002:a17:906:2655:b0:8af:5752:26e4 with SMTP id i21-20020a170906265500b008af575226e4mr1059536ejc.68.1676715387002; Sat, 18 Feb 2023 02:16:27 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j11-20020a170906474b00b0088f8a61eb48sm3208173ejs.154.2023.02.18.02.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 02:16:26 -0800 (PST) Message-ID: <610e8b6a-8e1c-753e-d2c9-0056a7804f9b@linaro.org> Date: Sat, 18 Feb 2023 11:16:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 3/3] dt-bindings: misc: servo-pwm: Add new bindings for servo-pwm Content-Language: en-US To: Angelo Compagnucci Cc: Angelo Compagnucci , Rob Herring , Krzysztof Kozlowski , "open list:GENERIC PWM SERVO DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230217161038.3130053-1-angelo@amarulasolutions.com> <20230217161038.3130053-3-angelo@amarulasolutions.com> From: Krzysztof Kozlowski In-Reply-To: <20230217161038.3130053-3-angelo@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/2023 17:10, Angelo Compagnucci wrote: > This binding describes the binding for controlling servo motors through > pwm. > > Signed-off-by: Angelo Compagnucci > --- > v2: > * Converted old txt to yaml > v3: > * Fixed errors rised by make dt_binding_check Still fails the tests. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > > .../devicetree/bindings/misc/servo-pwm.yaml | 57 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/servo-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/misc/servo-pwm.yaml b/Documentation/devicetree/bindings/misc/servo-pwm.yaml > new file mode 100644 > index 000000000000..73e81b939daf > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/servo-pwm.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/servo-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Servo motor connected to PWM > + > +maintainers: > + - Angelo Compagnucci > + > +description: > + Each servo is represented as a servo-pwm device. > + The 20ms period is the accepted standard and so most of the motors > + support it, while the positioning min/max duty cycle or the motor > + degrees aperture vary lot between manufacturers. > + The most common type of servo (SG90) has 180 degrees of movement > + and moves between 0.5ms and 2.5ms duty cycle. > + > +properties: > + compatible: > + const: servo-pwm > + > + pwms: > + maxItems: 1 > + > + pwm-names: true You got later feedback from Rob for v2, so this needs changes. > + > + degrees: > + description: > + How many degrees the motor can move. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + duty-min: > + description: > + Duty cycle for position the motor at 0 degrees. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + duty-max: > + description: > + Duty cycle for positioning the motor at "degrees" angle. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +additionalProperties: false > + > +examples: > + - | > + Drop blank line. Krzysztof