From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF41B23A9B0 for ; Thu, 18 Dec 2025 13:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064992; cv=none; b=lBELpbqhe+wDsPwLbWDD41VoW5nDhu5+3k1i+FxCQzZMUnROA2oHVhIurLNMSwWLALjVtQGGjcGGcTrrl/yoGVgsSbUEgCEhk7n2o8037ZEi1W/1dhLK4whl/gmySKGU3PsHwQmtTHuIea7cSg64LO63d9HTwQptr72VIchgKVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064992; c=relaxed/simple; bh=EnK/e7n0jfeqHE0rDLdKfLzHElXnURxxkoLBhU7kCo8=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=tzYv3h7sUbxnFJJmOnSro6gspLq/7vIOL/V0UTYvR7zYGS3Y/ipHuSMfDQOvOkKGLsMBdNyKVqNNo+jv4eXSwUN37TvY3tSL+xy0DghPUsERuATj4th9+pKg4AaqhcO6Hr4dpkXg/qD1WIp6IEdlpfnaB/vtg7FEswbz84Mm7uI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O6igqzth; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O6igqzth" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766064990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=55MmONxQZjmCUfCxJczkWnRcFykYRDUdv6M6mibkb3w=; b=O6igqzthFu5TYiM4EycuBEOjDgkp3j+hGvZxmvOf9RVVb1W1sCjUNa1at8mtuuB5uMzD52 YDOhD3q4rY1GZ181IcCboqYk8fkVQANogkjGK8bMDOSU7J+dYDsOZYQVQvhaBiuy8bGyh1 OfrPHfsgtXA24GT6DcaxV6u/6lgAZYc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-jb7mSw0INWy30PEt2GpQtQ-1; Thu, 18 Dec 2025 08:36:28 -0500 X-MC-Unique: jb7mSw0INWy30PEt2GpQtQ-1 X-Mimecast-MFC-AGG-ID: jb7mSw0INWy30PEt2GpQtQ_1766064987 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 80AF11800245; Thu, 18 Dec 2025 13:36:26 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D7242180035A; Thu, 18 Dec 2025 13:36:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20251201225732.1520128-1-dhowells@redhat.com> <20251201225732.1520128-2-dhowells@redhat.com> To: Namjae Jeon Cc: dhowells@redhat.com, Steve French , Paulo Alcantara , Shyam Prasad N , Stefan Metzmacher , Tom Talpey , linux-cifs@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/9] cifs: Remove the RFC1002 header from smb_hdr Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <611043.1766064976.1@warthog.procyon.org.uk> Date: Thu, 18 Dec 2025 13:36:16 +0000 Message-ID: <611045.1766064976@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Namjae Jeon wrote: > Why did you only change smb client after changing smb_hdr structure in > smb/common? smb server also uses smb_hdr structure to handle smb1 negotiate > request. Apologies, but I was under the impression from Steve that ksmbd didn't support SMB1 and was never going to. Further, I'm pretty certain I have been building the server and it hasn't shown up any errors - and Steve hasn't mentioned any either. > Also, Why didn't you cc me on the patch that updates smb/common? You're not mentioned in the MAINTAINERS record for CIFS. I did, however, send it to the linux-cifs mailing list six times, though. David