From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161087AbcIWSV0 (ORCPT ); Fri, 23 Sep 2016 14:21:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035104AbcIWSVX (ORCPT ); Fri, 23 Sep 2016 14:21:23 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <9efafc3e-5f19-598c-ee0c-def748eeb78a@cogentembedded.com> References: <9efafc3e-5f19-598c-ee0c-def748eeb78a@cogentembedded.com> <147464371753.5090.1634919599283321856.stgit@warthog.procyon.org.uk> <147464377267.5090.12222734463447533990.stgit@warthog.procyon.org.uk> To: Sergei Shtylyov Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 08/15] rxrpc: Fix call timer MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6112.1474654880.1@warthog.procyon.org.uk> Date: Fri, 23 Sep 2016 19:21:20 +0100 Message-ID: <6113.1474654880@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 23 Sep 2016 18:21:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Shtylyov wrote: > > + if (call->timer.expires != t || !timer_pending(&call->timer)) { > > mod_timer(&call->timer, t); > > } > > CodingStyle: {} not needed now. See patch 11. David