From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/power: Don't make man pages executable
Date: Wed, 20 Dec 2017 00:48:12 +0100 [thread overview]
Message-ID: <61161aff-c427-0355-e147-9c55445c3184@intel.com> (raw)
In-Reply-To: <20171219195457.1601-1-labbott@redhat.com>
On 12/19/2017 8:54 PM, Laura Abbott wrote:
> rpm-lint flagged these as being executable:
>
> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz
>
> Fix this
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Please CC PM stuff to linux-pm (which makes it easier to handle).
> ---
> tools/power/x86/turbostat/Makefile | 2 +-
> tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
> index a9bc914a8fe8..2ab25aa38263 100644
> --- a/tools/power/x86/turbostat/Makefile
> +++ b/tools/power/x86/turbostat/Makefile
> @@ -25,4 +25,4 @@ install : turbostat
> install -d $(DESTDIR)$(PREFIX)/bin
> install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
> install -d $(DESTDIR)$(PREFIX)/share/man/man8
> - install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
> + install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
> index 2447b1bbaacf..f4534fb8b951 100644
> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
> install -d $(DESTDIR)$(PREFIX)/bin
> install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
> install -d $(DESTDIR)$(PREFIX)/share/man/man8
> - install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
> + install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>
Thanks,
Rafael
next prev parent reply other threads:[~2017-12-19 23:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 19:54 Laura Abbott
2017-12-19 23:48 ` Rafael J. Wysocki [this message]
2017-12-20 0:36 ` Laura Abbott
2017-12-20 1:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61161aff-c427-0355-e147-9c55445c3184@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=labbott@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome