From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755770AbcAMUqN (ORCPT ); Wed, 13 Jan 2016 15:46:13 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:59684 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbcAMUqJ (ORCPT ); Wed, 13 Jan 2016 15:46:09 -0500 From: Arnd Bergmann To: Andrew Morton Cc: mmarek@suse.com, Peter Chen , Randy Dunlap , Joern Engel , Prasad Joshi , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] logfs: clarify MTD dependency Date: Wed, 13 Jan 2016 21:45:05 +0100 Message-ID: <6116283.ubGS0D0e49@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160113123918.544497b48bf4c03591c75747@linux-foundation.org> References: <5776957.XLg438VUOx@wuerfel> <20160113123918.544497b48bf4c03591c75747@linux-foundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MtaZswwbQW9iTjKNqT3mKmK8dN00Unts+NZz0gDS64XnpHCCvVm gsbsw3lpbgydfE/+NEk0u0hMc/3dmQygJfin5Bp2PQr3olY82VV420zJN8Xn7ajXedLnXBj Kqls36eI9kiFjFOR3WC3HeRIBrQ5y+sa5XwaMOtIfkcuUeJJC9O+J8EKcFC2JwmXt1V8ULf QPNXK3WwPpzpwzuCCV3aA== X-UI-Out-Filterresults: notjunk:1;V01:K0:lcLNoRc58gQ=:ls32GVUg7a0wNw73CWeOj1 /F9uBGQmeC+OdrdenMyaQdzNWT0bChn5TUoZ6spUvfEU2wlHhnF8x8CYDEx04yopTS/pad8D1 XPrqMIfBXNor+iBQNPeOmXf8t7z9vS+6fzUnxjqwNacvd+cEaDenQT0p4md9mD7q/8GMWyAIE 9FJOj1WEIp/i6KdNEGgBe/SCV9a9h4FShHTmDXoNJfavEumbtAzDH/cgFU01vo0LRaaVoUHxA pyPkZV+rAajGdjQeTK0WZal44Or7REzu/1bstu0aojtYdSxgMKiDUa5I4EE8Nzjx4ZJPFTfHR nzx9Cpqj7tcMjWRMBnTh9X1iEbo3m6BhLADvp0dEdtdBgMcK35WQ8ZJb0+BErOiMqxSaX1oh6 ar1qCzalVJfZ/tO+ULlg+1yvRaTKoBUGwGdJwoYLS3TpDHEuw2VL/hWzn8A6zRheJ7JD42HT1 fpbhUhuDAuFlLH+NfYqWTBBi7rqG9UC1pwXv/deshk35BvnkNNWLqthh+BLYpAV0F4jE5PjTn xhsTn8hpO5ejAgw5d9/hw9K6mr7SWkFeKnc4WCDgi2PsA3T5ZbZUEYoZJs3e2W/CJ7Yo4mp5K bV1sBgxd/aadh0atHz7Qz2OiX+9S6dXqlCA7GIo2Akp1pdmU4UqxrceHoyvip0vB72ith0a52 Ufo6EXkZTpCQikUbVJIrUTA6s84nDOrF9SLHbWid0zVmityjg0Jsgfly3kGGp/hPw2zzWpeTi +EYZlZALuBOZniN2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 January 2016 12:39:18 Andrew Morton wrote: > > Randy's "logfs: fix logfs build errors and dependencies" is an > only-in-mm thing. So it would make sense to combine the two patches > into a single one and to give that an appropriate changelog. > > How does this look? (Primary author was chosen randomly) > > > From: Arnd Bergmann > Subject: logfs: fix logfs build errors and dependencies > > Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m: > > fs/built-in.o: In function `logfs_mount': > super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd' > fs/built-in.o: In function `logfs_get_sb_bdev': > (.text+0x93530): undefined reference to `logfs_get_sb_mtd' > > This patch avoids the error by changing the dependencies of > logfs in a way that we can no longer configure logfs as built-in > when the MTD core is a loadable module, while leaving the > dependency to require at least one of MTD or BLOCK to be > enabled. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Randy Dunlap > Cc: Michal Marek > Cc: Peter Chen > Cc: Randy Dunlap > Cc: Joern Engel > Cc: Prasad Joshi > Signed-off-by: Andrew Morton > Looks good, thanks! Arnd