From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6183C3792 for ; Wed, 26 Aug 2026 10:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787740168; cv=none; b=k8FjbljHg89YyeZo9dtMehUllkxXdkXmhENl++svM+S8MeMrnIbENT6YRZ8tuwb3mzYtZ0ciz3JrJAWkg8uZoXthJjOoUZljgtzmxntSI5kQ7BE/DnsYgYVb7P2Gk889Rt8Md+njYD/Ijcnt+JB4+TwX0x/JWpdKz89Okr85Fbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787740168; c=relaxed/simple; bh=CSyS2AAUx8IjH654HwNFW+tBkieMPajx0k9qQRZi2gY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HO16Gr+o6RdjKOA/VXPJm86oeBsSWRPJYRjOCGSNtSbcs5ygw5W/jOIWt5AN0Phu5nGBB6/zVz/upsPPCffBHz/0RnZIKrNMBj0WWnaDwu4KxncExNBsG7tXBnE3JkeX0+33Obf1qaMU5YXKTYKtT4VztrMnGW1urwerU1huI4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FgQYI4nj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VtbASEkY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FgQYI4nj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VtbASEkY" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QAGbxE121397 for ; Wed, 26 Aug 2026 10:29:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QveZLHZ1UA6LhKTB0pCtINjffhyivWeyncO8oEF8Ds8=; b=FgQYI4njldTAlU7d FCya7p0PQMO5pje5o+UmV1ROpUsw1rlmHFZyqZwX8+xJEES76Ulfazv7Ugjj1RRx o9pNueKprZtOaZ4MNDN5BS3aN7VkWjCot9XKdRDT+5bCxblRZpYjET4ibQAq03YS CF8QfOlgm6NIQ65GIX1jGr9EExxc+tuwxoBMW4r/RX6HfUKNOOO35dWEviwShehF sip93cLHQcBu9prCk09DUHIq5vcS0MDkImhiSQAOl92oTRg5VvQtqo2zLS6IIUkh pepbuOuA1a+EBviOWkj4DLnpP6BORYhc4/tt7HXG1hS4+WG4EWm+s/3EmeT5As+5 qBb+Ng== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9smx9avk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 10:29:25 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38ec0f510a9so2458169a91.2 for ; Wed, 26 Aug 2026 03:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787740165; x=1788344965; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QveZLHZ1UA6LhKTB0pCtINjffhyivWeyncO8oEF8Ds8=; b=VtbASEkYF8kmmTSybaQH2SSWu2KCnJqIimuFSzJe5+Fo2ocygEPMvWPSbMglOBtyPZ yA83uGHOSCY+kETe9r1J6sa13HequT8PBw5NrPCqKwnLuexyZY6/HQeMlF2iFsNQQafb K5qyRlaFLVCI61Le336om65382rRHQgD6sSoKqVyCneaFHX6ECPjJeLqCIczjcLPD03g QkdzMNL750kIUSQd+AcZL9EFtyDdNx5E5UHCUBkbxcQPKV8pm+k6awUxvVpV/kKzrGY+ eKcVJzqC+DDPKMtJ0RmAIrS3qPNMO6p8ksHskbS8BbjjiiVPPipOHlNdGsB77nFjra4/ 13nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787740165; x=1788344965; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QveZLHZ1UA6LhKTB0pCtINjffhyivWeyncO8oEF8Ds8=; b=HSKDNeUMR2NuVW4+R+9jGyNA8/0lBDiLVLLZhwPE+lZyszOI6iTXOvv4Vem4eQCwTx Z32dnpcQuB2UT+qEULwEL7tMvcqjlapTQfnwDcLt8KU7JmmLNsaCVxIpO5F5k+MQ9mGb KYkuNexa4D4rFSRbsyWOvv7kVHByYq5RTlOTh2nqWWR5051D0gJho9WF1HSKOrUUXfwZ d2mQvdRvhfHrVjzffMyg6v8O7KiTN6kUoUIX42oAvrI2v/Gp13vCOM+gqqAcpVgtHCoh Qo3QyY4s+rLZ3+G6c1u9w37tjD6c9gW1ShDelUwy5XBJ6XznL8xv0oQeY0SZEvH+Optz ee6g== X-Forwarded-Encrypted: i=1; AHgh+Rr8/FD8htJAEFNMvnE7yGx2xCdXVmAr+9r/ou4tRO3AYA+2KDOP+befsx0JJ+5Qd7972OBjyNvKQ22608I=@vger.kernel.org X-Gm-Message-State: AFuF++kBkMlL4ZIDy57o3Ir1+h3isVoO4j4Z3nAJJIbAtAU2Mb89YTNE AZOwlBx92sTAeK6U35poqk0VYfLkhgnP9J2RD8VW6NNdKUEhD+JAfvnaOzBq5UlcJ4J65EBOxvd eMMcMJPUlQynZGseMjik8L9aX2GZmNQpl5TiJU7cWOJzUSe0UIiVdqfYN/YINTwiRGog= X-Gm-Gg: AR+sD102qkmOeHdHawMNHPxh+ZTZwCkIBJ61TOJO42MYJ6ob6SShDb1u715gR04Z646 vBrABZNj+vdPg59R43U2EH0E+ML7ODmW02IGY1rJyJCfabuOPV+ZShzOj/atxeRlQlvxp8479Ea D4GB72wpIHz6nPLMnueEEqR674i8wWeKjaoBYy+TedgFIbTRS1Hls1kRG1xyzp+s1Wv8qOvWSHu WNzGOyC1RfV7i3gmkxJJc0+G42QqnHB3mgjhAx1Tf5cI61XRIo47lwNH9wY7pxzmonmsOD9WGeS ZHljc5g9mhJo/wHH6Vzx1eby0QgLwczwlkfsuOlaQOXSrUUNO/XLIArZw8xxOaqO8N2Z+Qwk46t QnEzPUnvbMLmKMEkiYwogOuYY5wiN1xRvgIeFhIsZ4TZVkzsAws5XwEsvX6AFQ1GzaA== X-Received: by 2002:a17:90b:520f:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-3966d5f8f84mr12826270a91.9.1787740165125; Wed, 26 Aug 2026 03:29:25 -0700 (PDT) X-Received: by 2002:a17:90b:520f:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-3966d5f8f84mr12826103a91.9.1787740164412; Wed, 26 Aug 2026 03:29:24 -0700 (PDT) Received: from [10.218.1.199] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3283d8861ecsm7249900eec.19.2026.08.26.03.29.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 03:29:23 -0700 (PDT) Message-ID: <611896c5-ce07-4219-a47a-9991bde0c16c@oss.qualcomm.com> Date: Wed, 26 Aug 2026 15:59:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: hd3ss3220: track VBUS enable state per consumer To: Chang Wu , Heikki Krogerus , Greg Kroah-Hartman Cc: Jan Remmet , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260819152027.90994-1-kunjinkao.jp@gmail.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <20260819152027.90994-1-kunjinkao.jp@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=O/oJeh9W c=1 sm=1 tr=0 ts=6a8ec005 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=iLJ8WFLs6lQ_ZW-OyZwA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: PTw_Tt3_nF8V8FavL4P39r2IuayaEbsK X-Proofpoint-ORIG-GUID: PTw_Tt3_nF8V8FavL4P39r2IuayaEbsK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA4NyBTYWx0ZWRfXyX8NSr1DGD8Z sqUps6cvTr2V0X4zTL8lC7ejOMOBc0F1eaO0wOHZgzLYjmI1UxIHog+h7+cZIBFdnHgJNQKVwTi wWjRjqrqp66ytBWAbD6uA3v9PKdYLo/jIJJ6mjG8JUso/vU6nauYUdgOI5qKNKMPb/MP73YweyB +htG+WXhkeCGZ7bkxGkumUdaYUaU3bOI5OeVfPZX8ufFgdj78BvNSIBW6OfDZiOuMnyfO4wfyC+ A9SdSdnxRWp7dwnf9BDVPdxF+MG9e2l6us3kyC2bg/TdZZj/aBg9UQAYzWn2AahXriddTj4ME6G yDLNpKU5hmVrk8fiNy0fhGCU9YcVBLkfcyH8GQuLGm5h/mfSp5anQv5G27ngRRlorzQDu5lmLAi Le/Qbzfaqx0flkc9/cxoOp96KmapwowC3urk7KlSNvpzXyyxtDOovrLDHSs0h7uwvtR2P15nSbB seqLQ/DjuIqWo1GRofw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA4NyBTYWx0ZWRfXxrg+TB8utGd1 Xyg3an/WPSz+zg3nW13cNuhPiBFuH7BVuLIp+y+WeVwa3ClEazZxs+n7R2oD9pzo+rOqMPFl+tX tpTyqSLHKwY3a4iJ7Vi9MMAubIxT/Qs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_03,2026-08-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260087 On 8/19/2026 8:50 PM, Chang Wu wrote: > regulator_is_enabled() reports the aggregate regulator state, not > whether this consumer holds an enable reference. If another consumer > enables VBUS first, the driver can skip its own regulator_enable() call > and later attempt to drop a reference it never acquired, triggering an > unbalanced regulator disable warning. > > Track successful enable and disable calls locally. Keep the state > unchanged when an operation fails so a later role or ID notification > retries the operation while this consumer keeps balanced references. > > Fixes: b3f9d6e491fd ("usb: typec: hd3ss3220: Check if regulator needs to be switched") > Cc: stable@vger.kernel.org > Link: https://github.com/qualcomm-linux/kernel/issues/472 > Signed-off-by: Chang Wu Reviewed-by: Krishna Kurapati > --- > Testing: > - scripts/checkpatch.pl --strict: passed > - Qualcomm CI checkpatch, sparse, DT and UAPI checks: passed > - Not tested on hardware > > drivers/usb/typec/hd3ss3220.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c > index d0de5a2488f9..4eec90c82bae 100644 > --- a/drivers/usb/typec/hd3ss3220.c > +++ b/drivers/usb/typec/hd3ss3220.c > @@ -62,6 +62,7 @@ struct hd3ss3220 { > int id_irq; > > struct regulator *vbus; > + bool vbus_enabled; > }; > > static int hd3ss3220_set_power_opmode(struct hd3ss3220 *hd3ss3220, int power_opmode) > @@ -208,7 +209,7 @@ static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on) > { > int ret; > > - if (regulator_is_enabled(hd3ss3220->vbus) == on) > + if (hd3ss3220->vbus_enabled == on) > return; > > if (on) > @@ -216,9 +217,13 @@ static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on) > else > ret = regulator_disable(hd3ss3220->vbus); > > - if (ret) > + if (ret) { > dev_err(hd3ss3220->dev, > "vbus regulator %s failed: %d\n", on ? "enable" : "disable", ret); > + return; > + } > + > + hd3ss3220->vbus_enabled = on; > } > > static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220) > > base-commit: e1e6e541c5c9cf548e9fdc35fc26808c82074440